From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#24240: 25.1.50; window-state-put, image-mode and window scrolling Date: Thu, 18 Aug 2016 10:42:06 +0200 Message-ID: <57B574DE.2090004@gmx.at> References: <87bn0ttyzc.fsf@hochschule-trier.de> <57B2F247.9050601@gmx.at> <8737m4u8j6.fsf@hochschule-trier.de> <57B420A2.6020608@gmx.at> <87mvkblm6o.fsf@hochschule-trier.de> <57B48714.40406@gmx.at> <87inuzl6hc.fsf@hochschule-trier.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1471509800 30503 195.159.176.226 (18 Aug 2016 08:43:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Aug 2016 08:43:20 +0000 (UTC) Cc: 24240@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 18 10:43:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baIuy-0007jc-ML for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2016 10:43:16 +0200 Original-Received: from localhost ([::1]:51417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baIuv-0000fn-TV for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2016 04:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baIun-0000dy-LI for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 04:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baIuk-00070S-D8 for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 04:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baIuk-0006za-Ak for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 04:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1baIuj-0005Hc-Uk for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2016 04:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Aug 2016 08:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24240-submit@debbugs.gnu.org id=B24240.147150974520257 (code B ref 24240); Thu, 18 Aug 2016 08:43:01 +0000 Original-Received: (at 24240) by debbugs.gnu.org; 18 Aug 2016 08:42:25 +0000 Original-Received: from localhost ([127.0.0.1]:60787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baIu9-0005Gf-GA for submit@debbugs.gnu.org; Thu, 18 Aug 2016 04:42:25 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:49540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1baIu7-0005GM-7j for 24240@debbugs.gnu.org; Thu, 18 Aug 2016 04:42:23 -0400 Original-Received: from [192.168.1.100] ([212.95.7.56]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MQzUc-1bkek2019y-00UJbO; Thu, 18 Aug 2016 10:42:16 +0200 In-Reply-To: <87inuzl6hc.fsf@hochschule-trier.de> X-Provags-ID: V03:K0:NfOjKKAZqrm9DnJ6DwSCJSQSQgpImNxlPny1CzrcDXjSdVbL8c0 tsEWeMG+yFwe5BY/1RrbtOyjDriuWGuiT2VUZQjpkSsc+tNxG1sn8QoA+Mr2e4/zPH6tZav 5gQsOvphAe+6iH0jbHBCXUOg+GU1HuLg3y+Uhi2NvWxv7EPfhGX+1cIH9py2BGILZGZOen6 zH7zWDzUEtgxIXRWMP5Rg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HhRx3vAh2nk=:N3uIf5x8K+v91UB4fi2zb2 OQoD8hD6TlNwaztlee0zwGdz+e9IWBpEWMM5iBUZDx5sEWti1ZREF1m9Z+SnHejvxLe2tXy/t pR7zV7dKAeUHH4nCdOucMO7MXPJVt53PzW5GrxDp5zFlRQc4JL/F18WaefVJDrqpG5QY6rm3r nYY2dswTLDNpNp2/EAhRdBJzUaLCx3T1XhxQ1353YyhlSRlhmpcOq8mxsSff4M8uqUibdstIX dKORvE9IpqsZFNM9klmXum4wWYifse8UVOvcieINHzi6nPIftd/ah4X75rZrFlqXZFC29ZRXx lSW6b34xbP1v7iuizoyi638WRVNaEN/xqDtI9sap/keyV15VJoogePIXW9T/+n1GemXx1/avr hh7VL1nBko1rv9KslawOFP4cBh2IOXH6TiPL0OIUYDTy70smmP7nPRcB/9RPJJzoq5wr1tyIO DcX0juDW/YZKJV8UXI95fDSITfcaV9nYs/fLUCB+7FcRTS5VhzWUfdXNJGq4Hsy3O1JDK+4J1 FCrT3yeZGqxD3WyYSUl3sKA8U9J3ZHKKOL2yGmL/GoNhjZM170+7deHQgzv8TDHX+gtJ7bI33 vtLY/50qPlsMyWKVM/lzqXkYCEqrayFsflBVPS4OXvQNSrU09QWug7Q/N4VICb1CVHmzD6NP0 q9bUb1+SlOQIp6WWqCBzb9sDbt/nPl+SOCrE6KhOFL38wBDI4fE/GiG6o+wNSutzliXBWSJVP G7SZQBxMJpd/ZuqshzLxSoOwvoCT8t5XfSQvbzR765c+UPo3pbTvCN9AT4PCMIWi4r3wrt9p X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122349 Archived-At: >> But do you mean that setting NOFORCE alone will handle your bug alrea= dy >> and we don't need =E2=80=98frame-after-make-frame=E2=80=99 after all?= > > Yes, it would. OK. Pushed to master. In any case it fixes a scenario like the followin= g: (let (window state point start) (find-file "../lisp/window.el") (forward-line 30) (setq window (selected-window)) (setq state (window-state-get window)) (setq start (window-start window)) (setq point (window-point window)) (message "Before split - %s ... start: %s ... point: %s" window start= point) (sit-for 3) (split-window window) (message "After split - %s ... start: %s ... point: %s" window start = point) (sit-for 3) (window-state-put state window) (sit-for 0) (message "Final - %s ... start: %s -> %s ... point: %s -> %s" window start (window-start window) point (window-point window))) > At least in the case of image-mode, it would actually be preferable to= > let window-state-put override image-mode-reapply-winprops's scrolling,= > because it has the correct value. I don't know how familiar you are > with image-mode, Not at all. > but if it has no record for a particular window, it > restores the value last set in any window. The difference would be > visible in case the buffer is shown in more than one window (with > different scroll values). And you mean that the situation after your fix is as expected and the single, final call of =E2=80=98window-configuration-change-hook=E2=80=99 = I proposed earlier would spoil that? Technically spoken, it would fail because =E2=80=98window-state-put=E2=80=99 creates windows anew and for a new win= dow image-mode has no record of the previous position of the image in that window? Do you agree with that interpretation? martin