From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el Date: Sat, 13 Aug 2016 10:24:26 +0200 Message-ID: <57AED93A.4090902@gmx.at> References: <87mvkhivpu.fsf@hochschule-trier.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1471076722 19006 195.159.176.226 (13 Aug 2016 08:25:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Aug 2016 08:25:22 +0000 (UTC) To: Andreas Politz , 24213@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 13 10:25:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFp-0004nW-4P for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Aug 2016 10:25:17 +0200 Original-Received: from localhost ([::1]:56294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYUFm-0007MO-4S for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Aug 2016 04:25:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYUFd-0007L0-IM for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2016 04:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYUFa-0006QY-7j for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2016 04:25:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYUFa-0006QU-43 for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2016 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bYUFa-0000aY-0H for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2016 04:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2016 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24213-submit@debbugs.gnu.org id=B24213.14710766832217 (code B ref 24213); Sat, 13 Aug 2016 08:25:01 +0000 Original-Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 08:24:43 +0000 Original-Received: from localhost ([127.0.0.1]:55698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFG-0000Zh-N4 for submit@debbugs.gnu.org; Sat, 13 Aug 2016 04:24:42 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:50053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYUFF-0000ZU-9O for 24213@debbugs.gnu.org; Sat, 13 Aug 2016 04:24:41 -0400 Original-Received: from [192.168.1.100] ([212.95.7.38]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MCcvy-1bPApo2jAI-009OvQ; Sat, 13 Aug 2016 10:24:30 +0200 In-Reply-To: <87mvkhivpu.fsf@hochschule-trier.de> X-Provags-ID: V03:K0:zu+ov45ETJ9D93eJKI+aAnefl6qtABhZ2xnqazEoic2T2SJnTXt XtJ82BpEL03sfZM+6Z7m63wV14sSKhIOCybfpYRc4/Du2fuRcqiwmSCez9bozjsmKVlTtET Ir/foKe74v5wxvwfyxDhXd11ipGzw2DRFS6s8TMuuCalGBm8FZBDTQnNwSL088yHZyhCoos /4grPKTKfndw3I5QbN4xA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Gq2FHZG47VM=:Dmk6emHgnbcrk/ckzGFkSJ 1mZpFZcHO3DtnBDKLvdOGamF9mD6kqVl843a02lWV14pfMbMk0LyVvpET9I2vC0AHWcP+I++w ZIT5a2xzGnyfvrAjNetYf/qkr5NqIz1Q2d9/rBusHecUhghLrN7HiIj9a0r05TYRF+I+HGnjW hRy6IK0tF6/dMfYNAFKKdYgp/iFcAjYQ/XjUkhiq364uCzPgkl8WENJUv/KxpDx50KrmbB0T/ T6Z+Lii5wR/jxEfTNxZne1Du7H73VmlsyVQlotDSfB2bMnTvw4nGTBDAli1k4epvQwruRu4MS 4VhKk7qGzLhiRqL+oxG6oHCHAkDYWt6tLVEco3XjK4Y7lz7x4x/TG7gzLUYNzhyE730KeCx/+ sqtWUb5fflxKvSdCkOSY799PJoWE+4mkmucERkm+CaNFfSWpneuwIkT6el6GxDIJp4148xXgy 8ueA/5VKvv3YC36l9eYurCgpzsWbq/oDfDr5erh/+NpAMv8ub6YUfp5W0V8HJsoxLxlAWfjzY RA2bBMgdsqTdlvgprMc7yC9ndhrC39EuPP7KchnIyyXcRaaw6L8DDNeCHe5kgjTumH5079NvE kJtmyf0oA8ufp0sd3urt6rMACs8yfALD7EIrpB3b49iGOEz4LArVvTTOQSfRlF3ahxgSHp+bb oTrtaad/PvP/bVc7QrFt0F9jRaTZv2/Q67kZeXbPl53p1QVSGnkNExrzTb9ZiMpPuhojioMMs 5F8ML+CUES9lEKPX8t8v5T50pCurVSUbGwD9XVt/se6pKtcKmL7A3C2G/6hLrrU4ZyWj7w37 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122154 Archived-At: > The register.el commands display a preview of register contents, using= > display-buffer in register-preview. Later, when some register was > chosen by the user, the window showing this preview is closed via > delete-window. > > It seems to me, that this call should be replaced by a call to > quit-window, because this function does the right thing: It only delet= es > the window if it was previously created and otherwise shows the previo= us > buffer in that window. > > If that analysis can be agreed upon: Grepping through lisp/*, I found = 62 > uses of delete-window outside window.el. I assume that most of those > applications are problematic in the same way (e.g. finder.el). I agree on that analysis. At least for every window created or used by =E2=80=98display-buffer=E2=80=99 the appropriate action should be =E2=80=98= quit-window=E2=80=99. Could you provide a patch fixing the (about ten) most obvious cases first? Thanks, martin