From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dave Abrahams Newsgroups: gmane.emacs.bugs Subject: bug#67870: 29.1; Eglot missing or un-findable advertised feature Date: Mon, 18 Dec 2023 11:10:19 -0800 Message-ID: <577DE428-A159-4E7B-917A-ED8371F74195@boostpro.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67870@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 18 20:11:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFJ1S-0007N1-7h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Dec 2023 20:11:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFJ14-0003GJ-Nw; Mon, 18 Dec 2023 14:11:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFJ12-0003Fj-CR for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 14:11:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFJ12-0003Jj-4A for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 14:11:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFJ13-0006Bg-O7 for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 14:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dave Abrahams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2023 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67870 X-GNU-PR-Package: emacs Original-Received: via spool by 67870-submit@debbugs.gnu.org id=B67870.170292664323725 (code B ref 67870); Mon, 18 Dec 2023 19:11:01 +0000 Original-Received: (at 67870) by debbugs.gnu.org; 18 Dec 2023 19:10:43 +0000 Original-Received: from localhost ([127.0.0.1]:33622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFJ0k-0006AY-Ej for submit@debbugs.gnu.org; Mon, 18 Dec 2023 14:10:42 -0500 Original-Received: from mail-yw1-x1136.google.com ([2607:f8b0:4864:20::1136]:51590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFJ0h-00069z-DU for 67870@debbugs.gnu.org; Mon, 18 Dec 2023 14:10:40 -0500 Original-Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5d33574f64eso27116447b3.3 for <67870@debbugs.gnu.org>; Mon, 18 Dec 2023 11:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boostpro-com.20230601.gappssmtp.com; s=20230601; t=1702926631; x=1703531431; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vUK4MjtLfb2A28+fLglJ4ZAsWcR83lprPotYz6mk7EE=; b=SNphSYqp5OnkzyNsqQ8W05tEjCnG9eJodDS+i85XnGUNX1qRV/CMM0ENYp1eKyI5ha 5BUMQbq3JFrvXbBIaTzq3ntWc2NyCwUSJlBtYcjc8cynsotnZfuAvoRxa9uD/A8cE7GI JAeelgtkGQPcAoRiGXiZplJnDQ2tFNC+ZW7/fIS3ywXPp2VjT/XAsrMONXEIpj8duNqK gj7w6kJxTXiNDGlsU9DRZymioP1QOKuH2EXCumpFmr6UC7qAPdKNDvLS9kjfUq0O53Nl 3f+/4JCZqa4qgKMUZgPnzPrCwrML0pMAV/eHjZ/K8O+lY/GgZZVEz79TqGOujfBszf99 Y5FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702926631; x=1703531431; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vUK4MjtLfb2A28+fLglJ4ZAsWcR83lprPotYz6mk7EE=; b=JEZxHQ7djETu63yNbQk2knbl8Nam+wsm7P1yt1BPtlGnUNyLBKtWlO5ajFdAtig08H 9LXRDqLiztCUjZMUl/BMMqp0bha/slGRj9ZOPcxaJLfd2zxcuqjMVXbyzDdEeZsPQemZ M886IC6gfInEmtjijbncYCK3q+wIFftT7DZt39TumY5u3SW1V970je7omjsjnXqAsNeA m8npbn3H8+dM/XNVfa2pJcV56IPJvIIGXA8/Zip12qkMlUo3oJ70hBKjoABMPIk7U9ro p6AQXriU2VmHNAkzLrX5BOL5IuIUDdpAt693zCVYT9ds0g0AvhJKBvLxRvFSfoSyQYCB plQw== X-Gm-Message-State: AOJu0YzOLTfHHYGQfQY7zZ+Rintb13rksaa8aG9ZNt7mXOIn87XI47ZE Z0Vm/LgCI1gtsxkD++4EiyyvAQ== X-Google-Smtp-Source: AGHT+IESOFK9879lz0flIorb95mUhmqT9MEa9ItnvcYIFnIfd9GRNo2Z67dS228rVW/2q3Lfo3XBlQ== X-Received: by 2002:a0d:e60d:0:b0:5e7:9010:e05f with SMTP id p13-20020a0de60d000000b005e79010e05fmr29515ywe.1.1702926631588; Mon, 18 Dec 2023 11:10:31 -0800 (PST) Original-Received: from smtpclient.apple (69-209-31-205.lightspeed.sntcca.sbcglobal.net. [69.209.31.205]) by smtp.gmail.com with ESMTPSA id v4-20020a818504000000b005d9729068f5sm9086012ywf.42.2023.12.18.11.10.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Dec 2023 11:10:31 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3774.200.91.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276479 Archived-At: Of course it's easy for *you* to find; you know what you're looking for. = I wouldn't have filed a bug if I wasn't having trouble, and I figured = the experience of someone not familiar with the package might count for = soimething. I looked for the words "suggested" and "fixes" and couldn't = find anything. I googled. I looked at flymake docs too because given = the phrasing I thought it might have been there. If you'd used some of = the distinctive words that could be found in the eglot manual around = these commands (e.g. quickfix, action, rewrite), I wouldn't have had any = trouble. "fix" by itself is a bit too short and common to be a good = search keyword. > On Dec 18, 2023, at 9:00=E2=80=AFAM, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > On Sun, Dec 17, 2023 at 7:40=E2=80=AFPM Dave Abrahams = wrote: >=20 >> The info page for Eglot says: >>=20 >> 3.1 Eglot features: >>=20 >> =E2=80=A2 On-the-fly diagnostic annotations with server-suggested = fixes, via >> the Flymake package (*note (flymake)Top::). >>=20 >> But I can find no evidence of the support for server-suggested fixes >> either in flymake or in eglot itself. I am working with an LSP = server >> that offers fix-its but can't find any way to apply them. >=20 > Isn't very hard to find in "3.3 Eglot commands" IMO >=20 > =E2=80=98M-x eglot-code-actions=E2=80=99 > =E2=80=98M-x eglot-code-action-organize-imports=E2=80=99 > =E2=80=98M-x eglot-code-action-quickfix=E2=80=99 > =E2=80=98M-x eglot-code-action-extract=E2=80=99 > =E2=80=98M-x eglot-code-action-inline=E2=80=99 > =E2=80=98M-x eglot-code-action-rewrite=E2=80=99 > These commands allow you to invoke the so-called =E2=80=9Ccode = actions=E2=80=9D: > requests for the language server to provide editing commands for > correcting, refactoring or beautifying your code. These commands > may affect more than one visited file belonging to the project. >=20 > The command =E2=80=98eglot-code-actions=E2=80=99 asks the server = if there [are] any code > actions for any point in the buffer or contained in the active > region. If there are, you have the choice to execute one of them > via the minibuffer. >=20 > A common use of code actions is fixing the Flymake error > diagnostics issued by Eglot (*note (flymake)Top::). Clicking on a > diagnostic with =E2=80=98mouse-2=E2=80=99 invokes = =E2=80=98eglot-code-actions-at-mouse=E2=80=99 > which pops up a menu of available code actions. The variable > =E2=80=98eglot-diagnostics-map=E2=80=99 can be used to control the = mouse binding. >=20 > Other commands execute a specific code action. For example, > =E2=80=98eglot-code-action-organize-imports=E2=80=99 rearranges = the program's > =E2=80=9Cimports=E2=80=9D--declarations of modules whose = capabilities the program > uses. >=20 >> Either what's meant by this should be clarified, leading to = discoverable >> instructions for exploiting the feature, or the text should be = removed. >=20 > That's just a summarized list of the main features, a detailed = description > doesn't of how to use the feature doesn't belong there. But patches = welcome for > a link down to 3.3 (and fixing the typo while you're at it). >=20 > Jo=C3=A3o