From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#38296: Allow Option key to be modifier for non-char key and mouse events Date: Tue, 26 Nov 2019 22:36:32 +0100 Message-ID: <576F8E92-AC86-4CBA-9F59-99071A55F775@acm.org> References: <20191121211207.GA96045@breton.holly.idiocy.org> <20191126203324.GA7891@breton.holly.idiocy.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49104"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38296@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 22:41:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZiaR-000Cbt-7t for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 22:41:31 +0100 Original-Received: from localhost ([::1]:59186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZiaP-0007kL-7R for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 16:41:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51768) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZiaG-0007gU-Bk for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 16:41:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZiW6-0002rs-4B for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 16:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZiW5-0002rc-PP for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 16:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZiW5-0005dq-M1 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 16:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 21:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38296-submit@debbugs.gnu.org id=B38296.157480420021649 (code B ref 38296); Tue, 26 Nov 2019 21:37:01 +0000 Original-Received: (at 38296) by debbugs.gnu.org; 26 Nov 2019 21:36:40 +0000 Original-Received: from localhost ([127.0.0.1]:53101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZiVk-0005d7-Ed for submit@debbugs.gnu.org; Tue, 26 Nov 2019 16:36:40 -0500 Original-Received: from mail178c50.megamailservers.eu ([91.136.10.188]:50350 helo=mail70c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZiVh-0005cx-Ge for 38296@debbugs.gnu.org; Tue, 26 Nov 2019 16:36:38 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1574804195; bh=EUdv7YZvZmxYohCMUsnVLDH40+2to/cKA6EkeLAaFok=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=TW1z67reXrvxCLzmJnTffK8NUbTlI8HYhZ7ZUGe2FqFdLUB8KDIXORmRcf8EznWJT qK4BPEUEgp7nvWQlEKxMigZ4XLyqQYLYADfj7as6TAdG9UT22EhuavrpHu5rZipLBV bp8PcTpUmsFAoFafMYlgxE+FEl2GD+OB8pOsuJas= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-3d4ce655.032-75-73746f71.bbcust.telenor.se [85.230.76.61]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xAQLaXSw021160; Tue, 26 Nov 2019 21:36:34 +0000 In-Reply-To: <20191126203324.GA7891@breton.holly.idiocy.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0214.5DDD9AE3.0022, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c6bVvi1l c=1 sm=1 tr=0 a=2CSmQ8xxRPzqj0RSDwU2Pw==:117 a=2CSmQ8xxRPzqj0RSDwU2Pw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=tj_05d-W_oVTqGAcMA8A:9 a=QEXdDO2ut3YA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172493 Archived-At: 26 nov. 2019 kl. 21.33 skrev Alan Third : > I had wondered about doing something like this, but not as flexible. > Is this the exact interface used by the Mac port? I=E2=80=99m not keen = on the > word =E2=80=98ordinary=E2=80=99, but there=E2=80=99s no use in us = doing something different. Yes, it's the exact interface, except that the Mac port also allows an = optional :button property for emulating multi-button mice. I didn't = bother including that, but nothing prevents adding it later on. > Thanks, it looks good to me. I=E2=80=99ve got a few nitpicks re. the > documentation: Those are always welcome! > +The modifiers themselves can be customised; >=20 > I think that should be a colon at the end, not a semi=E2=80=90colon, = although > my grasp of semi=E2=80=90colon use is tenuous at best. A @pxref command immediately follows, so the entire sentence would come = out as The modifiers themselves can be customised; see Mac / GNUstep = Customization. Wouldn't the semicolon be more appropriate there? It does not really = precede an elaboration, just another main clause. I'm no native English speaker, though. > +The value of each variable is either a symbol, describing the key for > +any purpose, or a list on the form > ^ > of I'm torn here. What about 'having' instead? > +@key{Option} key in macOS is normally used for composing additional >=20 > I would remove the word =E2=80=98normally=E2=80=99. I think it=E2=80=99s= redundant since we=E2=80=99re > already talking about =E2=80=98standard behaviour=E2=80=99. Yes, but the phrase is then conditional on the symbol actually being = 'none'. Perhaps replacing 'normally' with 'then' would do? > Unless anyone else has objections I don=E2=80=99t see any reason not = to push > this. Thank you very much for the review!