From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.bugs Subject: bug#25552: 26.0.50; load cl unintendedly Date: Thu, 02 Feb 2017 22:30:57 -0800 Organization: Newt Software Message-ID: <57610.1486103457@olgas.newt.com> References: <87vasuow8m.fsf@users.sourceforge.net> <29437.1486087555@alto> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1486103535 31349 195.159.176.226 (3 Feb 2017 06:32:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 06:32:15 +0000 (UTC) Cc: yamaoka@jpl.org, Mike Kupfer , 25552@debbugs.gnu.org, npostavs@users.sourceforge.net To: Jeffrey Honig Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 03 07:32:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZXPk-0007rs-DE for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 07:32:08 +0100 Original-Received: from localhost ([::1]:60407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZXPp-0004E4-Fy for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 01:32:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZXPi-0004CF-JZ for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 01:32:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZXPe-0000PS-8k for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 01:32:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZXPe-0000PK-55 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 01:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZXPd-00012G-OB; Fri, 03 Feb 2017 01:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bill Wohler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, mh-e-devel@lists.sourceforge.net Resent-Date: Fri, 03 Feb 2017 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25552 X-GNU-PR-Package: emacs,mh-e X-GNU-PR-Keywords: Original-Received: via spool by 25552-submit@debbugs.gnu.org id=B25552.14861034763931 (code B ref 25552); Fri, 03 Feb 2017 06:32:01 +0000 Original-Received: (at 25552) by debbugs.gnu.org; 3 Feb 2017 06:31:16 +0000 Original-Received: from localhost ([127.0.0.1]:54420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZXOp-00011F-Qk for submit@debbugs.gnu.org; Fri, 03 Feb 2017 01:31:16 -0500 Original-Received: from ecbiz204.inmotionhosting.com ([173.205.126.39]:27547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZXOo-000113-1T for 25552@debbugs.gnu.org; Fri, 03 Feb 2017 01:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-reply-to:Subject:From:cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gH8ggJQoV/d8LdRHvqrU27eMwtVhpj8nYZRLFAwPk+U=; b=GEEtC2GzlXE3M94GneY7XvlxAj nNdARyYDk02DOSlTUoAl2zjZEPNPfp40X57zNzQSMD/7Zs39meuBy/S32R1Nb9q6NX9Pff7hmzTEA TBHuyUG1m28gQLJhq4JSiM6ACICcn7C6jQZMUZN/5UHOxhLcLdK58Hc2xHje7XrgtQT/NQkl/9sD9 IIojEJp9bV1OtWCSHWPH31bNdqyvMBnnV2vQsI/lGiO++kqo6qYXqfqYeXjAMbzouOZLMkVjTR/gk y1KHbtB9GpE7t7TWU/mrZBDIVu2vI5/Zj0c4XVMIsesBlb+agJ+aeftgrfHMtCvzDf3LVWYByrYNv bTKKa19g==; Original-Received: from c-73-93-110-194.hsd1.ca.comcast.net ([73.93.110.194]:57466 helo=olgas.newt.com) by ecbiz204.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cZXOb-001R0a-Qx; Fri, 03 Feb 2017 01:31:02 -0500 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 1DE64380956; Thu, 2 Feb 2017 22:30:57 -0800 (PST) In-reply-to: Comments: In-reply-to Jeffrey Honig message dated "Thu, 02 Feb 2017 21:21:22 -0500." X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.4.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png X-OutGoing-Spam-Status: No, score=-0.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ecbiz204.inmotionhosting.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - newt.com X-Get-Message-Sender-Via: ecbiz204.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz204.inmotionhosting.com: wohler@newt.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128906 Archived-At: I don't have any objections if it runs on all supported versions of Emacs that we support (a conversation we should probably have again since we've had an Emacs release). I'm happy to say we support the version of Emacs in Debian stable, which is 24 and is what I'm running. I'll test the patch this weekend and reply. Jeff, in the past, you ran the oldest version. What are you running now? If it's older than 24 or 25, can you please test this patch as well? Jeffrey Honig wrote: > Bill should weigh in on this change, he did extensive work in this area. >=20 > Thanks >=20 > Jeff >=20 > -- > Jeffrey C. Honig > http://jch.honig.net > GnuPG ID:14E29E13 > Keybase: jchonig >=20 > On Thu, Feb 2, 2017 at 9:05 PM, Mike Kupfer w= rote: >=20 > npostavs@users.sourceforge.net wrote: >=20=20=20=20 > > Mike Kupfer writes: > > > > > Hi Katsumi and Glenn, I applied Glenn's patch to 25.1.90, and I'm= afraid > > > that it introduced a failure. > [...] > > I guess it's because defun-mh checks whether the alias target is fb= ound > > at compile time: > > > >=C2=A0 =C2=A0 =C2=A0(defmacro defun-mh (name function arg-list &rest= body) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0"Create function NAME. > >=C2=A0 =C2=A0 =C2=A0If FUNCTION exists, then NAME becomes an alias f= or FUNCTION. > >=C2=A0 =C2=A0 =C2=A0Otherwise, create function NAME with ARG-LIST an= d BODY." > >=C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((defined-p (fboundp function))) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(if defined-p > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0`(defalias ',name ',= function) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0`(defun ,name ,arg-list ,@b= ody)))) > > > > It would be better to check at runtime: > > > >=C2=A0 =C2=A0 =C2=A0(defmacro defun-mh (name function arg-list &rest= body) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0`(if (fboundp ',function) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defalias ',name ',functio= n) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defun ,name ,arg-list ,@body))) > > > > And/or require `mail-abbrev' at compile time > > > > --- i/lisp/mh-e/mh-compat.el > > +++ w/lisp/mh-e/mh-compat.el > > @@ -260,7 +260,7 @@ 'mh-line-end-position > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 'line-end-position > >=C2=A0 =C2=A0 =C2=A0 'point-at-eol)) > > > > -(mh-require 'mailabbrev nil t) > > +(eval-and-compile (mh-require 'mailabbrev nil t)) > >=C2=A0 (defun-mh mh-mail-abbrev-make-syntax-table > >=C2=A0 =C2=A0 mail-abbrev-make-syntax-table () > >=C2=A0 =C2=A0 "Emacs 21 and XEmacs don't have `mail-abbrev-make-synt= ax-table'. >=20=20=20=20 > Thanks, Noam! >=20=20=20=20 > I did some light testing of Noam's change to defun-mh plus Glenn's > patch.=C2=A0 The problem that I reported is gone, and I haven't seen = any > other issues.=C2=A0 I did the testing with both Emacs 25.1.90 and mas= ter > (7cb7a58). >=20=20=20=20 > Does anyone on the MH-E dev team have any concerns about this > combination of changes? >=20=20=20=20 > mike >=20 > ---------------------------------------------------------------------= --------- > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > mh-e-devel mailing list > mh-e-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mh-e-devel >=20 >=20 > ---------------------------------------------------- > Alternatives: >=20 > ---------------------------------------------------- --=20 Bill Wohler aka http://www.newt.com/wohler/ GnuPG ID:610BD9AD