From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#70847: 29.3; eshell scripts "from anywhere" Date: Tue, 28 May 2024 14:51:07 -0700 Message-ID: <5760b900-2b5e-14c4-b01d-b1ab21198df8@gmail.com> References: <87h6f6c1hk.fsf@librehacker.com> <87le3tvi3b.fsf@librehacker.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70847@debbugs.gnu.org To: Christopher Howard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 23:53:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sC4kh-00075B-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 23:53:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sC4kY-0007Kv-4J; Tue, 28 May 2024 17:52:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sC4kX-0007Kk-15 for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 17:52:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sC4kW-000678-M4 for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 17:52:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sC4kf-0006Um-PY for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 17:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70847 X-GNU-PR-Package: emacs Original-Received: via spool by 70847-submit@debbugs.gnu.org id=B70847.171693314624891 (code B ref 70847); Tue, 28 May 2024 21:53:01 +0000 Original-Received: (at 70847) by debbugs.gnu.org; 28 May 2024 21:52:26 +0000 Original-Received: from localhost ([127.0.0.1]:59344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC4k5-0006TN-Oi for submit@debbugs.gnu.org; Tue, 28 May 2024 17:52:26 -0400 Original-Received: from mail-pl1-f177.google.com ([209.85.214.177]:53469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC4k4-0006T1-89 for 70847@debbugs.gnu.org; Tue, 28 May 2024 17:52:25 -0400 Original-Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1f44b594deeso10665325ad.2 for <70847@debbugs.gnu.org>; Tue, 28 May 2024 14:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716933069; x=1717537869; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=RTF2KtlliHcC90FddVH4XEDHawHsA0arFgkz9MsWNTA=; b=fLmHqZplNReQpsLR0i+59GIf/DRp5C+cb2K47aFwHSxUuIGow+OLHuF9gBED/2dqsT 0wX+hkHOh4Ka3VSVrs8DpQTvT33ssb1Nsdw3WSXNX5CC0pnwt84yIRC1IORySXrYaNGu fU0UUFw9LADHPo3Xs/NJR5CjZzSS9Ue3xJN9J4TYLaVSsD08swht6513S1Ksq9VQcSTy oPmXFLc6Ac3JQQVfyy3eesqqrIeqO2LdgU5mvsGySbTaHouGu8VVGRfL8gWr+Fd1faFw WJV33a0V4GknYx13OXQTkE+Y9lD3SDDalM4puIFXqvjg5u1QUO2fjSoXCRzix93rhiYn vDtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716933069; x=1717537869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RTF2KtlliHcC90FddVH4XEDHawHsA0arFgkz9MsWNTA=; b=fMGYwKsGq8SWIz9zbecvIb3jqb1OVmPO54DTUdW/4hWGVcPM8YcG2dya1E4pch02bF W6Rfk8BuTOvS1s/Q1jFKbUA5p/g3Zr0LKLWdVxLW89t7Tbu2pokG9Hevl3FPEx5YBeQC hL40Em98lc+76xpQIbZqnU4kxdN/qAtfZZdNXpGDGMBIrp64S3XiZQYoU2YLVAbqfRGS EpA8BKn0Sm5S2wAWlQEln5kLLUifTN4WRGhEehpC0MpB9finVyXALXcIh57L8xlqFUzi qOFstHANjaEB4hl38Ne6GidOgUPxb9GCZ/jFs1LFveJgOIcGcYlcBNzgkLPNRMSUxphW 0XNA== X-Gm-Message-State: AOJu0YzX7PN0Zzah3E0C7zdkTW8gBi0cGSbWGMP7N6CoGq2kxKIuY2GM YrHobEy6ATDB0qjanp3bGSXD5mVorldb/vEysgnZahxqnnDU3Js0 X-Google-Smtp-Source: AGHT+IG9YNmpGE5hIHd7DrZjTryaVZPJZ0cQ8Ep/uavGMrdWsfORZXRGLo8iTgzUd6P7tDu+W+doyQ== X-Received: by 2002:a17:902:e551:b0:1f4:a3a1:a7e5 with SMTP id d9443c01a7336-1f4a3a1ab11mr68408995ad.13.1716933068596; Tue, 28 May 2024 14:51:08 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f44c7592f3sm84765275ad.38.2024.05.28.14.51.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 14:51:08 -0700 (PDT) Content-Language: en-US In-Reply-To: <87le3tvi3b.fsf@librehacker.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286126 Archived-At: On 5/28/2024 12:42 PM, Christopher Howard wrote: > Then, M-x eshell-command echo blah RET > > Under my normal 29.3 I expect to see "blah" echoed to the message area, but instead I get this error: > >> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) >> eshell-add-input-to-history("echo hello") >> eshell-read-command() >> byte-code("\301 \10D\207" [current-prefix-arg eshell-read-command] 2) >> call-interactively(eshell-command record nil) >> command-execute(eshell-command record) >> execute-extended-command(nil "eshell-command" "eshell-comma") >> funcall-interactively(execute-extended-command nil "eshell-command" "eshell-comma") >> call-interactively(execute-extended-command nil nil) >> command-execute(execute-extended-command) Thanks for catching this. I believe this ultimately broke due to the fix in bug#66700, but as far as I can tell, the intended behavior (adding to Eshell's history file for 'eshell-command') had been broken for a lot longer. I've pushed a fix to the master branch for this part. This is one of those bits that's annoying to write regression tests for since it relies on interactive calls and using the minibuffer... I don't think that should impact the other patches I've posted to this bug one way or the other though.