From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Newsgroups: gmane.emacs.bugs Subject: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) Date: Mon, 13 Jun 2016 18:17:02 -0400 Message-ID: <575F30DE.909@live.com> References: <5751FEC2.5080807@live.com> <22y46lx4yq.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VIDLgwsgtfA1jEW2iP0X6Jutaj2nt1nPQ" X-Trace: ger.gmane.org 1465856308 14453 80.91.229.3 (13 Jun 2016 22:18:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2016 22:18:28 +0000 (UTC) Cc: 23692@debbugs.gnu.org To: Stefan Monnier , Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 14 00:18:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCaBT-0001up-85 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Jun 2016 00:18:15 +0200 Original-Received: from localhost ([::1]:59709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCaBS-0006yv-CB for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Jun 2016 18:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCaBM-0006xy-1M for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2016 18:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCaBH-0000im-0x for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2016 18:18:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCaBG-0000ih-UG for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2016 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bCaBG-00046z-HQ for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2016 18:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2016 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23692-submit@debbugs.gnu.org id=B23692.146585623615748 (code B ref 23692); Mon, 13 Jun 2016 22:18:02 +0000 Original-Received: (at 23692) by debbugs.gnu.org; 13 Jun 2016 22:17:16 +0000 Original-Received: from localhost ([127.0.0.1]:39387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCaAV-00045w-Lp for submit@debbugs.gnu.org; Mon, 13 Jun 2016 18:17:15 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.135]:63067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCaAT-00045i-Df for 23692@debbugs.gnu.org; Mon, 13 Jun 2016 18:17:14 -0400 Original-Received: from [128.30.9.143] ([128.30.9.143]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0MDYsf-1bDMyr1d2j-00Gt68; Tue, 14 Jun 2016 00:17:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 In-Reply-To: X-Provags-ID: V03:K0:SMokn602rXUODgFmeIsnDa+FipgpCLVQhzow8xKQWbELZSYIocQ cTjnekCrAtFb4TRDYdn15wRJy1h8FUmJtxe33eS5E3KPt9WgWS2WFRPh9H01dmRVodExdDu wP7+9u1OAo74NEQdRMxU+0HPABQCjvpUGHE1sSDwuzyaCr+snIFOi5t/7bZ2xUtZnVpr9FG Qp5pfYA6GLCbDg/nf/Jrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:419pSfrAkYc=:PdHMmRqkgUJQZpwfu/kbzb I17Zv0dzBWj4iufO5V7goAVxfvgV50dG3fSO80poUgJezCC/zoL8Fa9u4hKOwwhlGSlgIXUiL DlukACpzFdUJAjjCYvmrykTHznGxSRCz++3znl31qAdve6l5R/OT0tafTdFLEdwGyd96oOIMh Hr9ya3WqWwQNV13cae5szmcQw5asFzu3O8THEg2JgmYZXpQ39kIVVOMjf6rPpdz0n6z9ZdDWD wBNZcFxfyGqgZjtAQcDWX00lQbqDBT3rPmtvGfzijfqhJ3iuHPpTAD4FQrdlINZ+KIi2P/vB5 +C1CfJCTw3Uj/GLarvnbbnchrfDS1K+YxxQGWIV2+2Z3rqI02SJ+FhtjTWqBr5M44SdDCaHKy LXXwlmPnzmI0rpYu1gVK7q705CEeXa1BVQA5B+FWAYhI2oAtrSsfEM8PfmFjCUqiI7GJKkPG3 KXKs4oL/jaxmmW1Ew42LfsWEh+49IGIKX7MkH+y7mwMrfjR2KEeOvO93EuMSW9iDNPFwzMvbi m9Tv++zVhSldq5IPQnizLJ7VF7A1fVSdpnkOhSlECDaSjwohWhBWdeZ5RvpGn3hkBUOt+NwG6 OJS6GjT2zlAKlilraKy9iC3Ywg4QxwQ/BCh7GLOSNYKPpCRYtSnY3xIFjX3aE+WZZhLR/w9IN MoAxCDP9pbwKrpu9JIf9gORDDx1uQE11sDD3qcONwGCs+LQs7xPz2w5bt0hUBG9omm08= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119521 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VIDLgwsgtfA1jEW2iP0X6Jutaj2nt1nPQ Content-Type: multipart/mixed; boundary="tB0wCcfPe9OtMO7dWMMQia5OvFTV2QNov" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Stefan Monnier , Glenn Morris Cc: 23692@debbugs.gnu.org Message-ID: <575F30DE.909@live.com> Subject: Re: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) References: <5751FEC2.5080807@live.com> <22y46lx4yq.fsf@fencepost.gnu.org> In-Reply-To: --tB0wCcfPe9OtMO7dWMMQia5OvFTV2QNov Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Yup, works for me! On 2016-06-08 21:47, Stefan Monnier wrote: >>>> When the a single-package file has no autoloads, the call to >>>> update-directory-autoloads leaves the generated autoload files >>>> modified, but unsaved. This causes package.el to prompt the user >>>> about killing a modified file. >=20 > Does the patch below fix the problem for you? >=20 >=20 > Stefan >=20 >=20 > diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el > index 6473e31..9cf96fd 100644 > --- a/lisp/emacs-lisp/autoload.el > +++ b/lisp/emacs-lisp/autoload.el > @@ -1111,7 +1111,8 @@ write its autoloads into the specified file inste= ad." > =20 > ;; Don't modify the file if its content has not been changed, so= `make' > ;; dependencies don't trigger unnecessarily. > - (when changed > + (if (not changed) > + (set-buffer-modified-p nil) > (let ((version-control 'never)) > (save-buffer))) > =20 >=20 >=20 --tB0wCcfPe9OtMO7dWMMQia5OvFTV2QNov-- --VIDLgwsgtfA1jEW2iP0X6Jutaj2nt1nPQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXXzDeAAoJEPqg+cTm90wjKa0P/3MBY1OUwuj9U1PIOiL1wjUV TL/nK82Jtr5+xSb7YiUrEyUrs7C7pTIbcPDGcM04VMqCLc1MYPVficNG8jj6ps/X z/nzxvLTscSTetld/YJ3BObTOUnhDs4eKSWAjo51rvWbu7FoIaJiir7VVl3vsHSC M0k7B8XyOUz4ALU4aCtTcrtAYX0SmhKkxy9pcXXP+LPPUMcc6jp94uP1w4oOSE8W rn5AI2yAB2Sqz7aL4DNE5GsmJeXPl1K1ADTpTnCk8iDqp/OmTwVC3mbPWPKTt2dJ Xgrnbg0kghvyTv7FEF9MXdAKjWwXPf0+8ltbzDAaqOQBnwJe1s9bc3vb3wVkTWu+ FaWuhVI1CnY0I8E4m/OOPYikCdKWNz0pi5/rRz38lB/DuKHZcb/mbRDdx31bGqrL QZ9vA3FOsAPJnGooKA2NEy0x05BeMw279uF724c1q8ZwNyRQy0W18cXWmpUPDzvV wLYzVH3swp4YUav8W67wQsIBetPMJ8mW3fjojKRrIedQgEBti7T665yf0uOcOgvw +af3vElCs70OxSX6OqZth/clydivCjDKZEQDDSbFCjaUOFWLQuutBdmP/yhoX7Yx tzviMZINMrGjGtIY2SMCIukGcSMtkbyCmhojQ7v4tAJZR9D+LduZfzmO1QY6tjGe +FUv76ErdUG8V1xG3Vwu =BiWy -----END PGP SIGNATURE----- --VIDLgwsgtfA1jEW2iP0X6Jutaj2nt1nPQ--