From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Date: Thu, 26 Nov 2020 15:54:56 +0100 Message-ID: <5722D619-98C0-421B-84B5-F30B858FBDF8@acm.org> References: <6F768DED-2E1B-4D06-A776-FFA162AC32AD@acm.org> <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> <83EC926B-DE9E-48BC-8FD2-C7CB3617AD50@acm.org> <871rggs1mk.fsf@gnus.org> <87zh34p64t.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30302"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Shigeru Fukaya , 44861@debbugs.gnu.org, Stefan Kangas , Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 15:56:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiIh4-0007lT-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 15:56:22 +0100 Original-Received: from localhost ([::1]:39512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiIh3-00042O-C4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 09:56:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiIgm-00041u-Ml for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:56:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiIgk-0000Va-11 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:56:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiIgk-0001AJ-0U for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 44861-submit@debbugs.gnu.org id=B44861.16064025092557 (code B ref 44861); Thu, 26 Nov 2020 14:56:01 +0000 Original-Received: (at 44861) by debbugs.gnu.org; 26 Nov 2020 14:55:09 +0000 Original-Received: from localhost ([127.0.0.1]:40577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIft-0000f7-Di for submit@debbugs.gnu.org; Thu, 26 Nov 2020 09:55:09 -0500 Original-Received: from mail212c50.megamailservers.eu ([91.136.10.222]:47902 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIfp-0000d9-K9 for 44861@debbugs.gnu.org; Thu, 26 Nov 2020 09:55:08 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1606402498; bh=vyTD+lbvWeD5fDuanX6M5AfjCbK5IxiXtXf/nRx31Vc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=SaRuQquDaqAKtVM0vTtRBr+oprbSevnG2ROwqmexVFhjuYTmp02rHaDV+JD7L/Jyh BTJ2ja9LAnHTxwBxwqP99lS+fNzTx6qlp2fo9p7s0Rt+MtHvq0cDEQ51vl2YHOeKyh Q+XWVGcKxn4rKUMEAzQRDXMIWLd24SRrs82Z1Yp0= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0AQEsuol031597; Thu, 26 Nov 2020 14:54:58 +0000 In-Reply-To: <87zh34p64t.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F24.5FBFC1C2.00A6, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=CeB2G4jl c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=f5oXje33BE8G-T2eEq0A:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194339 Archived-At: 26 nov. 2020 kl. 15.03 skrev Lars Ingebrigtsen : > I started looking at that, and there's a huge pile of calls like >=20 > (replace-regexp-in-string ":" ";" string) >=20 > that can be rewritten to use string-replace. But! Every single case > requires careful analysis, exactly because replace-regexp-in-string = sets > the match data. No it doesn't; the entire body is wrapped in save-match-data. It does set the match data locally for use in the replacement function, = if any, but then string-replace cannot be used anyway. There are other things that may need investigating for a switch to = string-replace: whether case-folding is relevant, and whether a = nil-or-absent argument to FIXEDCASE is intended, an oversight, or = irrelevant. In my experience, most code does not take case-folding into account at = all or tacitly assume it does not apply. (Having a global variable = controlling it is a terrible interface, by the way.) Similarly, most = calls that omit FIXEDCASE do it without any thought that the replacement = would be anything but literal. Thus, the risk isn't very big for either = but these are still issues requiring some consideration.