From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#22660: [PATCH] Implement horizontal scroll-bars in NS port Date: Thu, 28 Apr 2016 08:33:29 +0200 Message-ID: <5721AEB9.4070509@gmx.at> References: <56C05F44.8080400@alice.it> <20160427202031.GA46548@breton.local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1461825264 6086 80.91.229.3 (28 Apr 2016 06:34:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 06:34:24 +0000 (UTC) To: Alan Third , 22660@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 28 08:34:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avfWe-0008Ig-F7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 08:34:12 +0200 Original-Received: from localhost ([::1]:46760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avfWd-00005Q-Sk for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 02:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avfWZ-0008To-Ba for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 02:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avfWU-0000HW-AB for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 02:34:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avfWU-0000HS-6M for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 02:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avfWT-0007Xh-Si for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 02:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 06:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22660 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22660-submit@debbugs.gnu.org id=B22660.146182523028976 (code B ref 22660); Thu, 28 Apr 2016 06:34:01 +0000 Original-Received: (at 22660) by debbugs.gnu.org; 28 Apr 2016 06:33:50 +0000 Original-Received: from localhost ([127.0.0.1]:51103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avfWI-0007XH-7E for submit@debbugs.gnu.org; Thu, 28 Apr 2016 02:33:50 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:56030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avfWG-0007X4-Kv for 22660@debbugs.gnu.org; Thu, 28 Apr 2016 02:33:48 -0400 Original-Received: from [192.168.1.100] ([212.95.7.21]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LpPg1-1bZy0X0i3h-00f77t; Thu, 28 Apr 2016 08:33:32 +0200 In-Reply-To: <20160427202031.GA46548@breton.local> X-Provags-ID: V03:K0:tli8RHtdA2otlJHDBjeB8Ba5VJDzk5pqM2aDjflssUoWUmWNzZw KPvb2BnTIrIjsNuUoJ7mpckvlMZnIIBtvM0W4LK0USG2uDyq7sgFnamQYzkMzXw16jIX8wq jwUGh/8fTEaPzuOTjxWe2kJlCcftDe8oJyxR5cPucueCMQ5nVlpXbjvQeF4wy1O8Z35dvjC W8puZkQtNZN5qgdCxVy4A== X-UI-Out-Filterresults: notjunk:1;V01:K0:XVrp5Txe298=:akv7DpvCVQQkP0D24ZPjGL XM2cfelzW59hhUcqfh4o1ALs3OsOjMtkWzpKNDtH+n/4+F9UG/w1Lm2qptky/QfbwyOOWMn4i XqbWp7q/hB+S50BJTwAmsWZcYQKb9jasfh2epqwKJPIglODS10czuIRg+8ySXMEkaUkFOWlzd q7BxNBGTJaw/7bLPdksG+b1zG2n9hGm6c8iiTfft5cNdYafvqR85+Qr1rkK3JFN3U5ern8m24 NxAUEI7ktVTiCPckZZsGTJVuqpJX5LIJn+r+EDhkLTQIguBuuclLuuHhZWtcmYy3efTZ0wWwK 3Ew7m5dA5V3+W4o5ChzNCekMuTF1oSiuIJllEaBZ0kAf44sICqGxLEglh02FW5w2Tn4RoDNyh mfKZMsLMWvo4TgvJcwCWgztsfNptNvL4itO0IL86owLH/KhPo7YBKCuoOGyhh/vU6nEYFm08A ZaWz1S5yAdw4NsNMIX/cGV6TW0hIE1UiXSJoV3pbg3gRliAxuR7v0WBmr0X31tJurMoTRS+Ke oBagSbmdFfG/bbbMLTdr7KMFV4Nsk8ApKfjK+65it2rQfXH7SE52SA3FBtgnfHdL6gPX2mj3l XY4d0fPdbXFqHOFEIrEIRK1QFrqPmrylfLrKVAjvOl2AJbeqUfgJBCwg3RtaZUg8TVdc75XGO Uj4sw743ODS2W9ilKGUa//xjTSr0M2tLeqVMWcavvS1ROsc9w46Pn9Erdd2jsO1k7HgP7hoXI K875GaA6jMTEOmFDVK7y51MMVO1UmRnRk+3qV1xx1pH2aOYUS9to3cLqcBAFaa/YL10UpWfD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117013 Archived-At: > My attempt at enabling horizontal scroll-bars in the NS port. This > patch also removes the custom NS scroll-bar handlers in favour of the > standard ones. I think this *may* cause behaviour of the vertical > scroll-bars to change slightly. > > I've tried to clean up some of the code as there were a few places > where it didn't make a whole lot of sense to me. I guess that's due to > the code I started with being a partial implementation. Thank you. With the limited testing capabilities of GNUStep it seems to work. Or better: If everything in the GNUStep worked as well as your patch, the GNUStep port might even become usable one day ;-) There is one aspect which might be part of the design but appears nevertheless distracting for somone working mainly on other platforms: When the entire buffer is visible, no sliders/rulers are shown. Now, some people want that in this case the scrollbar area(s) get removed completely. Personally, I'd prefer the sliders/ruler cover the entire scroll bar area with the arrows possibly removed. But maybe the current behavior (which is so here ever since for the vertical case) is standard on NS so don't let my remarks distract you. Personally, I'd vote for including this in Emacs-25. It's a completely self-confined, local patch and we could avoid answering questions like "why don't these work on Macs" after the forthcoming release. In any case, many thanks for the accomplishment, martin