* bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working. @ 2016-03-10 2:15 Keith David Bershatsky 2016-03-10 10:32 ` martin rudalics ` (3 more replies) 0 siblings, 4 replies; 7+ messages in thread From: Keith David Bershatsky @ 2016-03-10 2:15 UTC (permalink / raw) To: 22973 I am unable to set the right-divider-width or left-divider-width greater than 0 as a frame-parameter in Emacs for OSX (10.6.8) --with-ns. The parameters always remain a value of zero. I had never tried setting those parameters prior to today, so I'm not sure if it ever worked correctly. The same settings work fine on Emacs for Windows (XP SP3). STEP 1: On OSX, evaluate (modify-frame-parameters (selected-frame) '((right-divider-width . 3) (bottom-divider-width . 3))) STEP 2: On OSX, evaluate (message "%s" (frame-parameters)) STEP 3: The values for right-divider-width and bottom-divider-width remain as zero, instead of 3. Thanks, Keith ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.50.1 (x86_64-apple-darwin10.8.0, NS appkit-1038.36 Version 10.6.8 (Build 10K549)) of 2016-03-08 built on server.private Repository revision: e0400b72a24d67b53f71c8b97915cae599e36c37 Windowing system distributor 'Apple', version 10.3.1038 Configured using: 'configure --with-ns --without-imagemagick --enable-checking=glyphs CPPFLAGS=-I/Users/HOME/.0.data/.0.emacs/macports/include LDFLAGS=-L/Users/HOME/.0.data/.0.emacs/macports/lib' Configured features: JPEG RSVG DBUS NOTIFY ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: tabbar-mode: t ml-mode: t sd-mode: t buffer-read-only: t Recent messages: ((tool-bar-position . top) (parent-id) (explicit-name . t) (display . "server.private") (visibility . t) (icon-name) (window-id . "1") (top . 0) (left . 0) (buried-buffer-list) (buffer-list #<buffer .scratch> #<buffer *Minibuf-1*>) (unsplittable) (minibuffer . #<window 4 on *Minibuf-0*>) (modeline . t) (width . 172) (height . 52) (right-divider-width . 0) (bottom-divider-width . 0) (name . "SYSTEM") (frame-bufs-buffer-list #<buffer *Messages*> #<buffer .scratch>) (environment) (cursor-color . "yellow") (background-mode . dark) (display-type . color) (window-system . ns) (fullscreen) (alpha) (scroll-bar-height . 0) (scroll-bar-width . 0) (cursor-type bar . 1) (auto-lower) (auto-raise) (icon-type) (title) (buffer-predicate) (tool-bar-lines . 0) (menu-bar-lines . 0) (right-fringe . 8) (left -fringe . 8) (line-spacing) (background-color . "black") (foreground-color . "white") (horizontal-scroll-bars) (vertical-scroll-bars) (internal-border-width . 2) (border-width . 0) (font . "-*-Courier-normal-normal-normal-*-18-*-*-*-m-0-iso10646-1") (fontsize . 0) (font-backend mac-ct)) Load-path shadows: None found. Features: (shadow emacsbug message mml mml-sec epa epg mm-decode mm-bodies mm-encode gmm-utils mailheader sendmail lawlist-ztree lawlist-ys lawlist-ws lawlist-wl elmo-imap4 elmo-localdir modb-standard modb-legacy elmo-internal elmo-flag mmelmo-imap mmelmo-buffer elsp-generic mel-u epg-config lawlist-w3m doc-view jka-compr image-mode ccl lawlist-vl lawlist-view lawlist-undo lawlist-txt lawlist-tm lawlist-tex compare-w diff-mode lawlist-tabbar lawlist-speedbar lawlist-shell info esh-groups ehelp ange-ftp lawlist-sgml lawlist-sb lawlist-ruler lawlist-replace lawlist-rectangle lawlist-re-builder lawlist-python skeleton lawlist-profiler lawlist-print lawlist-php lawlist-perl lawlist-parens lawlist-org lawlist-calendar org-agenda org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func holidays hol-loaddefs cal-menu calendar cal-loaddefs lawlist-neotree lawlist-movement lawlist-mouse lawlist-ml lawlist-misc lawlist-messages lawlist-mc lawlist-markdown noutline outline lawlist-lorem lawlist-linum lawlist-keymap lawlist-js json map thingatpt cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs lawlist-ispell lawlist-isearch lawlist-info lawlist-imenu lawlist-ibuffer lawlist-hl lawlist-grep lawlist-git pcvs-util ido seq server conf-mode lawlist-framebufs lawlist-frame lawlist-fm lawlist-env lawlist-elscreen lawlist-elisp lawlist-dv lawlist-image lawlist-files zeroconf dbus xml lawlist-ds lawlist-dired dired dired-loaddefs format-spec lawlist-diff lawlist-desktop frameset lawlist-saveplace lawlist-debug lawlist-window debug lawlist-css smie lawlist-compile rx lawlist-color lawlist-cm lawlist-cc-mode lawlist-cc-awk lawlist-font-lock cl-macs lawlist-cc-fonts lawlist-cc-guess lawlist-cc-menus lawlist-cc-align lawlist-cc-cmds lawlist-cc-styles lawlist-cc-engine lawlist-cc-langs lawlist-cc-vars lawlist-cc-defs lawlist-cc-bytecomp lawlist-calc lawlist-calc+ lawlist-bk lawlist-bc lawlist-bbdb gnus nnheader subr-x wid-edit mail-parse rfc2231 mailabbrev mail-extr rfc822 timezone lawlist-minibuffer gv lawlist-auth gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr password-cache lawlist-as lawlist-archive lawlist-apropos lawlist-+ lawlist-lcl byte-opt bytecomp byte-compile cl-extra cconv lawlist-help disp-table easy-mmode edmacro kmacro quail help-mode easymenu cl-loaddefs cl-lib pcase derived advice shell pcomplete comint ansi-color ring savehist time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 2450324 203839) (symbols 48 86895 9) (miscs 40 133 370) (strings 32 190656 25104) (string-bytes 1 7252086) (vectors 16 56931) (vector-slots 8 1159733 19632) (floats 8 1851 319) (intervals 56 386 15) (buffers 1000 11)) ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working. 2016-03-10 2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky @ 2016-03-10 10:32 ` martin rudalics 2016-03-11 7:02 ` Keith David Bershatsky ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: martin rudalics @ 2016-03-10 10:32 UTC (permalink / raw) To: Keith David Bershatsky, 22973 > I am unable to set the right-divider-width or left-divider-width > greater than 0 as a frame-parameter in Emacs for OSX (10.6.8) > --with-ns. The parameters always remain a value of zero. I had never > tried setting those parameters prior to today, so I'm not sure if it > ever worked correctly. I don't recall whether this ever worked. As far as I remember, at the time I implemented dividers the GNUstep build was broken and I never tried on OSX. The function supposed to do the work is ns_draw_window_divider in nsterm.m. Can you have a look whether that function gets called in the first place, what its arguments are, why it has no effect and why the parameter is apparently never set (or reset)? Thanks, martin ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working. 2016-03-10 2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky 2016-03-10 10:32 ` martin rudalics @ 2016-03-11 7:02 ` Keith David Bershatsky 2016-05-04 21:42 ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) Alan Third 2017-11-19 2:55 ` bug#22973: OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky 3 siblings, 0 replies; 7+ messages in thread From: Keith David Bershatsky @ 2016-03-11 7:02 UTC (permalink / raw) To: martin rudalics; +Cc: 22973 I would be pleased to do some 22973 debugging in the next few days. I have been busy with work and also another unrelated feature for Emacs, and hope to help debug 22973 in the near future. Thanks, Keith ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; At Thu, 10 Mar 2016 11:32:50 +0100, martin rudalics wrote: > > * * * > > I don't recall whether this ever worked. As far as I remember, at the > time I implemented dividers the GNUstep build was broken and I never > tried on OSX. > > The function supposed to do the work is ns_draw_window_divider in > nsterm.m. Can you have a look whether that function gets called in the > first place, what its arguments are, why it has no effect and why the > parameter is apparently never set (or reset)? > > Thanks, martin ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#22973: [PATCH] Enable dividers in NS (bug#22973) 2016-03-10 2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky 2016-03-10 10:32 ` martin rudalics 2016-03-11 7:02 ` Keith David Bershatsky @ 2016-05-04 21:42 ` Alan Third 2016-05-16 8:20 ` martin rudalics 2016-06-27 22:02 ` Alan Third 2017-11-19 2:55 ` bug#22973: OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky 3 siblings, 2 replies; 7+ messages in thread From: Alan Third @ 2016-05-04 21:42 UTC (permalink / raw) To: 22973 src/nsfns.m: Add colour settings functions to ns_frame_park_handlers. src/nsterm.m (ns_draw_window_divider): ns_focus has to go before the attempt to set the colour. src/nsterm.m (ns_draw_vertical_window_border): This had the same bug as above, although I didn't see any errors. --- src/nsfns.m | 4 ++-- src/nsterm.m | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/nsfns.m b/src/nsfns.m index ea09908..9291f8e 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -983,8 +983,8 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side x_set_icon_name, x_set_icon_type, x_set_internal_border_width, /* generic OK */ - 0, /* x_set_right_divider_width */ - 0, /* x_set_bottom_divider_width */ + x_set_right_divider_width, + x_set_bottom_divider_width, x_set_menu_bar_lines, x_set_mouse_color, x_explicitly_set_name, diff --git a/src/nsterm.m b/src/nsterm.m index 1d48c04..438054f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2951,10 +2951,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. NSTRACE ("ns_draw_vertical_window_border"); face = FACE_FROM_ID (f, VERTICAL_BORDER_FACE_ID); + + ns_focus (f, &r, 1); if (face) [ns_lookup_indexed_color(face->foreground, f) set]; - ns_focus (f, &r, 1); NSRectFill(r); ns_unfocus (f); } @@ -2973,10 +2974,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. NSTRACE ("ns_draw_window_divider"); face = FACE_FROM_ID (f, WINDOW_DIVIDER_FACE_ID); + + ns_focus (f, &r, 1); if (face) [ns_lookup_indexed_color(face->foreground, f) set]; - ns_focus (f, &r, 1); NSRectFill(r); ns_unfocus (f); } -- 2.7.4 -- Alan Third ^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#22973: [PATCH] Enable dividers in NS (bug#22973) 2016-05-04 21:42 ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) Alan Third @ 2016-05-16 8:20 ` martin rudalics 2016-06-27 22:02 ` Alan Third 1 sibling, 0 replies; 7+ messages in thread From: martin rudalics @ 2016-05-16 8:20 UTC (permalink / raw) To: Alan Third, 22973, Keith David Bershatsky > src/nsfns.m: Add colour settings functions to ns_frame_park_handlers. > src/nsterm.m (ns_draw_window_divider): ns_focus has to go before the > attempt to set the colour. > src/nsterm.m (ns_draw_vertical_window_border): This had the same bug as > above, although I didn't see any errors. > --- > src/nsfns.m | 4 ++-- > src/nsterm.m | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/nsfns.m b/src/nsfns.m > index ea09908..9291f8e 100644 > --- a/src/nsfns.m > +++ b/src/nsfns.m > @@ -983,8 +983,8 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side > x_set_icon_name, > x_set_icon_type, > x_set_internal_border_width, /* generic OK */ > - 0, /* x_set_right_divider_width */ > - 0, /* x_set_bottom_divider_width */ > + x_set_right_divider_width, > + x_set_bottom_divider_width, > x_set_menu_bar_lines, > x_set_mouse_color, > x_explicitly_set_name, > diff --git a/src/nsterm.m b/src/nsterm.m > index 1d48c04..438054f 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -2951,10 +2951,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. > NSTRACE ("ns_draw_vertical_window_border"); > > face = FACE_FROM_ID (f, VERTICAL_BORDER_FACE_ID); > + > + ns_focus (f, &r, 1); > if (face) > [ns_lookup_indexed_color(face->foreground, f) set]; > > - ns_focus (f, &r, 1); > NSRectFill(r); > ns_unfocus (f); > } > @@ -2973,10 +2974,11 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. > NSTRACE ("ns_draw_window_divider"); > > face = FACE_FROM_ID (f, WINDOW_DIVIDER_FACE_ID); > + > + ns_focus (f, &r, 1); > if (face) > [ns_lookup_indexed_color(face->foreground, f) set]; > > - ns_focus (f, &r, 1); > NSRectFill(r); > ns_unfocus (f); > } > Keith, did you try this patch? martin ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#22973: [PATCH] Enable dividers in NS (bug#22973) 2016-05-04 21:42 ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) Alan Third 2016-05-16 8:20 ` martin rudalics @ 2016-06-27 22:02 ` Alan Third 1 sibling, 0 replies; 7+ messages in thread From: Alan Third @ 2016-06-27 22:02 UTC (permalink / raw) To: 22973-done Alan Third <alan@idiocy.org> writes: > src/nsfns.m: Add colour settings functions to ns_frame_park_handlers. > src/nsterm.m (ns_draw_window_divider): ns_focus has to go before the > attempt to set the colour. > src/nsterm.m (ns_draw_vertical_window_border): This had the same bug as > above, although I didn't see any errors. I've committed this to master, so I'll close the bug report. -- Alan Third ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#22973: OSX -- right-divider-width / bottom-divider-width -- not working. 2016-03-10 2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky ` (2 preceding siblings ...) 2016-05-04 21:42 ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) Alan Third @ 2017-11-19 2:55 ` Keith David Bershatsky 3 siblings, 0 replies; 7+ messages in thread From: Keith David Bershatsky @ 2017-11-19 2:55 UTC (permalink / raw) To: 22973 There is a related follow-up bug#29352 entitled "x-create-frame-with-faces disregards divider width params". ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-19 2:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-10 2:15 bug#22973: 25.1.50; OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky 2016-03-10 10:32 ` martin rudalics 2016-03-11 7:02 ` Keith David Bershatsky 2016-05-04 21:42 ` bug#22973: [PATCH] Enable dividers in NS (bug#22973) Alan Third 2016-05-16 8:20 ` martin rudalics 2016-06-27 22:02 ` Alan Third 2017-11-19 2:55 ` bug#22973: OSX -- right-divider-width / bottom-divider-width -- not working Keith David Bershatsky
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).