From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Duncan Burke Newsgroups: gmane.emacs.bugs Subject: bug#22743: 25.0.91: set-quit-char does not work if emacs lacks a controlling tty Date: Sat, 20 Feb 2016 22:37:56 +1100 Message-ID: <56C85014.4010002@gmail.com> References: <56C7FA4A.1030605@gmail.com> <83mvqvpvnm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1455968363 2659 80.91.229.3 (20 Feb 2016 11:39:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Feb 2016 11:39:23 +0000 (UTC) Cc: 22743@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 20 12:39:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aX5sV-0005I7-D1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Feb 2016 12:39:11 +0100 Original-Received: from localhost ([::1]:60247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX5sU-0004jY-Jy for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Feb 2016 06:39:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX5sP-0004iP-Fb for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2016 06:39:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aX5sM-0001AZ-7N for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2016 06:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX5sM-0001AP-4a for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2016 06:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aX5sL-0001b5-Qt for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2016 06:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Duncan Burke Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Feb 2016 11:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22743 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22743-submit@debbugs.gnu.org id=B22743.14559682896075 (code B ref 22743); Sat, 20 Feb 2016 11:39:01 +0000 Original-Received: (at 22743) by debbugs.gnu.org; 20 Feb 2016 11:38:09 +0000 Original-Received: from localhost ([127.0.0.1]:34627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX5rV-0001Zv-J5 for submit@debbugs.gnu.org; Sat, 20 Feb 2016 06:38:09 -0500 Original-Received: from mail-pf0-f176.google.com ([209.85.192.176]:35313) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX5rT-0001ZX-9X for 22743@debbugs.gnu.org; Sat, 20 Feb 2016 06:38:07 -0500 Original-Received: by mail-pf0-f176.google.com with SMTP id c10so67909153pfc.2 for <22743@debbugs.gnu.org>; Sat, 20 Feb 2016 03:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=yuBuGgMV1SoeYIhuyF+1AwN++hVACCSyuv1JfeJRVYk=; b=MbB4vOPD5F1OU9gj71Mqi4ncaS67LHlTBk2HUIseuNIhgetN0DUMbbUSiYe9/cxg5m A+mMvE55pVsCg0EjSw5w+Fvl66d+7KSMPQZ6oUKUv0L1Afz+wIOuthGd7gkTTsjhyrJn 6UBo2zcFsDWGlVT7PULw/csC56iQum/asDrJbfN3hWotlmfYOjjlK9auI2LC4BWJWxSb ViQbeElARL2WVfRe5V+lfW9GSvso6bgH9gjDGb4E97JXhsU8ORjuc7JJ4Qmb1W+vQcei AT7zg0Bi0NKT5M2VpMapeUP5TLou6lGyLHyagbX45V288vrUPmq9imjHxvXIzDG5bgJT 9pKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=yuBuGgMV1SoeYIhuyF+1AwN++hVACCSyuv1JfeJRVYk=; b=XvQmdSzo3ooEU+ymtJdBEQpK4cIj1uSPqCi9F6NbZv0kHrK2ccvemYVnVCMVOA6nX/ XBd/F9znFly1MtC/BX7ITWH9qv3QAuU2vdF13iNqa6PW9uitqXx7el/DDOgBbmJkX2x0 ck26WdnA4ZnGvmKepqIR4U5nlWlNk+nSbHus8mkkcgvcmb2LnAkRn3mjPvSw7Z9jeqoX cf1LDI3CtR8BoNqhu/7XNnPUeWzLQ0eukdm9uufGZqEwAENW82EDnEZucelP1gDX+qvQ WKXGiT2xhdNGQyTccm5oxxKhx3G7iIQYhT7PvvluAxMRy0V9Antlyq6wUSh0AIEbHDlF ixCA== X-Gm-Message-State: AG10YOQUy7LXyWxGhH1Qk/XZU2cRU+KtFCdSYzgeTlUH7quCRF6HsokHDp2zDcFzdfEegQ== X-Received: by 10.98.71.15 with SMTP id u15mr24897208pfa.161.1455968281275; Sat, 20 Feb 2016 03:38:01 -0800 (PST) Original-Received: from betelgeuse.dkb.id.au (c122-106-239-94.belrs3.nsw.optusnet.com.au. [122.106.239.94]) by smtp.gmail.com with ESMTPSA id 3sm23996859pfn.59.2016.02.20.03.37.59 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 20 Feb 2016 03:38:00 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 In-Reply-To: <83mvqvpvnm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113353 Archived-At: On 20/02/16 20:40, Eli Zaretskii wrote: > I don't think this patch will work reliably, because the parts of code > you changed are not the whole picture. C-g is supported implicitly > and explicitly in many more places. Grep the Lisp sources for C-g to > see that. I think it should be possible to rebind C-g. If it cannot be rebound, then that is an exceptional wart which significantly compromises emacs' configurability. It is extremely common for lisp code, whether in emacs or an external package, to make assumptions about default bindings. C-g is far from unique in this respect and while it would be nice if emacs had a way of globally changing these assumptions, this is an understood cost when one deviates significantly from emacs defaults. I accept that changing something fundamental like this requires scouring through lisp source and finding all the places this assumption is made. Anything in lisp can be patched or configured at runtime, so I am not particularly concerned about such issues. This patch is required because in this specific instance an assumption is made in the C code about the user's intended purpose of C-g, which has an effect in a graphical frame (demonstrated by my example), but that cannot be configured through lisp from a graphical frame. > That's documented in the doc string of set-quit-char, so this is by > design. On a TTY, C-g triggers a signal, and Emacs uses a system API > to change the character which does that. But on GUI frames, this is > not possible. If this is the intended behaviour of set-quit-char, then how is one supposed to set quit_char from a graphical frame? quit_char is demonstrably not TTY-specific, so it should be configurable and I cannot see a better place than set-quit-char. > FWIW, my NSHO is that we should deprecate set-quit-char and remove it > in a future Emacs version. It is no longer reasonable to have a > feature that only works on text terminals. Do you mean that quit_char should be removed entirely from the C code? Perhaps that would be best, I do not know enough to have an informed optinion. However, as long as quit_char exists I have a demonstrated need to be able to configure it at runtime.