unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, 22723@debbugs.gnu.org
Subject: bug#22723: 25.0.91; temp-buffer-resize-mode disables shrink-window
Date: Thu, 18 Feb 2016 11:51:45 +0100	[thread overview]
Message-ID: <56C5A241.6060804@gmx.at> (raw)
In-Reply-To: <83io1nunlh.fsf@gnu.org>

 > To reproduce:
 >
 >   emacs -Q
 >   M-x temp-buffer-resize-mode RET
 >   C-h f shrink-window RET
 >   M-x shrink-window RET
 >
 > Result: nothing happens.
 >
 > I realize that this is the result of temp-buffer-resize-mode taking
 > control on the dimensions of the *Help* window, but for me this is an
 > unintended consequence: I did want *Help* buffer resize itself when it
 > displays a new topic, but I certainly didn't expect to lose the
 > ability to resize my other windows.  Moreover, doing nothing silently,
 > without any error message, sounds sub-optimal UI to me.
 >
 > ("Fixing" this is easy: just switch to the window displaying *Help*
 > and invoke shrink-window or enlarge-window from there -- from that
 > moment on the resizing commands will work from other windows as well.)
 >
 > If the issue is not some unintended bug, then how about overriding
 > this behavior when the commands are invoked interactively?  Failing
 > even that, can we at least have a prefix argument to override that
 > explicitly?

Some time ago I changed the behavior of ‘enlarge-window’ and
‘shrink-window’ to not report an error when the window could not be
resized as requested but to resize the window as much as allowed
instead.  This was not a very good idea because according to the Emacs
manual these functions _are_ supposed to report an error in the
described case.  I hopefully fixed that now.

The ‘temp-buffer-resize-mode’ bug you report here is just an indirect
consequence of that earlier bug.  This issue should now have been fixed
as well.  Please have a look.

I also fixed a bug with ‘adjust-window-trailing-edge’ causing it to not
report an error when there was no resizable window below (or on the
right) of the edge to adjust.  Please check this as well.

Thanks, martin






  reply	other threads:[~2016-02-18 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 19:46 bug#22723: 25.0.91; temp-buffer-resize-mode disables shrink-window Eli Zaretskii
2016-02-18 10:51 ` martin rudalics [this message]
2016-02-19 11:58   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C5A241.6060804@gmx.at \
    --to=rudalics@gmx.at \
    --cc=22723@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).