unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Ari Roponen <ari.roponen@gmail.com>, 22332@debbugs.gnu.org
Subject: bug#22332: 25.0.50; woman moves point in a wrong buffer
Date: Thu, 04 Feb 2016 08:55:00 +0100	[thread overview]
Message-ID: <56B303D4.2060700@gmx.at> (raw)
In-Reply-To: <CAFyQvY1bS+_hZOm8w-56rBS92AKC=8L8STuDamNwBvy5nBdObw@mail.gmail.com>

 > Can you please try this updated patch? This time, I hope to have it tested
 > all the woman buffer switching activities.

I don't use woman so please someone else should try it.  But I think
that the change is too substantial to be applied to Emacs-25.  Please
try to come up with a minimal solution to fix the bug reported here.  We
can then apply your proposed behavior to master.

 > PS: The patch also resulted in many indentation changes. Looks like the
 > default lisp-indent-function is changed since the last major edits to
 > woman.el (because I did C-x h C-M-\ at the end committing my edits).

This is generally a bad idea.  Never do that.  It makes patches very
hard to read.  As a rule, always try to make patches as short as
possible so the reader gets the idea of the patch as fast as possible.
Formatting changes only obscure the idea transported by the patch.

 > Please
 > advise how to remove just the indentation changes.

Either edit the file manually via diff/ediff or use the -b or -w
switches when preparing the diff.

martin





  reply	other threads:[~2016-02-04  7:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 18:24 bug#22332: 25.0.50; woman moves point in a wrong buffer Ari Roponen
2016-01-09  9:25 ` martin rudalics
2016-01-09 16:36   ` Kaushal Modi
2016-01-09 16:54     ` martin rudalics
2016-01-09 17:19       ` Kaushal Modi
2016-01-09 17:29         ` Ari Roponen
2016-01-09 17:42           ` martin rudalics
2016-01-09 22:32             ` Kaushal Modi
2016-01-10 10:53               ` martin rudalics
2016-02-04  5:41                 ` Kaushal Modi
2016-02-04  7:55                   ` martin rudalics [this message]
2016-02-04  8:44                   ` Ari Roponen
2016-02-04 16:36                     ` Kaushal Modi
2016-02-18 16:20                       ` Kaushal Modi
2016-02-20  2:41                         ` John Wiegley
2016-02-20  6:17                           ` Lars Ingebrigtsen
2016-02-20  7:58                     ` Lars Ingebrigtsen
2016-01-09 17:42         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B303D4.2060700@gmx.at \
    --to=rudalics@gmx.at \
    --cc=22332@debbugs.gnu.org \
    --cc=ari.roponen@gmail.com \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).