From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22241: 25.0.50; etags Ruby parser problems Date: Thu, 4 Feb 2016 02:21:53 +0300 Message-ID: <56B28B91.4010706@yandex.ru> References: <86r3i9hnbt.fsf@yandex.ru> <83si1o45g1.fsf@gnu.org> <56A3C53D.1050408@yandex.ru> <83oacc3yx7.fsf@gnu.org> <56A3D47E.3030802@yandex.ru> <83mvrw3tuj.fsf@gnu.org> <56A3F3F9.8030404@yandex.ru> <8360yj3rtf.fsf@gnu.org> <83k2mrw952.fsf@gnu.org> <56AD33CF.6060105@yandex.ru> <83h9hu4dy8.fsf@gnu.org> <56AD9EF3.3080104@yandex.ru> <83powh1uwh.fsf@gnu.org> <56AF1A0E.7080802@yandex.ru> <8360y7yo3y.fsf@gnu.org> <56B10AA7.5000103@yandex.ru> <83bn7xyd43.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1454541812 32242 80.91.229.3 (3 Feb 2016 23:23:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Feb 2016 23:23:32 +0000 (UTC) Cc: 22241@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 00:23:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aR6lb-0007ak-BB for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 00:23:19 +0100 Original-Received: from localhost ([::1]:38271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR6la-000113-6o for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Feb 2016 18:23:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR6lM-0000jt-Ju for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 18:23:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR6lJ-0003fP-TL for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 18:23:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR6lJ-0003fJ-Q2 for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 18:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aR6lJ-0003Lw-ME for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2016 18:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2016 23:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22241-submit@debbugs.gnu.org id=B22241.145454172312819 (code B ref 22241); Wed, 03 Feb 2016 23:23:01 +0000 Original-Received: (at 22241) by debbugs.gnu.org; 3 Feb 2016 23:22:03 +0000 Original-Received: from localhost ([127.0.0.1]:58511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR6kN-0003Kg-0D for submit@debbugs.gnu.org; Wed, 03 Feb 2016 18:22:03 -0500 Original-Received: from mail-lf0-f53.google.com ([209.85.215.53]:33223) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aR6kL-0003KC-5H for 22241@debbugs.gnu.org; Wed, 03 Feb 2016 18:22:01 -0500 Original-Received: by mail-lf0-f53.google.com with SMTP id m1so25488954lfg.0 for <22241@debbugs.gnu.org>; Wed, 03 Feb 2016 15:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=ol77MPDwi92dfDWhayczJw0bb5+mrA/UuG2eDhaxxoE=; b=MWWZDwfbomENX8BiPH7s1vLoTmIBB7aTxzxezQgaP3X0b3/c+zWssagjFVMjLlbuqY 7bJCF46B/34smEDu3mg+VJNUcCzoFuNgcaI87Ov8wyMiJdrscc4FSmocMr8QXw5CCFGt FKx73ulA/eQL+/5Way5fArVPKmf5OpwwffWw3gXovvtXI/QxPjb+JSF9dwJTOJ5ddN98 Rbr8BhjyooboVI0TGkgmPpuL9eqWE4dPpmmsrod8PdbP+hH0bD7KlDNUV7OOmoyTa1LW DFwrXPlO/ug3s2ofwoJq3dkKlJ1BTPFSSZ7yYul9P3SJNQSzRgj9pqA/56Orngd8weSP BjCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=ol77MPDwi92dfDWhayczJw0bb5+mrA/UuG2eDhaxxoE=; b=DPvpQqs35+hghzTEr7JhxxvrvSJlqM+2sgXJqAKlcO5yWu3FXrJ5HA1KHq92HqV24u Z+3PMSJnIQ0gKf/4VhH69ot7nggWqRY/AdqyGbsATJKaZjJhvdxp+lefB+sCfWjjrtgg qDslNYaDXYVevu40j1X4VkZ9ibQehRmXb+2oTA8j2RDBQgbPmPdqjm3V9pjpnaAWN5dz jZu/1s3OWOWCwp6QPu9AZWmvJDn35h1AHaQFTBfc4oEVUHVLLFT0r2cVabkfxkrRN36A XyEsDsaqOu4kLtb4uoLvT19KvWjtE6pkxxbh+UCRwHO8cJzwxC5gHx02DohvTPUOucoK jkRw== X-Gm-Message-State: AG10YOQ+Mmb4efZR7K51NvOOuIMH4PjHJEGOGzd2lT0VT+FN2ZvolxLlsxOpebbVBfhoqA== X-Received: by 10.25.210.78 with SMTP id j75mr2097519lfg.101.1454541715246; Wed, 03 Feb 2016 15:21:55 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id wj2sm1148796lbb.5.2016.02.03.15.21.53 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 03 Feb 2016 15:21:54 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <83bn7xyd43.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112358 Archived-At: On 02/03/2016 07:26 PM, Eli Zaretskii wrote: > I implemented that now. Thanks! One nitpick: attr_WHATEVER :foo, bar will generate the methods for 'foo', and whatever the value of bar is. But bar is not very likely to have the value :bar, so we should only generate the tags for 'foo'. IOW, skip the arguments that are not Ruby Symbols (don't start with a colon). The current implementation treats them the same. The test example looks a bit odd as well, but I'll comment on that in a separate email.