From: Ken Brown <kbrown@cornell.edu>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, 22522@debbugs.gnu.org
Subject: bug#22522: Commit b88e9cded7ae3756e3a2ec4a23e8df352a0239f9 breaks emacs dumping for me
Date: Wed, 3 Feb 2016 08:35:33 -0500 [thread overview]
Message-ID: <56B20225.8040104@cornell.edu> (raw)
In-Reply-To: <56B1BD2E.8050606@cs.ucla.edu>
On 2/3/2016 3:41 AM, Paul Eggert wrote:
> Ken Brown wrote:
>>> I installed the attached patch into the Emacs master, to try to work
>>> around this problem by putting GCC into C11 mode. Please give it a try.
>>
>> No, that didn't fix it.
>
> Can you investigate why not? The patch should cause 'configure' to put
> -stdc=gnu11 into CFLAGS. If you look at config.log, it should have
> something like this:
>
> configure:5924: checking for gcc option to enable C11 features
> ...
> configure:6146: result: -std=gnu11
>
> If this isn't the result, what is the result and why?
Yes, that's the result. Compiling with that option caused __STDC_VERSION__ to be defined as 201112L. But it didn't affect __ISO_C_VISIBLE, which is what guards the declaration of aligned_alloc.
> I'd rather not go that route, as __ISO_C_VISIBLE is supposed to be private. I installed the attached patch instead; please give it a try.
We're almost there. After your change, I get the following in config.h:
/* Define to 1 if you have the declaration of `aligned_alloc', and to 0 if you
don't. */
#define HAVE_DECL_ALIGNED_ALLOC 0
So we need the following additional change:
diff --git a/src/lisp.h b/src/lisp.h
index a99002b..c8363be 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -3775,7 +3775,7 @@ INLINE void (check_cons_list) (void) { lisp_h_check_cons_list (); }
#if !defined DOUG_LEA_MALLOC && !defined HYBRID_MALLOC && !defined SYSTEM_MALLOC
extern size_t __malloc_extra_blocks;
#endif
-#ifndef HAVE_DECL_ALIGNED_ALLOC
+#if !HAVE_DECL_ALIGNED_ALLOC
extern void *aligned_alloc (size_t, size_t) ATTRIBUTE_MALLOC_SIZE ((2));
#endif
extern void malloc_enable_thread (void);
Thanks.
Ken
next prev parent reply other threads:[~2016-02-03 13:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:37 bug#22522: Commit b88e9cded7ae3756e3a2ec4a23e8df352a0239f9 breaks emacs dumping for me Elric Milon
2016-02-01 22:27 ` Andy Moreton
2016-02-02 2:59 ` Ken Brown
2016-02-02 14:20 ` Wolfgang Jenkner
2016-02-02 14:36 ` Wolfgang Jenkner
2016-02-02 20:25 ` Ken Brown
2016-02-02 22:02 ` Andy Moreton
2016-02-02 22:32 ` Ken Brown
2016-02-02 22:08 ` Ken Brown
2016-02-02 22:54 ` Paul Eggert
2016-02-03 0:09 ` Ken Brown
2016-02-03 3:18 ` Ken Brown
2016-02-03 8:41 ` Paul Eggert
2016-02-03 13:35 ` Ken Brown [this message]
2016-02-03 14:01 ` Andy Moreton
2016-02-03 18:30 ` Ken Brown
2016-02-02 17:34 ` Paul Eggert
2016-02-02 18:28 ` Ken Brown
2016-02-02 17:26 ` Paul Eggert
2016-02-02 21:14 ` Elric Milon
2016-02-02 23:02 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B20225.8040104@cornell.edu \
--to=kbrown@cornell.edu \
--cc=22522@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).