From: Hong Xu <hong@topbug.net>
To: Phillip Lord <phillip.lord@russet.org.uk>
Cc: 21990@debbugs.gnu.org
Subject: bug#21990: htmlfontify fails to generate highly highlighted regions
Date: Mon, 18 Jan 2016 00:22:49 -0800 [thread overview]
Message-ID: <569CA0D9.5070006@topbug.net> (raw)
In-Reply-To: <87si1vkfu9.fsf@russet.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 827 bytes --]
On 01/17/2016 02:21 PM, Phillip Lord wrote:
> Hong Xu <hong@topbug.net> writes:
>
>> This issue is also possibly caused by bug #18128, which
>> diff-auto-refine-mode does not put the highlight into the font-lock.
>
>
> I don't think it's related to font-lock, as htmlfontify checks both
> 'face and 'font-lock-face. I think htmlfontify was not dealing correctly
> with faces when they overlap. I've pushed a fix to
> fix/htmlfontify-21990.
>
> http://lists.gnu.org/archive/html/emacs-diffs/2016-01/msg00277.html
>
> Can you test and confirm? If so, I'll finish the patch and merge.
>
Hi Phillip,
I've tested it---yes now the highlighted regions display differently,
but the highlighting actually is just the same as the background...
I've attached the generated html file, so you can view it.
[-- Attachment #1.2: a.patch.html --]
[-- Type: text/html, Size: 11584 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-18 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 4:43 bug#21990: htmlfontify fails to generate highly highlighted regions Hong Xu
2016-01-15 23:48 ` Phillip Lord
2016-01-16 0:24 ` Hong Xu
2016-01-17 6:23 ` Hong Xu
2016-01-17 22:21 ` Phillip Lord
2016-01-18 8:22 ` Hong Xu [this message]
2016-01-18 17:31 ` Phillip Lord
2016-01-19 0:04 ` Hong Xu
2016-01-19 10:03 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569CA0D9.5070006@topbug.net \
--to=hong@topbug.net \
--cc=21990@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).