From: Hong Xu <hong@topbug.net>
To: Phillip Lord <phillip.lord@russet.org.uk>
Cc: 21990@debbugs.gnu.org
Subject: bug#21990: htmlfontify fails to generate highly highlighted regions
Date: Fri, 15 Jan 2016 16:24:24 -0800 [thread overview]
Message-ID: <56998DB8.50400@topbug.net> (raw)
In-Reply-To: <87io2uwgj5.fsf@russet.org.uk>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 01/15/2016 03:48 PM, Phillip Lord wrote:
> Hong Xu <hong@topbug.net> writes:
>
>> I'm able to reproduce this issue on both the latest snapshot and
>> 24.4. My OS is GNU/Linux.
>
>> 2. Press Meta-n multiple times to make sure all changed texts
>> are highlighted. It should look like the following:
>>
>> https://i.imgur.com/xVdQgxk.png
>>
>> 3. M-x htmlfontify-buffer, and save the output html file.
>>
>> 4. Look at it in a browser. The deeply highlighted region (such
>> as the "xxxxxxxxxx") is not highlighted at all.
>>
>
> To clarify, you are concerned that, as in your image, "xxxximport"
> is highlighted a different colour from "sys", but this is not
> reflected in htmlfontify-buffer?
>
Correct.
> In my hands that line is coming in a single colour. Looking at
> buffer-substring, I get....
>
> #("+xxxxxxxxxxxximport sys" 0 1 (fontified t face
> diff-indicator-added) 1 23 (fontified t face diff-added))
>
>
> i.e. there is only a single font, after the "+". The equivalent
> HTML looks like this....
>
> </span><span class="diff-indicator-added">+</span><span
> class="diff-added">xxxxxxxxxxxximport sys </span>
>
> which seems correct to me. I've tried 24.4 and current emacs-25
> branch.
>
> Am I looking at the right thing?
>
Thanks for your comments. After opening the patch file, you have move
the cursor to the top of the buffer and run diff-hunk-next (bound to
M-n by default) to show the highlights in Emacs. If you still cannot
see the highlight, you may want to change the theme to the default one
and remove custom color tweaks (I had once used a theme which does not
highlight anything).
Best,
Hong
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJWmY24AAoJECZsfTOCL4R4zpMQAKvk7P1SXlnOFnX/R18hPPGJ
qjfopBPVvgqVKUQtCMBkvd4WP/EaEXBItDbTWJX8i2CcVRtFqPW5RrbnJ/6kLvnU
h0jTDO6GMMIa6HY07mjBgMx7ee0e1O9MVmyajumjVWiWbm1gRleT4FvZsKYRACbg
gI5RHqDtL16RBoX1tscwEhOP3LNsAIa0TT8GrJgeRUA/vGLLCmSDHYrzUW10uCjE
fSkn/D9cP+w5RVH8NcCDIqimWKtAIorUM2aSNBztWeK2/z0EWx6N2O51dGaQWohY
GVcn4xEq57LF9l/j/fSzGGfYe+D3ERYapCgG9ZzTHMMIz5+dJwXXlg1+g1DBewNx
AsNPyc+w2GJrDmZjw1i/eE6tdLia5Lt35zndHplyOIvNB02ZqLxTFE+AMwQZVFZD
pojq/cMSVDVmyDtKEdn6FYI5P9Kum1qwyXnpgtQWwwAAHxrW/tk9k8uSObPph7IF
fMxoj1JcMjVjnUTVNPuQTXQTFDkhY4yPfzWG2fd7G3nP3r+Kj62vp4ga5eh+XCE7
nv/CKVdztvSO+yU4dNdSn7iFhbWGD+ywCT+Bxku7AVT+HcJ633PpfzvmMhLPutOb
79Y/n+Zf+kHQzgQWw8nFADAjifU+f0DW7tVmOkTFIgXbmsKb7VcWKGmPNRF4vQn6
BKv1Nau6/lje5VucnhZe
=+MiP
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2016-01-16 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 4:43 bug#21990: htmlfontify fails to generate highly highlighted regions Hong Xu
2016-01-15 23:48 ` Phillip Lord
2016-01-16 0:24 ` Hong Xu [this message]
2016-01-17 6:23 ` Hong Xu
2016-01-17 22:21 ` Phillip Lord
2016-01-18 8:22 ` Hong Xu
2016-01-18 17:31 ` Phillip Lord
2016-01-19 0:04 ` Hong Xu
2016-01-19 10:03 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56998DB8.50400@topbug.net \
--to=hong@topbug.net \
--cc=21990@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).