From: martin rudalics <rudalics@gmx.at>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Ari Roponen <ari.roponen@gmail.com>, 22332@debbugs.gnu.org
Subject: bug#22332: 25.0.50; woman moves point in a wrong buffer
Date: Sat, 09 Jan 2016 18:42:45 +0100 [thread overview]
Message-ID: <56914695.2090903@gmx.at> (raw)
In-Reply-To: <CAFyQvY2Jwqxc9CE0DkoMb7LRA5jUGZ3kcKWQd8OmjNicjYc9Qg@mail.gmail.com>
> I first tried doing that. But that still did not solve this bug (#22332).
>
> Not selecting the WoMan buffer explicitly creates this problem starting
> from these lines in the woman-find-file function:
>
> (Man-build-section-alist) ; starting from here
> (Man-build-references-alist)
> (goto-char (point-min)))
>
> That's because Man-build-section-alist does (goto-char (point-min)) in
> which ever the selected buffer is.
> display-buffer does not select the buffer.. so that explicit
> switch-to-buffer call had to be put there.
Then we probably have to explicitly select the window as in
(if buffer
(let ((window (display-buffer buffer)))
(when (window-live-p window)
(select-window window)
buffer))
> In my opinion, if we do not want to do switch-to-buffer calls in
> WoMan-find-buffer, a more elegant way would be to wrap the below lines in
> woman-find-file
>
> (Man-build-section-alist) ; starting from here
> (Man-build-references-alist)
> (goto-char (point-min)))
>
> with a (with-current-buffer WOMAN-BUFFER ..) form.
We have to fix ‘WoMan-find-buffer’ because it's used elsewhere too.
martin
prev parent reply other threads:[~2016-01-09 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 18:24 bug#22332: 25.0.50; woman moves point in a wrong buffer Ari Roponen
2016-01-09 9:25 ` martin rudalics
2016-01-09 16:36 ` Kaushal Modi
2016-01-09 16:54 ` martin rudalics
2016-01-09 17:19 ` Kaushal Modi
2016-01-09 17:29 ` Ari Roponen
2016-01-09 17:42 ` martin rudalics
2016-01-09 22:32 ` Kaushal Modi
2016-01-10 10:53 ` martin rudalics
2016-02-04 5:41 ` Kaushal Modi
2016-02-04 7:55 ` martin rudalics
2016-02-04 8:44 ` Ari Roponen
2016-02-04 16:36 ` Kaushal Modi
2016-02-18 16:20 ` Kaushal Modi
2016-02-20 2:41 ` John Wiegley
2016-02-20 6:17 ` Lars Ingebrigtsen
2016-02-20 7:58 ` Lars Ingebrigtsen
2016-01-09 17:42 ` martin rudalics [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56914695.2090903@gmx.at \
--to=rudalics@gmx.at \
--cc=22332@debbugs.gnu.org \
--cc=ari.roponen@gmail.com \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).