From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: joostkremers@fastmail.fm, 22009@debbugs.gnu.org
Subject: bug#22009: PATCH: Use `window-total-width' in `window-splittable-p'
Date: Sat, 28 Nov 2015 16:49:04 +0100 [thread overview]
Message-ID: <5659CCF0.9020900@gmx.at> (raw)
In-Reply-To: <83io4mp4a3.fsf@gnu.org>
> Yes, thanks. But that still doesn't suggest how to fix
> window-splittable-p, unless we care _only_ for Joost's use case. And
> I don't think we can declare that only such use cases matter, as
> window-splittable-p is too general-purpose for that.
Indeed. Joost's fix also takes care of fringes, scroll bars and
dividers.
> We agree that the code should be fixed. We just disagree about (or
> don't know) _how_ to fix it.
If we do not fix the code on the release branch I have to fix a couple
of doc-strings there telling that for historical reasons we do compare
apples and oranges. Affected are ‘window-splittable-p’,
‘split-window-sensibly’ and ‘split-width-threshold’. For the latter two
I'd have to amend the Elisp manual as well.
martin
next prev parent reply other threads:[~2015-11-28 15:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:07 bug#22009: PATCH: Use `window-total-width' in `window-splittable-p' Joost Kremers
2015-11-25 17:48 ` martin rudalics
2015-11-25 18:04 ` Eli Zaretskii
2015-11-25 18:14 ` martin rudalics
2015-11-25 19:15 ` Eli Zaretskii
2015-11-26 8:23 ` martin rudalics
2015-11-26 15:46 ` Eli Zaretskii
2015-11-26 16:58 ` martin rudalics
2015-11-26 17:25 ` Eli Zaretskii
2015-11-26 18:06 ` martin rudalics
2015-11-26 18:36 ` Eli Zaretskii
2015-11-27 8:27 ` martin rudalics
2015-11-27 20:51 ` Eli Zaretskii
2015-11-28 10:26 ` martin rudalics
2015-11-28 14:49 ` Eli Zaretskii
2015-11-28 15:49 ` martin rudalics [this message]
2015-12-01 12:47 ` Joost Kremers
2015-11-27 1:16 ` Joost Kremers
2015-11-27 8:28 ` martin rudalics
2015-12-01 14:11 ` Joost Kremers
2015-11-27 20:56 ` Eli Zaretskii
2015-12-01 12:59 ` Joost Kremers
2015-12-01 15:44 ` Eli Zaretskii
2015-12-01 17:31 ` Joost Kremers
2020-09-07 16:48 ` Lars Ingebrigtsen
2020-09-08 8:50 ` Joost Kremers
2020-09-08 10:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5659CCF0.9020900@gmx.at \
--to=rudalics@gmx.at \
--cc=22009@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joostkremers@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).