From: Dmitry Gutov <dgutov@yandex.ru>
To: Glenn Hutchings <zondo42@gmail.com>, 22032@debbugs.gnu.org
Subject: bug#22032: 24.3; VC doesn't handle hg hidden revisions
Date: Sat, 28 Nov 2015 04:44:52 +0200 [thread overview]
Message-ID: <56591524.3010806@yandex.ru> (raw)
In-Reply-To: <56584054.5080100@gmail.com>
On 11/27/2015 01:36 PM, Glenn Hutchings wrote:
> In the *vc-change-log* buffer, pressing '=' should display the diff
> twixt the current and previous revisions. This fails when (1) the HG
> backend is being used, and (2) the mercurial change history contains
> hidden revisions.
Could you link to some relevant documentation? The closest I've been
able to find mentions "secret changesets".
> Hidden revisions are a fairly recent mercurial feature. By default,
> they're not displayed; hg needs a "--hidden" argument to consider them.
Is there a reason why we wouldn't want to use that argument and just
always display them?
> The lisp function to find the previous rev number
> (vc-hg-previous-revision) just decrements the current rev by 1. In the
> example above, doing a diff on changeset 2 would try to use the hidden
> revision 1 and then mercurial gives an error to the effect of "rev 1 is
> hidden" (sorry, don't have the exact text to hand).
Would calling 'hg diff --hidden' help?
> Possible fix:
> actually move to the previous rev in the buffer, and get the rev number
> from that.
Unfortunately, vc-hg-previous-revision is not always called from the
vc-log buffer. E.g. it's also called from the vc-annotate buffer. So
we'd need a more reliable way to detect the previous revision. Such as
an Hg command line invocation, probably.
> To repeat it: get a mercurial repo with hidden changeset (as above) and
> try the command with latest mercurial.
A publicly available example would be nice.
next prev parent reply other threads:[~2015-11-28 2:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:36 bug#22032: 24.3; VC doesn't handle hg hidden revisions Glenn Hutchings
2015-11-28 2:44 ` Dmitry Gutov [this message]
[not found] ` <5659C34E.4070300@gmail.com>
2015-11-28 18:09 ` Dmitry Gutov
2015-12-13 10:54 ` Glenn Hutchings
2015-12-14 3:30 ` Dmitry Gutov
[not found] ` <CA+hLqocwRQqXHZj1i8YOQiJS2c1nL7ahVP7OrdS=oizy=ct1XQ@mail.gmail.com>
2015-12-15 14:08 ` Dmitry Gutov
2015-12-15 23:53 ` Andy Moreton
2015-12-16 0:03 ` Dmitry Gutov
2015-12-16 3:02 ` Andy Moreton
2015-12-18 5:02 ` Dmitry Gutov
2015-12-22 20:17 ` Glenn Hutchings
2015-12-22 21:33 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56591524.3010806@yandex.ru \
--to=dgutov@yandex.ru \
--cc=22032@debbugs.gnu.org \
--cc=zondo42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).