unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Anders Lindgren <andlind@gmail.com>, 21975@debbugs.gnu.org
Subject: bug#21975: 25.0.50; `window-size-change-functions' no longer called when manually resizing a frame
Date: Sun, 22 Nov 2015 11:45:02 +0100	[thread overview]
Message-ID: <56519CAE.5010402@gmx.at> (raw)
In-Reply-To: <CABr8eba5SbMwhZLdvhyqygJrzfGHbNmTOjy0FdXiy1nOrUDZnQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

 > The hook `window-size-change-functions' is not executed when a frame is
 > manually resized.
 >
 > In Emacs 23 it was called, but in Emacs 24 and Emacs 25 it isn't.
 >
 > For example, this break the package Follow mode, its windows are not
 > aligned after the frame has been resized.

If no one objects I intend to install the attached patch on Emacs-25.
Anders please confirm that it fixes the problem.

Thanks, martin

[-- Attachment #2: FRAME_WINDOW_SIZES_CHANGED.diff --]
[-- Type: text/plain, Size: 854 bytes --]

diff --git a/src/frame.c b/src/frame.c
index c388986..5bafc6e 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -518,6 +518,7 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit,
   if (new_windows_width != old_windows_width)
     {
       resize_frame_windows (f, new_windows_width, 1, 1);
+      FRAME_WINDOW_SIZES_CHANGED (f) = true;

       /* MSDOS frames cannot PRETEND, as they change frame size by
 	 manipulating video hardware.  */
@@ -543,6 +544,7 @@ adjust_frame_size (struct frame *f, int new_width, int new_height, int inhibit,
       || WINDOW_TOP_PIXEL_EDGE (r) != FRAME_TOP_MARGIN_HEIGHT (f))
     {
       resize_frame_windows (f, new_windows_height, 0, 1);
+      FRAME_WINDOW_SIZES_CHANGED (f) = true;

       /* MSDOS frames cannot PRETEND, as they change frame size by
 	 manipulating video hardware.  */


  reply	other threads:[~2015-11-22 10:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 20:30 bug#21975: 25.0.50; `window-size-change-functions' no longer called when manually resizing a frame Anders Lindgren
2015-11-22 10:45 ` martin rudalics [this message]
2015-11-22 14:46   ` Anders Lindgren
2015-11-23  7:56     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56519CAE.5010402@gmx.at \
    --to=rudalics@gmx.at \
    --cc=21975@debbugs.gnu.org \
    --cc=andlind@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).