* bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
[not found] ` <m2bnarp8je.fsf@newartisans.com>
@ 2015-11-21 22:23 ` Paul Eggert
2015-11-22 2:23 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggert @ 2015-11-21 22:23 UTC (permalink / raw)
To: Ken Brown, 21688; +Cc: John Wiegley, Stefan Monnier
John Wiegley wrote:
>>>>>> Ken Brown<kbrown@cornell.edu> writes:
>>> >>branch: emacs-25
>>> >>commit 8ff888a07d0500f1274723086469191aade0a33e
>> >The message-mode-propertize test fails after this commit.
> Let's make sure all tests are run prior to any commits on the emacs-25 branch.
I briefly looked into getting that test working, but couldn't figure it out
quickly, so I have reverted the fix for the regex reentrancy abort, in emacs-25
commit 8e84823f3f06714d0668060d62456cf7e3100e6c. This means Bug#21688 is no
longer fixed, i.e., Emacs can dump core when aligning Perl code. I'll reopen
Bug#21688.
Perhaps Stefan or someone else will be able to knock a few cycles free to fix
this. I'm afraid I've been spending most of my time elsewhere in Emacs recently,
what with the new module code and all.
^ permalink raw reply [flat|nested] 2+ messages in thread* bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
2015-11-21 22:23 ` bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Paul Eggert
@ 2015-11-22 2:23 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2015-11-22 2:23 UTC (permalink / raw)
To: Paul Eggert; +Cc: John Wiegley, 21688
> Perhaps Stefan or someone else will be able to knock a few cycles free to
> fix this. I'm afraid I've been spending most of my time elsewhere in Emacs
> recently, what with the new module code and all.
My crystal ball tells me that maybe it's just the following hunk which
is to blame:
diff --git a/src/syntax.c b/src/syntax.c
index 5b0ec6d..f939a76 100644
--- a/src/syntax.c
+++ b/src/syntax.c
@@ -514,7 +514,6 @@ update_syntax_table_forward (ptrdiff_t charpos, bool init,
{
eassert (NILP (object));
eassert (charpos >= gl_state.e_property);
- parse_sexp_propertize (charpos);
}
else
{
I think this hunk is just a mistake that was introduced during the
"back&forth" that took place when you added and then removed the "bool
propertize" argument.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-22 2:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151116211021.12530.98760@vcs.savannah.gnu.org>
[not found] ` <E1ZyR2b-0003Gm-BV@vcs.savannah.gnu.org>
[not found] ` <564CA7FE.7030709@cornell.edu>
[not found] ` <m2bnarp8je.fsf@newartisans.com>
2015-11-21 22:23 ` bug#21688: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort Paul Eggert
2015-11-22 2:23 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).