From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19576: write-file writes the wrong buffer Date: Thu, 19 Nov 2015 09:12:50 +0100 Message-ID: <564D8482.20804@gmx.at> References: <564A3292.2050807@gmx.at> <564AE692.2040303@gmx.at> <83vb8z9q6l.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1447920808 31386 80.91.229.3 (19 Nov 2015 08:13:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 08:13:28 +0000 (UTC) Cc: 19576@debbugs.gnu.org, andlind@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 19 09:13:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzKLE-0000ej-D8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Nov 2015 09:13:16 +0100 Original-Received: from localhost ([::1]:40110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKL8-0007tb-Q9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Nov 2015 03:13:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKL5-0007tU-2W for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2015 03:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzKL1-0002zJ-7A for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2015 03:13:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzKL1-0002zF-3H for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2015 03:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZzKL0-0004um-Ie for bug-gnu-emacs@gnu.org; Thu, 19 Nov 2015 03:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Nov 2015 08:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19576-submit@debbugs.gnu.org id=B19576.144792078118885 (code B ref 19576); Thu, 19 Nov 2015 08:13:02 +0000 Original-Received: (at 19576) by debbugs.gnu.org; 19 Nov 2015 08:13:01 +0000 Original-Received: from localhost ([127.0.0.1]:44174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzKKy-0004uX-Kf for submit@debbugs.gnu.org; Thu, 19 Nov 2015 03:13:01 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:56393) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZzKKw-0004uM-B9 for 19576@debbugs.gnu.org; Thu, 19 Nov 2015 03:12:58 -0500 Original-Received: from [192.168.1.100] ([213.162.68.32]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MOwbP-1a2uyd2bN1-006LJo; Thu, 19 Nov 2015 09:12:56 +0100 In-Reply-To: <83vb8z9q6l.fsf@gnu.org> X-Provags-ID: V03:K0:BBde84AAjt7GkRmiYqnXGoKkBYF0KxlsQiTVb6mUSMLJNxgvz0k R2kOnWSr23PDaPC3lgyzzDkw+sfR3s/DkELittPEbVLujLrPUjappGLPFqK5eI8rra++l5S KvYh9ZbSouUJNO0XY3zgv7LbMoKfekFzgT96rszNajrS8jgc54B/HUT9y2/Wt3s6tN4q6zJ F/0aelgVE0JCs92/HPykw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ozi8RhAXYIQ=:80ReKC2uaHviR/Aozwn0Vo H+cd1ag1hAe7zBIR9qGfMGgLyEcF8bwr0niF54/zKIJhIwVdp1ndnupxplZgElPoPabHS+tmr qnXOgz3AVngi8JMEVZC9mNITfHxnc1pYt6RJ+Qzpy2FfBgTYcdcirHE2BXC3zQeYA63nGuapm tSnKcxGHb+oYYHuVMSrgvfM155bnSeioq1zk3Q4jjJoggCzfKhuTaK2SaMF/qLDL9aXODxb5j 03J0HYV1OS/kYOCSKG+r4f03hmwpRYO44p5bcBB99PH1EZfSp5KrLn29wATqjcn9NG5QFR0ec jrOP+4OCKJLkioiXzodZLMK3w4mdRuD7P39RRh0Cf290Ioo209+IcflkLLu9ijaXmsL7rneKT p5oXbOzKVJ3lZ2oAk+fY1Y+x1gIsPIwaws4R880c3STDvZmLgzVgWMMKtiHQwECxzgcP2V0gV XS5sa/T8MSEj+LpRdWfgh8NUa5TCAwsp3uUxMISFf2Nzkz0+8/WRjcbb65SKTEBMCjYC5tU9t KgFH/mDwwIRaZJXmRCV/m0KB/9eG6pAB3jgclHRHtM1TJIzP7FxBYLSwDuHwFE+ruenpMdKZ+ uJ9bSZUpCt4jBGcoJXsX5yV0MkGrc6uzNDJKLNmeiI5VQnj9sLWh/B3jFg6sSUyTvRy6FnvOZ Kb8EG6RtP7fd6pvmwT+z7uXrCqbZrHXcrISoLE/AHz+PMg1xeWmsJUk7YvY0rO46xklttjbHK H06n0o8UsQhuTCZeDFyXz+LoVMAALYaezzmBulD4D2CGCZX8LId9J9KTXf2/bJLTwd+xraRm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108903 Archived-At: > Thanks for working on this, Martin. However, I don't think we should > install this change. We call Lisp hooks from many places, including > maybe a dozen in the display engine. It makes little sense to make > only one of them resistant to this kind of problems. OTOH, if we do > this everywhere, I feel that we will unduly punish 99.999% percent of > legitimate users of these hooks just because one of them had a bug. 100% agreed. But run_window_configuration_change_hook goes a long way saving and restoring current buffer and selected window around each call to a function on =E2=80=98window-configuration-change-hook=E2=80=99. People who put their functions on =E2=80=98window-size-change-functions=E2= =80=99 and =E2=80=98window-configuration-change-hook=E2=80=99 usually don't care abo= ut the precise reason why these function get called. They simply want to cover all cases where a new window appears or a specific window changes size. Do we really expect them to add a =E2=80=98save-window-excursion=E2=80=99 in= one case and avoid it in the other because it would mean unnecessary extra work? > I think this is a clear bug in follow.el, and should be fixed there, > and nowhere else. Perhaps we should also have some prominent warnings= > in the documentation about this gotcha, so that the probability this > will happen again becomes lower. We've broken the taboo in =E2=80=98window-configuration-change-hook=E2=80= =99. Anything we add now will only increase confusion. martin