From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Steve Purcell Newsgroups: gmane.emacs.bugs Subject: bug#22596: Acknowledgement (25.1.50; Broken prompt-regexp for sql-postgres) Date: Tue, 9 Feb 2016 21:18:12 +1300 Message-ID: <564B7BA1-2B2D-4567-96FE-4053992A6EE1@sanityinc.com> References: <88B06A20-FEE9-454A-A4C1-A5582B5EFA45@sanityinc.com> <071F8E2E-1C7B-40FD-880F-368B64D31FA6@sanityinc.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_4CDB60E9-5AE1-4CA5-99E6-B4E06E5095EE" X-Trace: ger.gmane.org 1455005962 24309 80.91.229.3 (9 Feb 2016 08:19:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Feb 2016 08:19:22 +0000 (UTC) To: 22596@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 09 09:19:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aT3Vw-0004bx-Eo for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Feb 2016 09:19:12 +0100 Original-Received: from localhost ([::1]:53053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT3Vv-0005Pw-Im for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Feb 2016 03:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT3Vs-0005Pm-4E for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 03:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT3Vm-0004D2-JX for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 03:19:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT3Vm-0004Cx-FG for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 03:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aT3Vm-0003EX-BW for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 03:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Steve Purcell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 08:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22596-submit@debbugs.gnu.org id=B22596.145500590712380 (code B ref 22596); Tue, 09 Feb 2016 08:19:02 +0000 Original-Received: (at 22596) by debbugs.gnu.org; 9 Feb 2016 08:18:27 +0000 Original-Received: from localhost ([127.0.0.1]:60915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT3VC-0003Dc-Sd for submit@debbugs.gnu.org; Tue, 09 Feb 2016 03:18:27 -0500 Original-Received: from purcellpeople.com ([85.214.32.38]:47284 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT3VB-0003DM-3n for 22596@debbugs.gnu.org; Tue, 09 Feb 2016 03:18:25 -0500 Original-Received: from [192.168.0.10] (unknown [210.54.38.34]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id F330927AC0B6 for <22596@debbugs.gnu.org>; Tue, 9 Feb 2016 09:18:17 +0100 (CET) In-Reply-To: <071F8E2E-1C7B-40FD-880F-368B64D31FA6@sanityinc.com> X-Mailer: Apple Mail (2.3112) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112788 Archived-At: --Apple-Mail=_4CDB60E9-5AE1-4CA5-99E6-B4E06E5095EE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Updated patch is attached, following discussion on emacs-devel. (I have = a CA on file, btw.) --Apple-Mail=_4CDB60E9-5AE1-4CA5-99E6-B4E06E5095EE Content-Disposition: attachment; filename=0001-Safer-prompt-regexp-for-postgres-vertica-in-sql-inte.patch Content-Type: application/octet-stream; name="0001-Safer-prompt-regexp-for-postgres-vertica-in-sql-inte.patch" Content-Transfer-Encoding: quoted-printable =46rom=20fcbbb4598f7e7c5d9d9a460ef3af668c84f907c6=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Steve=20Purcell=20=0A= Date:=20Mon,=208=20Feb=202016=2020:47:43=20+1300=0ASubject:=20[PATCH]=20= Safer=20prompt-regexp=20for=20postgres/vertica=20in=0A=20= sql-interactive-mode=0AMIME-Version:=201.0=0AContent-Type:=20text/plain;=20= charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0AFixes=20issue=20= 22596,=20whereby=20"_"=20is=20now=20not=20considered=20a=20word=20= constituent=0Acharacter=20in=20sql-interactive-mode,=20so=20prompts=20= like=20"foo_dev#=20"=20are=20not=0Acorrectly=20detected.=20Rather=20than=20= piggy-back=20on=20the=20symbol=20table,=20we=0Aexplicitly=20match=20= against=20alphanumeric=20chars=20or=20"_".=0A=0AIn=20the=20general=20= case,=20almost=20any=20characters=20are=20valid=20in=20a=20PostgreSQL=0A= database=20name,=20so=20we=20must=20choose=20between=20matching=20= =E2=80=9Creasonable=E2=80=9D=20database=0Anames=20with=20a=20tight=20= regexp,=20or=20matching=20all=20allowable=20names=20with=20a=0A= permissive=20regexp=20which=20would=20likely=20match=20all=20sorts=20of=20= other=20buffer=0Atext.=20This=20commit=20follows=20the=20former=20= approach.=0A---=0A=20lisp/progmodes/sql.el=20|=208=20++++----=0A=201=20= file=20changed,=204=20insertions(+),=204=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/progmodes/sql.el=20b/lisp/progmodes/sql.el=0Aindex=20= fd59f46..be7c4dd=20100644=0A---=20a/lisp/progmodes/sql.el=0A+++=20= b/lisp/progmodes/sql.el=0A@@=20-462,9=20+462,9=20@@=20sql-product-alist=0A= =20=20=20=20=20=20:list-all=20("\\d+"=20.=20"\\dS+")=0A=20=20=20=20=20=20= :list-table=20("\\d+=20%s"=20.=20"\\dS+=20%s")=0A=20=20=20=20=20=20= :completion-object=20sql-postgres-completion-object=0A-=20=20=20=20=20= :prompt-regexp=20"^\\w*=3D[#>]=20"=0A+=20=20=20=20=20:prompt-regexp=20= "^[[:alnum:]_]*=3D[#>]=20"=0A=20=20=20=20=20=20:prompt-length=205=0A-=20=20= =20=20=20:prompt-cont-regexp=20"^\\w*[-(][#>]=20"=0A+=20=20=20=20=20= :prompt-cont-regexp=20"^[[:alnum:]_]*[-(][#>]=20"=0A=20=20=20=20=20=20= :input-filter=20sql-remove-tabs-filter=0A=20=20=20=20=20=20:terminator=20= ("\\(^\\s-*\\\\g$\\|;\\)"=20.=20"\\g"))=0A=20=0A@@=20-514,9=20+514,9=20= @@=20sql-product-alist=0A=20=20=20=20=20=20:sqli-comint-func=20= sql-comint-vertica=0A=20=20=20=20=20=20:list-all=20("\\d"=20.=20"\\dS")=0A= =20=20=20=20=20=20:list-table=20"\\d=20%s"=0A-=20=20=20=20=20= :prompt-regexp=20"^\\w*=3D[#>]=20"=0A+=20=20=20=20=20:prompt-regexp=20= "^[[:alnum:]_]*=3D[#>]=20"=0A=20=20=20=20=20=20:prompt-length=205=0A-=20=20= =20=20=20:prompt-cont-regexp=20"^\\w*[-(][#>]=20")=0A+=20=20=20=20=20= :prompt-cont-regexp=20"^[[:alnum:]_]*[-(][#>]=20")=0A=20=20=20=20=20)=0A=20= =20=20"An=20alist=20of=20product=20specific=20configuration=20settings.=0A= =20=0A--=20=0A2.7.1=0A=0A= --Apple-Mail=_4CDB60E9-5AE1-4CA5-99E6-B4E06E5095EE--