From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Date: Tue, 27 Oct 2015 09:05:52 +0100 Message-ID: <562F3060.9050301@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1445933246 29535 80.91.229.3 (27 Oct 2015 08:07:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Oct 2015 08:07:26 +0000 (UTC) Cc: 21766@debbugs.gnu.org To: Juanma Barranquero , Markus Triska Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 27 09:07:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZqzHk-0003Im-Qs for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Oct 2015 09:07:12 +0100 Original-Received: from localhost ([::1]:57993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqzHk-0001yz-2b for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Oct 2015 04:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqzHe-0001yu-1P for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 04:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqzHa-0000zd-SN for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 04:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqzHa-0000zZ-Ot for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 04:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZqzHa-00010z-6n for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2015 04:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Oct 2015 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21766 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21766-submit@debbugs.gnu.org id=B21766.14459331783845 (code B ref 21766); Tue, 27 Oct 2015 08:07:02 +0000 Original-Received: (at 21766) by debbugs.gnu.org; 27 Oct 2015 08:06:18 +0000 Original-Received: from localhost ([127.0.0.1]:39925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzGr-0000zw-Hp for submit@debbugs.gnu.org; Tue, 27 Oct 2015 04:06:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZqzGW-0000zG-Oi for 21766@debbugs.gnu.org; Tue, 27 Oct 2015 04:06:15 -0400 Original-Received: from [178.190.19.40] ([178.190.19.40]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0M3zG2-1ahRUf0Wws-00rc32; Tue, 27 Oct 2015 09:05:55 +0100 In-Reply-To: X-Provags-ID: V03:K0:y75C2G9LOgzEvU5NikpbMuWX351cinBOLWcIPn3BXnGDnbIb7cG FiMjDlBCfTvDSAau8x2HI3xCIEhX6VtKZoctUucyC0qnW0psX0K+kK9A5a2NrpNTcSlPY/g Q2XcK8dU6uUt8TokXgy2OwPZqi7jlGUj949ouC+1eeCRA5QlPoyrAXiBTe96r6iIa1raLQB 5+NlxY39URbd2GJV+M6PA== X-UI-Out-Filterresults: notjunk:1;V01:K0:JyMLBxQagoA=:3e/RycrhRvsf5ha42vChbG pNdlf26u1RISHW9B6SccVbumQBq+ntqGIFVlxd+7Ai0kIKHvymLOcDLMoc3dj+FdErxWudeia ZfDkty8+TQYBfOg8cyQqCoXUnswu9ApyGXSgDLbqwO3xpnVHkoJkyKi0TWTfdfLsn3Q3e7Vzz jvqjrd8siSeNpWWRLNETpCLMdfOlLeydOpCx/cW4dX4GlmwE+Ad10pEn3E6zUMEnVufHuCNM/ PX98CPlm9JZRoF5J33/LJ6h6Bcwb+gKAfje5VLMGNzdheyn2DsYK07G+cBmM8Q0ZdyBa3wVTX LSNfGiMkWg90AMIU/azAxTHIYn03Wuqvf5kuxi02f++BTl+RNL/9rHxzuNtMZk4cjXxhfUTCf 74YsVbRD6m+zNlVz840Bq42jQYMrre3D1rRhHRrnOy1mKErW2KQfHbM2JrEmWISIvUUm+q5Mi hHRytTu79Ns+qq4rH8d25R48g9JkQBzDmCMU0e3vV4bxWbOPt1GT2/nOn1gOK6YbiXsahVpQE Dcn4obbtKNtJWT4kRYhSBXnEE7hNzLW1tDLL6rANa5WemCeb3Qx3KQxIO8AeVgPjqrp7PPJpO hSFDsztKrI7/PQsMRakqoEqPPWeMzP7XJ0yotWy6CKXYXckEh1w9zrmixtI7Ec68iHNbcNvDz BfPF0C5e6SM/tTOrq1F/JylY42Xw75uN6FfWW0rTcLWaT1f2khEVA+7OMgc1tthXnLfz6wHEg 3iFT666Q5SR8Wsmj/i4GNEo1jgWZC2WW9fJXdTvG4ysBBCFc8cXX6/6zY5GGZ6YJIO57dHNw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108059 Archived-At: > Now, the question is, should skip-syntax-backward preserve the > match data, or must delete-trailing-whitespace be coded defensively? The latter. > The > usual policy has been that code that needs the match data preserved should > make sure itself that it is so. Shouldn't we remove that "\\s-$" rigmarole? Something like the largely untested (let ((end-marker (copy-marker (or end (point-max)))) old-bol new-eol new-bol) (goto-char (or start (point-min))) (while (re-search-forward "\\\n" end-marker t) (setq new-bol (point)) (goto-char (setq new-eol (match-beginning 0))) (if (or (zerop (skip-syntax-backward "-" (or old-bol (line-beginning-position)))) (looking-at-p ".*\f")) (goto-char new-bol) (delete-region (point) new-eol) (forward-char)) (setq old-bol (point))) It's still not very clean (should line-beginning-position be allowed to go before START?) so if someone wants to polish it up .... martin