From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21649: 25.0.50; [PATCH] Allow M-x man to reuse an existing window Date: Fri, 23 Oct 2015 10:01:48 +0200 Message-ID: <5629E96C.3090307@gmx.at> References: <86r3l09t3u.fsf@members.fsf.org> <86y4f6v2r2.fsf@members.fsf.org> <561E1736.7070706@gmx.at> <86wpufc8n8.fsf@members.fsf.org> <56290200.1000700@gmx.at> <86bnbqd80z.fsf@members.fsf.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1445587416 30124 80.91.229.3 (23 Oct 2015 08:03:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 08:03:36 +0000 (UTC) Cc: "21649@debbugs.gnu.org" <21649@debbugs.gnu.org> To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 23 10:03:25 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpXJi-0000aW-PJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 10:03:15 +0200 Original-Received: from localhost ([::1]:36868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXJi-00033g-8f for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 04:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXJe-00030M-7n for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:03:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpXJW-0001Wt-O7 for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:03:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXJW-0001Wk-KV for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZpXJW-0000PN-8m for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2015 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21649-submit@debbugs.gnu.org id=B21649.14455873411516 (code B ref 21649); Fri, 23 Oct 2015 08:03:02 +0000 Original-Received: (at 21649) by debbugs.gnu.org; 23 Oct 2015 08:02:21 +0000 Original-Received: from localhost ([127.0.0.1]:33725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpXIr-0000ON-5b for submit@debbugs.gnu.org; Fri, 23 Oct 2015 04:02:21 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59437) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpXIX-0000Na-Gt for 21649@debbugs.gnu.org; Fri, 23 Oct 2015 04:02:19 -0400 Original-Received: from [188.22.46.151] ([188.22.46.151]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MPUFR-1Ztg1c03Or-004iXF; Fri, 23 Oct 2015 10:01:57 +0200 In-Reply-To: <86bnbqd80z.fsf@members.fsf.org> X-Provags-ID: V03:K0:YFj7mo+psV0hjKYoyv4vcw40IvNgOp3PIJhePVs37td6ObCDXjf yH8971m6RO5IxrWC9Gro8cCI3dmC5aKIg3Q5wq8KAXH3f0ab48IJ7/OlbkPtW8z6Mao18pw ARks1AgRn9DsiVkI4t8GYz1WGFJZObQnUcXmIRk1auMBd+jVH7qake/Iz9/8wC6twru5BWx Yv1xFaY8dI1KdKBQDdLqw== X-UI-Out-Filterresults: notjunk:1;V01:K0:n3O+kaYz8Xg=:bwiZyeWm6YPnOwTErJaZsI pI6EJpEFaEEfbL9zg8CbL44S1dWLep3TzEe+rm0ZqP1zdoE5rO71WA4nFJ2O/nTBSHrgFmRWQ //0HxINeEmqb7V4c/t1m2EoK3CEAhvHwqV3bowoLcUTHhG4nuorNfcP6LRdhZWn5U/Ch252Zm ZtRw3GsfmkR3NsktJAecxs28Y1ZOoNk8he0jWZKJHyNf8dtHCRNXvwrLf8FEUnBMcWR9K318e Y9cBEBsCW9ZfC43D9Ui9gTZFO2j/k3opizANkKhpuYN0lj/CbLKIiZzWlscJYCQHm+eC8/XRf AmWo0PkUvWKX1kN2+B+1xbs+fkgdYLTLjaIi1Bzq4NYrE+OPHNLLAvPQw6/W0m5UtQlb3Fpvx uJTaf9G7zzA0u/9jEDcQ40LORdctzxkZJTLyNMlrtHlSIV3a6eOBUMuxO4uc8XaXDO2Xlo8Ko 2pvcw341VaOcec/ZnMpzbGjgFPCdmkJ/hyFYBACbxF2kAXqwvHui8RVqYo1+kqcrtG680zZBA eT3aG1jDpL8YvKQvoa/c51hu4ar6ymVSvufhwZfZXUcIoHxFeM7AkFcWR91Y0w8r5+7XyzqDy nmTl5ffGuGkfrIsSllWE3UF010MBg+MNeSD/xRGr3VM3X5aQRaWVGiuW/2DDeRSdeR4TY9kTv a1sWf6W/I1iGYT5E5BpzTj/tT2Ry9jnssmPtT4itr0afYNDAkO2CZr3nraIvYt4pK0WTEUzJn ItFsOCsynVLkAEftu/ceagYnVkA9sF+9XpGvIJug0voKcNTBC5k+R2n8HaTMX/RQyBan2chZ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107892 Archived-At: > Here's most of the patch : > > + (`manly > + (and (frame-live-p saved-frame) > + (select-frame saved-frame)) > + (if-let ((window (seq-some-p > + (lambda (window) > + (with-current-buffer (window-buffer window= ) > + (derived-mode-p 'Man-mode))) > + (window-list)))) > + (set-window-buffer window man-buffer) > + (display-buffer man-buffer))) > >> How about writing an action function, say =E2=80=98man-display-buffer= -my-way=E2=80=99, and >> adding a clause like >> >> (`my-way >> (and (frame-live-p saved-frame) >> (select-frame saved-frame)) >> (display-buffer man-buffer >> '((man-display-buffer-my-way ...) >> . nil))) > > Sure, why not! Maybe we could add something like =E2=80=98display-buffer-reuse-mode-wind= ow=E2=80=99 to window.el. In that case I'd proceed as follows: (1) The frame(s) to scan for a suitable window should be determined by a =E2=80=98reusable-frames=E2=80=99 entry just as in =E2=80=98display-buffe= r-reuse-window=E2=80=99. (2) Allow to specify the desired (parent) mode via an ALIST =E2=80=98mode= =E2=80=99 entry. As value we could allow a single mode or a list of modes. Then a window showing a buffer in the same mode as the buffer we want to display should maybe given preference to a window showing a buffer in another mode, derived from the same parent mode. If a same-mode-window exists on another and a derived-mode-window exists on the selected frame, one of these should be given preference consistently. (3) Not use functions like =E2=80=98if-let=E2=80=99 and =E2=80=98seq-some= -p=E2=80=99. window.el is preloaded and if not utterly necessary I'd prefer not loading subr-x.el there. BTW, I have no idea from where you get =E2=80=98seq-some-p=E2=80=99= =2E Did you compile your patched man.el with emacs -Q? WDYT? martin