From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42113: 28.0.50; Segmentation fault in json-parse-file Date: Mon, 29 Jun 2020 12:39:35 +0300 Message-ID: <5613F080-14DE-4562-BDA1-FD439C9FBF5D@gnu.org> References: <5ef91115.1c69fb81.aa1e3.9577@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="56922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: K-9 Mail for Android To: 42113@debbugs.gnu.org, p.stephani2@gmail.com, egh@e6h.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 29 11:40:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jpqGo-000EfL-P6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jun 2020 11:40:10 +0200 Original-Received: from localhost ([::1]:52820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpqGn-0007UG-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jun 2020 05:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpqGg-0007T7-QE for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 05:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36411) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpqGg-000124-GX for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpqGg-0000Kv-E4 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2020 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2020 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42113 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Philipp Stephani , Erik Hetzner X-Debbugs-Original-Cc: 42113@debbugs.gnu.org Original-Received: via spool by 42113-submit@debbugs.gnu.org id=B42113.15934235881260 (code B ref 42113); Mon, 29 Jun 2020 09:40:02 +0000 Original-Received: (at 42113) by debbugs.gnu.org; 29 Jun 2020 09:39:48 +0000 Original-Received: from localhost ([127.0.0.1]:47956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpqGS-0000KG-4a for submit@debbugs.gnu.org; Mon, 29 Jun 2020 05:39:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpqGQ-0000Jr-CL for 42113@debbugs.gnu.org; Mon, 29 Jun 2020 05:39:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56579) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpqGK-0000sD-Q9; Mon, 29 Jun 2020 05:39:40 -0400 Original-Received: from [109.253.170.114] (port=42608 helo=[10.128.245.141]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1jpqGJ-0001rX-Ik; Mon, 29 Jun 2020 05:39:40 -0400 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182517 Archived-At: On June 29, 2020 11:33:45 AM GMT+03:00, Philipp Stephani wrote: > Am So=2E, 28=2E Juni 2020 um 23:53 Uhr schrieb Erik Hetzner : > > > > 1=2E Start emacs -Q > > 2=2E Evaluate the following > > (require 'dom) > > > > (with-current-buffer (url-retrieve-synchronously > "https://www=2Eseriouseats=2Ecom/recipes/2020/06/florentine-omelette-spi= nach-and-cheese=2Ehtml") > > (let* ((dom (libxml-parse-html-region (point-min) > (point-max))) > > (scripts (dom-by-tag dom 'script)) > > (json-lds-raw (dom-elements scripts 'type > "^application/ld\\+json$")) > > (json-lds (mapcar #'json-parse-string > json-lds-raw))))) > > > > Result: segmentation fault=2E >=20 > Simpler: (json-parse-string 1) > The JSON functions are missing CHECK_STRING in several places where > json_encode is called=2E In this specific case I think the test is there, but it is done a bit too = late=2E The call to check_string_without_embedded_nuls should be moved bef= ore json_encode=2E