From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Max Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Sat, 6 May 2023 12:25:42 +0700 Message-ID: <5603ba14-8120-cf38-05ba-4435c1bece3f@gmail.com> References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <837cujaqzq.fsf@gnu.org> <87wn2ilwed.fsf@localhost> <83zg7ealrd.fsf@gnu.org> <87pm8a8dx4.fsf@localhost> <87pm7vt0mx.fsf@localhost> <87cz3k8i27.fsf@localhost> <87sfcfdldt.fsf@localhost> <87bkj1g10g.fsf@localhost> <1c5d0ff0-5bae-1123-d2f7-64d9013fbc0f@gmail.com> <6070e598-7dee-1b7a-7f97-26a90618cb7a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16987"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: Ihor Radchenko , 62762@debbugs.gnu.org, bzg@gnu.org, dmitry@gutov.dev, Alan Mackenzie , Eli Zaretskii To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 07:26:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvAR6-0004ET-8C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 07:26:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvAQn-0006Ao-25; Sat, 06 May 2023 01:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvAQl-0006Ag-HL for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvAQl-0007fA-0S for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvAQk-0000Fr-I7 for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 01:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Max Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 05:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.1683350756966 (code B ref 62762); Sat, 06 May 2023 05:26:02 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 6 May 2023 05:25:56 +0000 Original-Received: from localhost ([127.0.0.1]:58015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAQd-0000FW-OY for submit@debbugs.gnu.org; Sat, 06 May 2023 01:25:56 -0400 Original-Received: from mail-lj1-f179.google.com ([209.85.208.179]:56625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvAQY-0000FC-Bk for 62762@debbugs.gnu.org; Sat, 06 May 2023 01:25:53 -0400 Original-Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ac7de2b72fso29607581fa.1 for <62762@debbugs.gnu.org>; Fri, 05 May 2023 22:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683350744; x=1685942744; h=content-transfer-encoding:in-reply-to:cc:content-language :references:to:subject:from:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=MsMlcltME9TO9vOLOwn1GfsqdnGJboneD85mND0ps3s=; b=RKg/U7Tv5fk2JKWBZA6wZUIig9DSqpUnbCn8txvoVfg7jGQ/pNcHiIuRsmCuZO7ND2 NamtJDVcPERApZGX973Wma6cdp5Ds+UrGgFjpIgnh41Q64ceo2k5RdPDOtXLinh7rMrD eFvqwEjzOopaUQoTp3XeupKpUvJBXFLGrqxY5Xu1zSFR3qAeH6PVBqxeRHwFZom+zPxp 49QRr8YTXmWJa1ODvx1zwm30cS2azG0sFmKox6NjgecixNJTYGcUu56WEQMS+WfA8Pke 2eCtGQ1Gtr88AAFeDikRfVgsoCZ8MtvWZ/S8krDSilweOgXWmNukHosJwNdfGnX64NAd +fqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683350744; x=1685942744; h=content-transfer-encoding:in-reply-to:cc:content-language :references:to:subject:from:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MsMlcltME9TO9vOLOwn1GfsqdnGJboneD85mND0ps3s=; b=Q8xLfuYzagM5PxfY4GSiWLWDhSaVuqzv6wq9N/oucWPrUfSpePytNbfEN2DNOk0Q3k BNIVV5RbiPFQSmCMwHbjuxWpcjoPp0dOfJIqJW/fZnwVVS9xmNnqDE559JlPQi7/nGkZ 74KDtQebBOORwATh1HY3jnsDgrL7DeFdWeyFMYndWtBDEB+HSzIweq7E/leLD1DlY5Cg p/nOq9fAvjbqNMvJaPM00DSYkE3mfP/A31cmbynhJdIzD9bJRJd4JArmk1UJoDhfyslC uLbeiDUIcnwWMom4SgisJoemN6qyC3/MLADni1YDzdw+eRerCC3uZ11o2NBtAWHtI5V6 B3Zg== X-Gm-Message-State: AC+VfDw+BKjVzQfuI97+FbbkOJaJNcEnCckF+1kmO6xs/vOly5ZSDLQt McYL98FUfnP1CmRKORbzCiI= X-Google-Smtp-Source: ACHHUZ4zvlGOHHU2/wJcoKOen+Wf2h2vmiAOQKUzLLBh9013jhQ81EkjHEMvQrvTOS0GYSkWaBMO7w== X-Received: by 2002:a2e:968b:0:b0:2a8:b300:acb5 with SMTP id q11-20020a2e968b000000b002a8b300acb5mr911704lji.9.1683350744008; Fri, 05 May 2023 22:25:44 -0700 (PDT) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id c24-20020a05651c015800b002a9ebff8431sm250062ljd.94.2023.05.05.22.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 22:25:43 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261153 Archived-At: Stefan, my apologizes that I sent first copy exclusively to you. On 06/05/2023 01:17, Stefan Monnier wrote: >> I have no ideas how to make `org-assert-version' better. > > `my-require-with-shadow-check' is a suggestion to make it better. My current opinion is that `my-require-with-shadow-check' may be an improvement when *combined* with original `org-assert-version' (that inscribes org-version into .elc files). The reason why `my-require-with-shadow-check' may be significantly less efficient if it will *replace* original implementation of `org-assert-version' is the following. Consider a user who cloned org-mode git repository and loads Org mode from there with periodic pull and rebuild actions. Forget about built-in Org and assume that `load-path' is modified early enough to not cause any problem. Now literally citing my Fri, 5 May 2023 11:18:17 +0700 message https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62762#140 Does in help in the following case? 1. Base Org part is loaded on opening of some .org file. 2. Org in that directory is updated and recompiled. 3. New Org feature is loaded (autoloaded or by explicit call of e.g. (require ob-shell)) Additional argument: When the reporter got the error from `org-assert-version' it was not necessary a false positive (however most probable on minor version update), user may face an error later while running Org because not all files were recompiled after changes in macros. I am in doubts if `my-require-with-shadow-check' may help in such cases. > And this sub-thread of the bug report was presumably your answer to the > question by Ihor: > > Max, do you see any obvious downsides in Stefan's idea about consulting > `load-history' vs. `load-path'? My excuses: - message subject has not changed, so it was unclear that it was decided to discuss purely mitigation of symptoms instead of fixing of real cause - participants of discussion are spread across time zones, so a longer messages may be preferred - Configuration of https://debbugs.gnu.org is worse than https://bugs.debian.org, reply to specific messages links are missed. - debbugs and thunderbird are not friends in respect to mbox links (and I have not created a wrapper script that should work as a workaround)