From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#53517: 29.0.50; [PATCH] `eshell-eval-using-options' :preserve-args breaks :external handling in some cases Date: Mon, 24 Jan 2022 22:29:20 -0800 Message-ID: <55ffc6fb-f109-f849-5533-7ff56b8187cf@gmail.com> References: <31760ab2-2f47-dacd-0a9f-6a0bddced866@gmail.com> <58d11a94-52ac-9df0-7e1c-7dea7e8cfe58@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9437"; mail-complaints-to="usenet@ciao.gmane.io" To: 53517@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 25 07:31:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCFMY-0002Ma-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 07:31:30 +0100 Original-Received: from localhost ([::1]:55208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCFMW-0001Qa-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 01:31:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCFL9-0001QJ-Qb for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 01:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCFL8-0002xC-UP for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 01:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCFL8-0001Ev-PX for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 01:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jan 2022 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53517 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53517-submit@debbugs.gnu.org id=B53517.16430921684690 (code B ref 53517); Tue, 25 Jan 2022 06:30:02 +0000 Original-Received: (at 53517) by debbugs.gnu.org; 25 Jan 2022 06:29:28 +0000 Original-Received: from localhost ([127.0.0.1]:46719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCFKa-0001Da-J5 for submit@debbugs.gnu.org; Tue, 25 Jan 2022 01:29:28 -0500 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:36814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCFKY-0001DN-PF for 53517@debbugs.gnu.org; Tue, 25 Jan 2022 01:29:27 -0500 Original-Received: by mail-pf1-f177.google.com with SMTP id 192so15233687pfz.3 for <53517@debbugs.gnu.org>; Mon, 24 Jan 2022 22:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WIjfKoxRBrhCTDqgC9qDnoamU2TAAlcTZZc7/nvUeTo=; b=dLLjRn6IdF+gEyqYRELiHMnGD9Dn1Nl94fhsXQ4jPywyzEtpipcO+p6MZRUeQmQHeY y50OKCs684jaZlEAC20BdHc2Qw9ShybzhvkG9rhFObjqcFjnKh5J1IgSpEAkSheVn57v uERZeEy6R187hhC0yLqFMtLWKn8Htr7A2DAWnWur3E2tFwbpr3GBafS00ifDyD6sO/ir N2V4jyBmSc3d7xOXFq83tH5Jsd+FLLYPFkv3BdDkeRnYnMRgojVMcIJWVoCoGYy+k6Iv vgaIT7kRolQWNth5xJe0ePcC3lb/r142qq8x3wYiDQ4UDCtUDy+Pd2rcjjaK1iY/zdmx 78GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WIjfKoxRBrhCTDqgC9qDnoamU2TAAlcTZZc7/nvUeTo=; b=VAaY9FqXah9e5lgJDzx+5hXXGhaxjmsxB2KMgD9ngNSn65MbpnVJ+d5QY8MKkUaRwI C33xcf11jbz0ysYNBrprqOfmCKIRDG0KcrYBhZWruI8/bK+6vLwcRi1f6mAl4fi6rwOb eI99tEI/sKW6yMc4mFKhWxfiGMo8WKcIupF0TNkM2myWlGi08faW0mZ61VDuJwd8lwk8 bvWu6OC0TH2GojPMtP8sIkoxPmx81Pq09xXKsJY1IrXXXPj8+TzLKlCTUS9mBGodSb3g 4mXH09/es31cBB2soGgTVO4kzAY4Mi2qRNNqH/Ftrt4PnAMko8DM9MOp6i6zS9bFyGYa XjRw== X-Gm-Message-State: AOAM533ux+Vlb83VlRpJb+ihKtwVgCN95Ydfb0MN37cBrjjrejngkqas wE4Sx6pItAxJxqN4Jovfc2QNFKvLcUsxOw== X-Google-Smtp-Source: ABdhPJzOMwrpkP4a07ACNQeaRabvSCj2HZK0PTGzLJf9Hoovtcok2l0N2GnGXwK1yE/lMOLmY+FBIA== X-Received: by 2002:a65:460d:: with SMTP id v13mr14269319pgq.373.1643092160816; Mon, 24 Jan 2022 22:29:20 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y191sm1486032pfb.114.2022.01.24.22.29.19 for <53517@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 22:29:20 -0800 (PST) In-Reply-To: <58d11a94-52ac-9df0-7e1c-7dea7e8cfe58@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225146 Archived-At: On 1/24/2022 9:19 PM, Jim Porter wrote: > On 1/24/2022 5:11 PM, Jim Porter wrote: >> (It might be nice to fix that too, but I think it's still useful to >> keep the original raw args around unchanged. Improving "-" support >> could be done later.) > > Actually, I'll do that now. Doing so fixes an issue I found in the > implementation of `eshell/cat'. "cat -" should read from stdin (and the > Eshell implementation should use the external /bin/cat to do this), but > it was getting parsed as "cat", so it erroneously thought there were > *no* input files. Just a note: `cat' with no args *should* read from stdin, but this doesn't actually work in Eshell yet; to read from stdin, you need to explicitly say "cat -" or "*cat". I plan to fix these bits in a separate bug, since I have a WIP patch series to allow piping to Lisp functions in Eshell. That involves rewriting most of `eshell/cat', so I figured I may as well just fix it once (later) instead of twice.