From: Dmitry Gutov <dgutov@yandex.ru>
To: Phillip Lord <phillip.lord@russet.org.uk>
Cc: 23769@debbugs.gnu.org, Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git
Date: Fri, 17 Jun 2016 05:41:04 +0300 [thread overview]
Message-ID: <55d7d4f1-321c-96a2-63da-8759bebffb89@yandex.ru> (raw)
In-Reply-To: <87twgsbvsc.fsf@russet.org.uk>
On 06/17/2016 01:42 AM, Phillip Lord wrote:
> A problem as "GIT_DIR" on it's own, still breaks with my originally
> reported error (at least when running my ert test I sent with my patch).
>
> Are you not getting this failure also?
Sorry, I was only testing that the addition doesn't break anything in
the normal case, otherwise relying on process-environment's docstring.
There was a problem with the patch that not all vc-git code goes through
vc-git--call (in fact, most don't), but even patching vc-git-command in
a similar fashion doesn't change the behavior if Emacs was started with
GIT_DIR=.git.
Could this feature be actually broken? Or how does Git ignore the
modification?
"To use ‘process-environment’ to
remove an environment variable, include only its name in the list,
without "=VALUE"."
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index f35c84d..a544a2e 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1423,7 +1423,9 @@ vc-git-command
(let ((coding-system-for-read
(or coding-system-for-read vc-git-log-output-coding-system))
(coding-system-for-write
- (or coding-system-for-write vc-git-commits-coding-system)))
+ (or coding-system-for-write vc-git-commits-coding-system))
+ (process-environment process-environment))
+ (push "GIT_DIR" process-environment)
(apply 'vc-do-command (or buffer "*vc*") okstatus vc-git-program
;; http://debbugs.gnu.org/16897
(unless (and (not (cdr-safe file-or-list))
@@ -1451,6 +1453,7 @@ vc-git--call
(coding-system-for-write
(or coding-system-for-write vc-git-commits-coding-system))
(process-environment (cons "PAGER=" process-environment)))
+ (push "GIT_DIR" process-environment)
(apply 'process-file vc-git-program nil buffer nil command args)))
(defun vc-git--out-ok (command &rest args)
next prev parent reply other threads:[~2016-06-17 2:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 11:16 bug#23769: 25.0.95; Mode Line breakage in vc-git Phillip Lord
2016-06-14 16:29 ` Glenn Morris
2016-06-14 17:03 ` Phillip Lord
2016-06-14 21:52 ` Dmitry Gutov
2016-06-14 22:21 ` Phillip Lord
2016-06-15 20:48 ` Phillip Lord
2016-06-15 21:02 ` Dmitry Gutov
2016-06-15 22:09 ` Phillip Lord
2016-06-15 22:27 ` Noam Postavsky
2016-06-15 23:20 ` Dmitry Gutov
2016-06-16 7:11 ` Phillip Lord
2016-06-16 7:45 ` Phillip Lord
2016-06-15 23:25 ` Dmitry Gutov
2016-06-16 7:41 ` Phillip Lord
2016-06-16 11:25 ` Dmitry Gutov
2016-06-16 16:06 ` Dmitry Gutov
2016-06-16 16:54 ` Noam Postavsky
2016-06-16 16:59 ` Dmitry Gutov
2016-06-16 21:47 ` Phillip Lord
2016-06-16 22:13 ` Dmitry Gutov
2016-06-16 22:23 ` Phillip Lord
2016-06-16 22:31 ` Dmitry Gutov
2016-06-16 22:42 ` Phillip Lord
2016-06-17 2:41 ` Dmitry Gutov [this message]
2016-06-17 3:37 ` Noam Postavsky
2016-06-17 6:54 ` Eli Zaretskii
2016-06-17 12:06 ` Dmitry Gutov
2016-06-17 13:21 ` Eli Zaretskii
2016-06-17 13:54 ` Dmitry Gutov
2016-06-17 15:09 ` Phillip Lord
2016-06-16 21:47 ` Phillip Lord
2016-06-16 22:04 ` Dmitry Gutov
2016-06-21 16:46 ` Dmitry Gutov
2016-06-21 20:45 ` Phillip Lord
2016-06-21 23:06 ` Dmitry Gutov
2016-06-15 21:56 ` John Wiegley
2016-06-14 21:30 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d7d4f1-321c-96a2-63da-8759bebffb89@yandex.ru \
--to=dgutov@yandex.ru \
--cc=23769@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).