From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20993: 25.0.50; virtual-dired problems Date: Mon, 6 Jul 2015 11:01:34 -0700 (PDT) Message-ID: <55a5f28c-d18e-4d55-a242-71be42c45294@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1436205807 877 80.91.229.3 (6 Jul 2015 18:03:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Jul 2015 18:03:27 +0000 (UTC) To: 20993@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 06 20:03:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZCAjX-0001B5-9P for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jul 2015 20:03:11 +0200 Original-Received: from localhost ([::1]:52287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAjW-0006jk-9S for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Jul 2015 14:03:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAjS-0006jT-EY for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCAjO-0002uZ-At for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:03:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAjO-0002uK-8M for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZCAjN-00029a-Uw for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jul 2015 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14362057248208 (code B ref -1); Mon, 06 Jul 2015 18:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jul 2015 18:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:42381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCAiR-00028K-Tq for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:02:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38929) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZCAiP-00027p-Eb for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:02:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCAiJ-0002Uj-Ad for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:01:56 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAiJ-0002Uf-7r for submit@debbugs.gnu.org; Mon, 06 Jul 2015 14:01:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAiF-0006Z9-1e for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCAi3-0002QJ-Gw for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:44 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:41836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCAi3-0002PW-Ao for bug-gnu-emacs@gnu.org; Mon, 06 Jul 2015 14:01:39 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t66I1aB3007184 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Jul 2015 18:01:36 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t66I1ZKn031521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 6 Jul 2015 18:01:36 GMT Original-Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t66I1ZdT008639 for ; Mon, 6 Jul 2015 18:01:35 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104784 Archived-At: A followup to bug #20992. Here are some other problems noticed immediately, besides the lack of clarity and the nature of the "mode", lighter/menu, etc.: 1. The prompt uses `read-string'. It should use `read-directory-name' or `read-file-name', to provide completion. In fact, given that the parameter list is the same as for `dired', why doesn't `virtual-dired' use `dired-read-dir-and-switches'? OK, presumably it is because you want to use `dired-virtual-guess-dir'. But that doesn't proscribe providing completion etc. 2. It seems that `virtual-dired' tries to reuse the current buffer. But it makes no attempt to ensure that this buffer is in a mode derived from Dired mode - it does not raise an error if not. For example, `M-x virtual-dired' from a buffer showing dired-x.el in read-only mode raises an error because that buffer is read-only. The doc string of `virtual-dired' says nothing about what mode the current buffer must be in, or the fact that the buffer is not switched but instead its mode is changed. You would need to consult the doc string of `dired-virtual-guess-dir' to discover this constraint/assumption: "The buffer is assumed to be in Dired or ls -lR format" That should be tested for. Dunno how the latter can be tested for, but some test should be used to make sure the buffer is appropriate for the kind of changes `virtual-dired' will make to it. As it is now, the code just willy nilly tries to modify the buffer text. 3. Defaulting to `default-directory' should be done in the interactive spec (also). 4. Overall, I'd say that someone should take a look at this `virtual-dired' feature and polish it up a bit. It seems a bit rough, so far. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1'