* bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master
@ 2015-09-16 6:02 Daniel McClanahan
2015-09-16 7:09 ` martin rudalics
0 siblings, 1 reply; 2+ messages in thread
From: Daniel McClanahan @ 2015-09-16 6:02 UTC (permalink / raw)
To: 21493
In commit 6d98299e761f18f171e042391138f4f5f5762de7, the form
lisp-mode-symbol-regexp was introduced, but it was added incorrectly
in one place. The form added,
(eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
is invalid, returning just "\\)\\_>". The fix is simple, and the diff
is given below.
Sorry if this message comes across garbled; I have selected the option
to turn off html in gmail, but I don't know if it works. Also sorry if
the fix is already committed, I just pulled and the fix has not been
made yet.
--Danny McClanahan
diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 56c2966..fed91b3 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -224,7 +224,8 @@
;; FIXME: Move to elisp-mode.el.
(catch 'found
(while (re-search-forward
- (eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
+ (eval-when-compile
+ (concat "(\\(" lisp-mode-symbol-regexp "\\)\\_>"))
limit t)
(let ((sym (intern-soft (match-string 1))))
(when (or (special-form-p sym)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master
2015-09-16 6:02 bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master Daniel McClanahan
@ 2015-09-16 7:09 ` martin rudalics
0 siblings, 0 replies; 2+ messages in thread
From: martin rudalics @ 2015-09-16 7:09 UTC (permalink / raw)
To: Daniel McClanahan, 21493
> In commit 6d98299e761f18f171e042391138f4f5f5762de7, the form
> lisp-mode-symbol-regexp was introduced, but it was added incorrectly
> in one place. The form added,
>
> (eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
>
> is invalid, returning just "\\)\\_>". The fix is simple, and the diff
> is given below.
>
> Sorry if this message comes across garbled; I have selected the option
> to turn off html in gmail, but I don't know if it works. Also sorry if
> the fix is already committed, I just pulled and the fix has not been
> made yet.
>
> --Danny McClanahan
>
> diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
> index 56c2966..fed91b3 100644
> --- a/lisp/emacs-lisp/lisp-mode.el
> +++ b/lisp/emacs-lisp/lisp-mode.el
> @@ -224,7 +224,8 @@
> ;; FIXME: Move to elisp-mode.el.
> (catch 'found
> (while (re-search-forward
> - (eval-when-compile "(\\(" lisp-mode-symbol-regexp "\\)\\_>")
> + (eval-when-compile
> + (concat "(\\(" lisp-mode-symbol-regexp "\\)\\_>"))
> limit t)
> (let ((sym (intern-soft (match-string 1))))
> (when (or (special-form-p sym)
Thank you. Installed.
martin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-16 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 6:02 bug#21493: 25.0.50; fix invalid regex in lisp--el-match-keyword introduced in master Daniel McClanahan
2015-09-16 7:09 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).