unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: "Matthias Güdemann" <matthias.guedemann@googlemail.com>
Cc: 21430@debbugs.gnu.org
Subject: bug#21430: 25.0.50; resizing window in exwm crashes emacs
Date: Tue, 08 Sep 2015 11:09:16 +0200	[thread overview]
Message-ID: <55EEA5BC.40305@gmx.at> (raw)
In-Reply-To: <874mj5fh7r.fsf@guedemann.org>

 > Out of curiosity: What was the problem? I had originally filed an exwm
 > issue and would like to add this information there, too.

The bug was caused by my commit from 2014-07-27 with the ChangeLog entry

	* gtkutil.c (xg_frame_resized): Call do_pending_window_change.

Note that at the time of the commit that ChangeLog entry was

	* gtkutil.c (xg_frame_resized): Don't call
	do_pending_window_change.

so the commit was wrong twice: Once because the corresponding change
actually _added_ the call and once because adding the call was bad.

All this remained undetected for more than a year until Pip Cet filed
bug#21380 with a precise recipe.  I hopefully fixed the problem in a
commit with the ChangeLog entry

2015-08-31  Martin Rudalics  <rudalics@gmx.at>

	Don't call do_pending_window_change in signal handlers (Bug#21380)
	* src/gtkutil.c (xg_frame_resized):
	* src/xterm.c (x_set_window_size):
	* src/w32term.c (x_set_window_size): Don't call
	do_pending_window_change.

Apparently, the bug became virulent only when you've put something more
involved on ‘window-configuration-change-hook’.  What do you have there
(if it's no secret)?

martin






  reply	other threads:[~2015-09-08  9:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  7:57 bug#21430: 25.0.50; resizing window in exwm crashes emacs Matthias Güdemann
2015-09-07 16:20 ` Eli Zaretskii
2015-09-07 16:44 ` martin rudalics
2015-09-08  8:28   ` Matthias Güdemann
2015-09-08  9:09     ` martin rudalics [this message]
2015-09-08  9:25       ` Matthias Güdemann
2015-09-08 16:05       ` Eli Zaretskii
2015-09-08 16:49         ` Matthias Güdemann
2015-09-08 17:14           ` Eli Zaretskii
2015-09-09  8:22             ` Matthias Güdemann
2015-09-09 14:05               ` Eli Zaretskii
2015-09-15 12:39                 ` Matthias Güdemann
2015-09-15 12:53                   ` Eli Zaretskii
2015-09-15 13:18                     ` martin rudalics
2015-09-15 13:58                       ` Eli Zaretskii
2019-10-13  1:33                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EEA5BC.40305@gmx.at \
    --to=rudalics@gmx.at \
    --cc=21430@debbugs.gnu.org \
    --cc=matthias.guedemann@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).