From: Dmitry Gutov <dgutov@yandex.ru>
To: Jonathan H <pythonnut@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 21383-done@debbugs.gnu.org
Subject: bug#21383: Static revisions in vc-working-revision
Date: Thu, 3 Sep 2015 21:40:54 +0300 [thread overview]
Message-ID: <55E89436.7050603@yandex.ru> (raw)
In-Reply-To: <CAAW2-ZfMNgFB-tRV596xSLfX4ykqTOyVHrx2wS8MttL1Cfo1LA@mail.gmail.com>
On 09/03/2015 08:34 PM, Jonathan H wrote:
> I though the new implementation of the vc-git mode line doesn't use
> vc-working-revision,
Please look at the definition. vc-working-revision is called once in the
beginning of the function, and again through vc-default-mode-line-string.
Even if we inlined the useful parts of vc-default-mode-line-string
definition, calling vc-git-working-revision instead of
vc-git--symbolic-ref is still inevitable in "detached" [Git] mode.
> True, but you have to check that the cache is invalid somehow. If you
> want to be super correct, a rev-parse is probably the fastest way. I
We err on the side of speed currently, instead of correctness. The file
properties are invalidated during certain operations, like saving or
reverting the buffer.
> suppose it would be pretty fast to check the mtime of the .git directory
> inside emacs and invalidate that when it changes. Although filesystem
> timestamps usually make me nervous, it's probably okay in this instance?
I don't know, but it's probably not too hard to imagine a user with a
terminally slow HDD. Maybe it'll be fast enough anyway, but someone will
have to do a patch, and test.
next prev parent reply other threads:[~2015-09-03 18:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 0:45 bug#21383: Static revisions in vc-working-revision Jonathan H
2015-08-31 4:45 ` Stefan Monnier
2015-08-31 8:47 ` Dmitry Gutov
2015-08-31 17:44 ` Stefan Monnier
2015-09-01 2:11 ` Dmitry Gutov
2015-09-01 3:55 ` Stefan Monnier
2015-09-01 12:05 ` Dmitry Gutov
2015-09-01 15:45 ` Stefan Monnier
2015-09-01 15:54 ` Dmitry Gutov
2015-09-01 16:52 ` Stefan Monnier
2015-09-01 17:23 ` Dmitry Gutov
2015-09-02 3:50 ` Stefan Monnier
2015-09-02 10:49 ` Dmitry Gutov
2015-09-02 22:44 ` Jonathan H
2015-09-03 12:56 ` Dmitry Gutov
2015-09-03 16:17 ` Stefan Monnier
2015-09-03 17:34 ` Jonathan H
2015-09-03 18:40 ` Dmitry Gutov [this message]
2015-09-03 20:07 ` Stefan Monnier
2015-09-03 22:32 ` Dmitry Gutov
2015-09-04 14:36 ` Stefan Monnier
2015-09-05 2:30 ` Dmitry Gutov
2015-09-03 16:04 ` Stefan Monnier
2015-09-03 19:24 ` Dmitry Gutov
2015-09-04 2:20 ` Stefan Monnier
2015-09-05 3:08 ` Dmitry Gutov
2015-09-05 15:12 ` Stefan Monnier
2015-09-05 20:30 ` Dmitry Gutov
2015-09-06 22:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E89436.7050603@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21383-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=pythonnut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).