* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist [not found] ` <87wpyt5c26.fsf@web.de> @ 2015-07-13 15:06 ` Kaushal 2015-08-20 17:35 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-07-13 15:06 UTC (permalink / raw) To: michael_heerdegen, 21047 [-- Attachment #1: Type: text/plain, Size: 2670 bytes --] Hi, This was posted on the emacs-devel list a while back and it was suggested that this be posted on bug-gnu-emacs. The aim of this patch is that opening M-x woman buffers be controlled using display-buffer-alist. Using display-buffer function instead of switch-to-buffer function will allow the user to control how they want to open the WoMan buffers (same window, other window, popup, etc) The patch is below: Date: Mon, 13 Jul 2015 11:00:39 -0400 Subject: [PATCH] Allow display-buffer-alist to control woman bufs --- lisp/woman.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/woman.el b/lisp/woman.el index 75c3d2e..e903caa 100644 --- a/lisp/woman.el +++ b/lisp/woman.el @@ -1651,7 +1651,7 @@ Do not call directly!" (setq woman-frame (make-frame))))) (set-buffer (get-buffer-create bufname)) (condition-case nil - (switch-to-buffer (current-buffer)) + (display-buffer (current-buffer)) (error (pop-to-buffer (current-buffer)))) (buffer-disable-undo) (setq buffer-read-only nil) @@ -2061,14 +2061,14 @@ alist in `woman-buffer-alist' and return nil." (if (zerop woman-buffer-number) (let ((buffer (get-buffer (cdr (car woman-buffer-alist))))) (if buffer - (switch-to-buffer buffer) + (display-buffer buffer) ;; Delete alist element: (setq woman-buffer-alist (cdr woman-buffer-alist)) nil)) (let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist)) (buffer (get-buffer (cdr (car (cdr prev-ptr)))))) (if buffer - (switch-to-buffer buffer) + (display-buffer buffer) ;; Delete alist element: (setcdr prev-ptr (cdr (cdr prev-ptr))) (if (>= woman-buffer-number (length woman-buffer-alist)) -- 1.9.2 On Wed, Jun 24, 2015 at 12:03 PM Michael Heerdegen <michael_heerdegen@web.de> wrote: > Hi Kaushal, > > > I was trying to make the WoMan buffers open as I intend to using > > display-buffer-alist. But that was not working. > > I guess your message got lost here, better make a bug report, and > better include a patch than the whole changed code. > > > can that change be made in the master? > > I think it would be an improvement. > > The very same applies to eww: > > --8<---------------cut here---------------start------------->8--- > (defun eww-setup-buffer () > (switch-to-buffer (get-buffer-create "*eww*")) ; <----- > (let ((inhibit-read-only t)) > (remove-overlays) > (erase-buffer)) > (unless (eq major-mode 'eww-mode) > (eww-mode))) > --8<---------------cut here---------------end--------------->8--- > > Maybe there are more cases. It's surely worth discussing. > > > Regards, > > Michael. > [-- Attachment #2: Type: text/html, Size: 4446 bytes --] ^ permalink raw reply related [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-07-13 15:06 ` bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist Kaushal @ 2015-08-20 17:35 ` Kaushal 2015-08-21 5:42 ` Stefan Monnier 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-20 17:35 UTC (permalink / raw) To: michael_heerdegen, 21047 [-- Attachment #1: Type: text/plain, Size: 2913 bytes --] Can someone please review this? On Mon, Jul 13, 2015 at 11:06 AM Kaushal <kaushal.modi@gmail.com> wrote: > Hi, > > This was posted on the emacs-devel list a while back and it was suggested > that this be posted on bug-gnu-emacs. > > The aim of this patch is that opening M-x woman buffers be controlled > using display-buffer-alist. Using display-buffer function instead of > switch-to-buffer function will allow the user to control how they want to > open the WoMan buffers (same window, other window, popup, etc) > > The patch is below: > > Date: Mon, 13 Jul 2015 11:00:39 -0400 > Subject: [PATCH] Allow display-buffer-alist to control woman bufs > > --- > lisp/woman.el | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lisp/woman.el b/lisp/woman.el > index 75c3d2e..e903caa 100644 > --- a/lisp/woman.el > +++ b/lisp/woman.el > @@ -1651,7 +1651,7 @@ Do not call directly!" > (setq woman-frame (make-frame))))) > (set-buffer (get-buffer-create bufname)) > (condition-case nil > - (switch-to-buffer (current-buffer)) > + (display-buffer (current-buffer)) > (error (pop-to-buffer (current-buffer)))) > (buffer-disable-undo) > (setq buffer-read-only nil) > @@ -2061,14 +2061,14 @@ alist in `woman-buffer-alist' and return nil." > (if (zerop woman-buffer-number) > (let ((buffer (get-buffer (cdr (car woman-buffer-alist))))) > (if buffer > - (switch-to-buffer buffer) > + (display-buffer buffer) > ;; Delete alist element: > (setq woman-buffer-alist (cdr woman-buffer-alist)) > nil)) > (let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist)) > (buffer (get-buffer (cdr (car (cdr prev-ptr)))))) > (if buffer > - (switch-to-buffer buffer) > + (display-buffer buffer) > ;; Delete alist element: > (setcdr prev-ptr (cdr (cdr prev-ptr))) > (if (>= woman-buffer-number (length woman-buffer-alist)) > -- > 1.9.2 > > > On Wed, Jun 24, 2015 at 12:03 PM Michael Heerdegen < > michael_heerdegen@web.de> wrote: > >> Hi Kaushal, >> >> > I was trying to make the WoMan buffers open as I intend to using >> > display-buffer-alist. But that was not working. >> >> I guess your message got lost here, better make a bug report, and >> better include a patch than the whole changed code. >> >> > can that change be made in the master? >> >> I think it would be an improvement. >> >> The very same applies to eww: >> >> --8<---------------cut here---------------start------------->8--- >> (defun eww-setup-buffer () >> (switch-to-buffer (get-buffer-create "*eww*")) ; <----- >> (let ((inhibit-read-only t)) >> (remove-overlays) >> (erase-buffer)) >> (unless (eq major-mode 'eww-mode) >> (eww-mode))) >> --8<---------------cut here---------------end--------------->8--- >> >> Maybe there are more cases. It's surely worth discussing. >> >> >> Regards, >> >> Michael. >> > [-- Attachment #2: Type: text/html, Size: 4577 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-20 17:35 ` Kaushal @ 2015-08-21 5:42 ` Stefan Monnier 2015-08-21 11:17 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: Stefan Monnier @ 2015-08-21 5:42 UTC (permalink / raw) To: Kaushal; +Cc: michael_heerdegen, 21047 > Can someone please review this? Looks OK to me, Stefan ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 5:42 ` Stefan Monnier @ 2015-08-21 11:17 ` Kaushal 2015-08-21 12:25 ` martin rudalics 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-21 11:17 UTC (permalink / raw) To: Stefan Monnier; +Cc: Michael Heerdegen, 21047 [-- Attachment #1: Type: text/plain, Size: 261 bytes --] Thanks! I don't have the commit rights. Can you please apply this patch to the master? -- Kaushal Modi On Aug 21, 2015 1:42 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote: > > Can someone please review this? > > Looks OK to me, > > > Stefan > [-- Attachment #2: Type: text/html, Size: 585 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 11:17 ` Kaushal @ 2015-08-21 12:25 ` martin rudalics 2015-08-21 12:30 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: martin rudalics @ 2015-08-21 12:25 UTC (permalink / raw) To: Kaushal, Stefan Monnier; +Cc: Michael Heerdegen, 21047 > I don't have the commit rights. Can you please apply this patch to the > master? Pushed as 8c01e88..244a008 master -> master. Thanks, martin ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 12:25 ` martin rudalics @ 2015-08-21 12:30 ` Kaushal 2015-08-21 13:36 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-21 12:30 UTC (permalink / raw) To: martin rudalics; +Cc: Michael Heerdegen, 21047 [-- Attachment #1: Type: text/plain, Size: 289 bytes --] Thanks! There goes my first little patch. :) -- Kaushal Modi On Aug 21, 2015 8:25 AM, "martin rudalics" <rudalics@gmx.at> wrote: > > I don't have the commit rights. Can you please apply this patch to the > > master? > > Pushed as 8c01e88..244a008 master -> master. > > Thanks, martin > [-- Attachment #2: Type: text/html, Size: 583 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 12:30 ` Kaushal @ 2015-08-21 13:36 ` Kaushal 2015-08-21 15:11 ` martin rudalics 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-21 13:36 UTC (permalink / raw) To: martin rudalics; +Cc: Michael Heerdegen, 21047 [-- Attachment #1: Type: text/plain, Size: 881 bytes --] I apologize for this maintenance type of request. I saw that my patch was associated with just my first name "Kaushal" instead of my full name "Kaushal Modi". I then noticed that that's perhaps because I have probably unintentionally hidden my last name in the emacs-devel list. While I figure out and fix this, is it possible to correct the author name from "Kaushal" to "Kaushal Modi" to be consistent with the first and last name author convention as seen on all other commits? Thanks. Kaushal Modi On Aug 21, 2015 8:30 AM, "Kaushal" <kaushal.modi@gmail.com> wrote: > Thanks! There goes my first little patch. :) > > -- > Kaushal Modi > On Aug 21, 2015 8:25 AM, "martin rudalics" <rudalics@gmx.at> wrote: > >> > I don't have the commit rights. Can you please apply this patch to the >> > master? >> >> Pushed as 8c01e88..244a008 master -> master. >> >> Thanks, martin >> > [-- Attachment #2: Type: text/html, Size: 1517 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 13:36 ` Kaushal @ 2015-08-21 15:11 ` martin rudalics 2015-08-21 15:13 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: martin rudalics @ 2015-08-21 15:11 UTC (permalink / raw) To: Kaushal; +Cc: 21047 > I apologize for this maintenance type of request. I saw that my patch was > associated with just my first name "Kaushal" instead of my full name > "Kaushal Modi". I then noticed that that's perhaps because I have probably > unintentionally hidden my last name in the emacs-devel list. My bad. I really should have asked before committing. But I was distracted that your patch didn't apply. Kindly send the next patch as an attachment to your mail. > While I figure out and fix this, is it possible to correct the author name > from "Kaushal" to "Kaushal Modi" to be consistent with the first and last > name author convention as seen on all other commits? I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. As for the commit message there's hardly anything we can do now. martin ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:11 ` martin rudalics @ 2015-08-21 15:13 ` Kaushal 2015-08-21 15:16 ` Kaushal 2015-08-24 8:16 ` martin rudalics 0 siblings, 2 replies; 16+ messages in thread From: Kaushal @ 2015-08-21 15:13 UTC (permalink / raw) To: martin rudalics; +Cc: 21047 [-- Attachment #1: Type: text/plain, Size: 1095 bytes --] > Kindly send the next patch as an attachment to your mail. Will do so, thanks. > I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. Thanks. On Fri, Aug 21, 2015 at 11:11 AM martin rudalics <rudalics@gmx.at> wrote: > > I apologize for this maintenance type of request. I saw that my patch > was > > associated with just my first name "Kaushal" instead of my full name > > "Kaushal Modi". I then noticed that that's perhaps because I have > probably > > unintentionally hidden my last name in the emacs-devel list. > > My bad. I really should have asked before committing. But I was > distracted that your patch didn't apply. Kindly send the next patch as > an attachment to your mail. > > > While I figure out and fix this, is it possible to correct the author > name > > from "Kaushal" to "Kaushal Modi" to be consistent with the first and > last > > name author convention as seen on all other commits? > > I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. > As for the commit message there's hardly anything we can do now. > > martin > [-- Attachment #2: Type: text/html, Size: 2281 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:13 ` Kaushal @ 2015-08-21 15:16 ` Kaushal 2015-08-21 15:30 ` martin rudalics 2015-08-24 8:16 ` martin rudalics 1 sibling, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-21 15:16 UTC (permalink / raw) To: martin rudalics; +Cc: 21047 [-- Attachment #1: Type: text/plain, Size: 1315 bytes --] One more thing.. also this bug now needs to be closed, right? And also referenced in that commit message. On Fri, Aug 21, 2015 at 11:13 AM Kaushal <kaushal.modi@gmail.com> wrote: > > Kindly send the next patch as an attachment to your mail. > > Will do so, thanks. > > > I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. > > Thanks. > > On Fri, Aug 21, 2015 at 11:11 AM martin rudalics <rudalics@gmx.at> wrote: > >> > I apologize for this maintenance type of request. I saw that my patch >> was >> > associated with just my first name "Kaushal" instead of my full name >> > "Kaushal Modi". I then noticed that that's perhaps because I have >> probably >> > unintentionally hidden my last name in the emacs-devel list. >> >> My bad. I really should have asked before committing. But I was >> distracted that your patch didn't apply. Kindly send the next patch as >> an attachment to your mail. >> >> > While I figure out and fix this, is it possible to correct the author >> name >> > from "Kaushal" to "Kaushal Modi" to be consistent with the first and >> last >> > name author convention as seen on all other commits? >> >> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. >> As for the commit message there's hardly anything we can do now. >> >> martin >> > [-- Attachment #2: Type: text/html, Size: 2783 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:16 ` Kaushal @ 2015-08-21 15:30 ` martin rudalics 2015-08-21 15:33 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: martin rudalics @ 2015-08-21 15:30 UTC (permalink / raw) To: Kaushal; +Cc: 21047 > One more thing.. also this bug now needs to be closed, right? Please do that. > And also > referenced in that commit message. I'll do that. Please remind me as soon as you see the commit in ChangeLog.2. martin ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:30 ` martin rudalics @ 2015-08-21 15:33 ` Kaushal 2015-08-21 15:58 ` martin rudalics 0 siblings, 1 reply; 16+ messages in thread From: Kaushal @ 2015-08-21 15:33 UTC (permalink / raw) To: martin rudalics, Stefan Monnier; +Cc: 21047 [-- Attachment #1: Type: text/plain, Size: 396 bytes --] I don't know how to close a debbugs. I believe only a debbugs admin can do that? On Fri, Aug 21, 2015 at 11:30 AM martin rudalics <rudalics@gmx.at> wrote: > > One more thing.. also this bug now needs to be closed, right? > > Please do that. > > > And also > > referenced in that commit message. > > I'll do that. Please remind me as soon as you see the commit in > ChangeLog.2. > > martin > > [-- Attachment #2: Type: text/html, Size: 694 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:33 ` Kaushal @ 2015-08-21 15:58 ` martin rudalics 2015-08-21 16:00 ` Kaushal 0 siblings, 1 reply; 16+ messages in thread From: martin rudalics @ 2015-08-21 15:58 UTC (permalink / raw) To: Kaushal, Stefan Monnier; +Cc: 21047-done > I don't know how to close a debbugs. I believe only a debbugs admin can do > that? It's easy. You have to append -done to the bug number in the recipient. As I'm doing just now ... martin ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:58 ` martin rudalics @ 2015-08-21 16:00 ` Kaushal 0 siblings, 0 replies; 16+ messages in thread From: Kaushal @ 2015-08-21 16:00 UTC (permalink / raw) To: martin rudalics, Stefan Monnier; +Cc: 21047-done [-- Attachment #1: Type: text/plain, Size: 327 bytes --] Noted that for the next time. Thanks! On Fri, Aug 21, 2015 at 11:58 AM martin rudalics <rudalics@gmx.at> wrote: > > I don't know how to close a debbugs. I believe only a debbugs admin can > do > > that? > > It's easy. You have to append -done to the bug number in the recipient. > As I'm doing just now ... > > martin > > > [-- Attachment #2: Type: text/html, Size: 610 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-21 15:13 ` Kaushal 2015-08-21 15:16 ` Kaushal @ 2015-08-24 8:16 ` martin rudalics 2015-08-24 10:46 ` Kaushal Modi 1 sibling, 1 reply; 16+ messages in thread From: martin rudalics @ 2015-08-24 8:16 UTC (permalink / raw) To: Kaushal; +Cc: 21047 >> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. > > Thanks. Should be done now. Please have a look. Thanks again, martin ^ permalink raw reply [flat|nested] 16+ messages in thread
* bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist 2015-08-24 8:16 ` martin rudalics @ 2015-08-24 10:46 ` Kaushal Modi 0 siblings, 0 replies; 16+ messages in thread From: Kaushal Modi @ 2015-08-24 10:46 UTC (permalink / raw) To: martin rudalics; +Cc: 21047 [-- Attachment #1: Type: text/plain, Size: 274 bytes --] Looks good. Thank you. -- Kaushal Modi On Aug 24, 2015 4:16 AM, "martin rudalics" <rudalics@gmx.at> wrote: > >> I'll correct the ChangeLog entry as soon as it appears in ChangeLog.2. > > > > Thanks. > > Should be done now. Please have a look. > > Thanks again, martin > [-- Attachment #2: Type: text/html, Size: 593 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-08-24 10:46 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAFyQvY27mYunAGy6yuzoMf5L03BFySwam_TKCXofMK3yR2fd3w@mail.gmail.com>
[not found] ` <87wpyt5c26.fsf@web.de>
2015-07-13 15:06 ` bug#21047: 25.0.50; Make M-x woman respect display-buffer-alist Kaushal
2015-08-20 17:35 ` Kaushal
2015-08-21 5:42 ` Stefan Monnier
2015-08-21 11:17 ` Kaushal
2015-08-21 12:25 ` martin rudalics
2015-08-21 12:30 ` Kaushal
2015-08-21 13:36 ` Kaushal
2015-08-21 15:11 ` martin rudalics
2015-08-21 15:13 ` Kaushal
2015-08-21 15:16 ` Kaushal
2015-08-21 15:30 ` martin rudalics
2015-08-21 15:33 ` Kaushal
2015-08-21 15:58 ` martin rudalics
2015-08-21 16:00 ` Kaushal
2015-08-24 8:16 ` martin rudalics
2015-08-24 10:46 ` Kaushal Modi
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).