From: Yuri D'Elia <wavexx@thregr.org>
To: 21242@debbugs.gnu.org
Subject: bug#21242: 24.5.1; python.el: should display output buffer on exceptions when using python-shell-send-region
Date: Wed, 12 Aug 2015 16:05:42 +0200 [thread overview]
Message-ID: <55CB52B6.8020308@thregr.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
When evaluating the code interactively, there's currently no
notification about evaluation errors. Exceptions in the output buffer go
simply unnoticed, unless you watch for them closely. I like to keep the
output buffer buried, and assume that no-notification==no-error.
Exceptions caused by interactive evaluation should either:
- show a notification of sorts in the minibuffer
- display the output buffer for inspection
For inspiration about the second, see:
https://github.com/wavexx/python-x.el/blob/master/python-x.el#L424
Given previous experience with python-mode.el (which tends to break the
current window layout with his own splitting logic), I find it important
that the notification function (which displays the output buffer) should
be customizable, and this is reflected in the example code.
[-- Attachment #2: python-buffer-substring.patch --]
[-- Type: text/x-diff, Size: 1471 bytes --]
--- python.el.Orig 2015-07-18 18:00:49.367517569 +0200
+++ python.el 2015-07-18 18:03:01.203659502 +0200
@@ -2548,18 +2548,22 @@
(make-string
;; Subtract 2 because of the coding cookie.
(- (line-number-at-pos start) 2) ?\n))))
- (toplevel-block-p (save-excursion
- (goto-char start)
- (or (zerop (line-number-at-pos start))
- (progn
- (python-util-forward-comment 1)
- (zerop (current-indentation)))))))
+ (block-param (save-excursion
+ (goto-char start)
+ (progn
+ (python-util-forward-comment 1)
+ (list (current-indentation)
+ (/= (point) start)))))
+ (block-indentation (car block-param))
+ (starts-with-indentation-p (cadr block-param)))
(with-temp-buffer
(python-mode)
(if fillstr (insert fillstr))
+ (when (and (> block-indentation 0) (not starts-with-indentation-p))
+ (insert (make-string block-indentation ?\s)))
(insert substring)
(goto-char (point-min))
- (when (not toplevel-block-p)
+ (when (> block-indentation 0)
(insert "if True:")
(delete-region (point) (line-end-position)))
(when nomain
next reply other threads:[~2015-08-12 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 14:05 Yuri D'Elia [this message]
2015-08-13 6:48 ` bug#21242: 24.5.1; python.el: should display output buffer on exceptions when using python-shell-send-region Andreas Röhler
2020-09-17 18:01 ` Lars Ingebrigtsen
2020-09-17 18:44 ` Yuri D'Elia
2020-09-18 11:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB52B6.8020308@thregr.org \
--to=wavexx@thregr.org \
--cc=21242@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).