From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#20890: 25.0.50; build from git crashes on startup Date: Sun, 26 Jul 2015 13:30:41 -0700 Organization: UCLA Computer Science Department Message-ID: <55B54371.4000907@cs.ucla.edu> References: <87vbede71o.fsf@capuchin.co.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050304030405040802080902" X-Trace: ger.gmane.org 1437942683 3351 80.91.229.3 (26 Jul 2015 20:31:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Jul 2015 20:31:23 +0000 (UTC) Cc: 20890@debbugs.gnu.org To: Robert Marshall Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 26 22:31:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZJSZh-0007SU-VP for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 22:31:10 +0200 Original-Received: from localhost ([::1]:50883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJSZh-0004i0-5R for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 16:31:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJSZe-0004hf-0Z for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 16:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJSZa-00044E-AN for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 16:31:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJSZa-00043k-8A for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 16:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZJSZZ-0001AX-Uj for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 16:31:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87vbede71o.fsf@capuchin.co.uk> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jul 2015 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20890-submit@debbugs.gnu.org id=B20890.14379426464469 (code B ref 20890); Sun, 26 Jul 2015 20:31:01 +0000 Original-Received: (at 20890) by debbugs.gnu.org; 26 Jul 2015 20:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:59412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJSZJ-0001A1-Kq for submit@debbugs.gnu.org; Sun, 26 Jul 2015 16:30:45 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36665) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJSZH-00019t-FS for 20890@debbugs.gnu.org; Sun, 26 Jul 2015 16:30:44 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8488D16099B; Sun, 26 Jul 2015 13:30:42 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Tb4IC4SVobKQ; Sun, 26 Jul 2015 13:30:41 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BFA4A160CB6; Sun, 26 Jul 2015 13:30:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Hyy5_XU6pdLH; Sun, 26 Jul 2015 13:30:41 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9D73516099B; Sun, 26 Jul 2015 13:30:41 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105144 Archived-At: This is a multi-part message in MIME format. --------------050304030405040802080902 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the bug report. From the backtrace it appears that ftfont_close's implementation incorrectly assumes that ftfont_close can't be called from the garbage collector. I've installed the attached FIXME comment and am CC'ing Kenichi Handa, who's an expert in ftfont.c. --------------050304030405040802080902 Content-Type: text/x-diff; name="0001-src-ftfont.c-ftfont_close-Add-comment-re-Bug-20890.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-src-ftfont.c-ftfont_close-Add-comment-re-Bug-20890.patc"; filename*1="h" >From bcba2b845e35ebdbaf4d869d1b1a1a065e1c42a3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 26 Jul 2015 13:23:08 -0700 Subject: [PATCH] * src/ftfont.c (ftfont_close): Add comment re Bug#20890. --- src/ftfont.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ftfont.c b/src/ftfont.c index b37b404..41d99df 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -1315,6 +1315,10 @@ ftfont_open (struct frame *f, Lisp_Object entity, int pixel_size) static void ftfont_close (struct font *font) { + /* FIXME: Although this function can be called while garbage-collecting, + the function assumes that Lisp data structures are properly-formed. + This invalid assumption can lead to core dumps (Bug#20890). */ + struct ftfont_info *ftfont_info = (struct ftfont_info *) font; Lisp_Object val, cache; -- 2.1.0 --------------050304030405040802080902--