From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#21020: 24.4; `display-time-world' tampers with TZ Date: Sun, 26 Jul 2015 10:55:38 -0700 Organization: UCLA Computer Science Department Message-ID: <55B51F1A.2000100@cs.ucla.edu> References: <55B487B4.7060709@cs.ucla.edu> <83vbd7yny9.fsf@gnu.org> <55B51362.2010301@cs.ucla.edu> <83lhe2zuu9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1437933381 12379 80.91.229.3 (26 Jul 2015 17:56:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Jul 2015 17:56:21 +0000 (UTC) Cc: 21020@debbugs.gnu.org, wgg2@member.fsf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 26 19:56:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZJQ9i-0008Kl-O9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 19:56:10 +0200 Original-Received: from localhost ([::1]:50638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQ9h-0002Nf-QL for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Jul 2015 13:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQ9d-0002NV-UX for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 13:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJQ9a-0004xt-Os for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 13:56:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJQ9a-0004xp-LC for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZJQ9a-0005u9-EM for bug-gnu-emacs@gnu.org; Sun, 26 Jul 2015 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jul 2015 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21020 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21020-submit@debbugs.gnu.org id=B21020.143793334222672 (code B ref 21020); Sun, 26 Jul 2015 17:56:02 +0000 Original-Received: (at 21020) by debbugs.gnu.org; 26 Jul 2015 17:55:42 +0000 Original-Received: from localhost ([127.0.0.1]:59392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJQ9G-0005tb-2P for submit@debbugs.gnu.org; Sun, 26 Jul 2015 13:55:42 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34453) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJQ9E-0005tT-3e for 21020@debbugs.gnu.org; Sun, 26 Jul 2015 13:55:40 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7837516099B; Sun, 26 Jul 2015 10:55:39 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id qHQWBE5acTxC; Sun, 26 Jul 2015 10:55:38 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C35D0160CB6; Sun, 26 Jul 2015 10:55:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q3-gz_SJQI4q; Sun, 26 Jul 2015 10:55:38 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A178416099B; Sun, 26 Jul 2015 10:55:38 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 In-Reply-To: <83lhe2zuu9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105141 Archived-At: Eli Zaretskii wrote: >> test/automated/icalender-tests.el exercises the new code. > > But the tests there that play with TZ are all expected failures on > MS-Windows, because they use Posix format of time-zone definition that > Windows runtime doesn't support. So that probably means there are no > tests that could be used on Windows. OK, didn't know that. Presumably this could be addressed by adding tests for MS-Windows TZ settings, if somebody has the time for this (pun intended...). >> Also, the MS-Windows port can't entirely skip the time module any >> more, as that module arranges for time.h to declare localtime_rz and >> friends. > > This could conflict with time.h in nt/inc/sys/, no? I don't see why. is a different API. This patch affects only . >lib/time.h seems to want to replace 'localtime', which might > clash with 'sys_localtime' we currently use as replacement on w32. The replacement is conditional, and the condition should be false on w32.