From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#68954: Offending commit Date: Wed, 7 Feb 2024 17:35:44 -0800 Message-ID: <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> References: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4856"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68954@debbugs.gnu.org To: Dominique Quatravaux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 02:37:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXtLc-0000yT-UC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 02:37:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXtLN-0001l6-Rw; Wed, 07 Feb 2024 20:36:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXtLM-0001jM-FS for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 20:36:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXtLM-0006JW-6o for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 20:36:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXtLZ-0000kb-W4 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 20:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 01:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68954-submit@debbugs.gnu.org id=B68954.17073561782829 (code B ref 68954); Thu, 08 Feb 2024 01:37:01 +0000 Original-Received: (at 68954) by debbugs.gnu.org; 8 Feb 2024 01:36:18 +0000 Original-Received: from localhost ([127.0.0.1]:58681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXtKs-0000jZ-3I for submit@debbugs.gnu.org; Wed, 07 Feb 2024 20:36:18 -0500 Original-Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXtKq-0000jJ-31 for 68954@debbugs.gnu.org; Wed, 07 Feb 2024 20:36:17 -0500 Original-Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d932f6ccfaso11646555ad.1 for <68954@debbugs.gnu.org>; Wed, 07 Feb 2024 17:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707356156; x=1707960956; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4iV1x24v/Z9zJUGLkL/pbnPT4tjyaOx57LRe5xTs//M=; b=gyhNYIIa03C68Njt6fqipd81MeKCyz9uW85P/tMeasl3p4PK4+eWiZOWSDsvbL6n+m WhaDpW6Eo/CCzpoHLnsIeV1QbVk6E9gjVxntQsUXhG8ipOTwyZxTOleRAIB8JlSU99vo xbZYBSjWT35hphzEXdzvHhwzjmljdRzxfQr07Vr5Bdc4Kd34p6jFdjSQoJMKgaRDTiZL 9Ty7+xih31cQxus9mgdM/F82Hy7tgWBT+IK9mhSUoDhtY7t+vXjKB/KArGAG0G91f8NX uIIwIG1MmK2O2GkmquU4jSjyQKzypkeeXKGKLTEJWk8ucqMyaOYQ/9wZ2ghyz3XMAm43 zVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707356156; x=1707960956; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4iV1x24v/Z9zJUGLkL/pbnPT4tjyaOx57LRe5xTs//M=; b=KFMCpAXpcWfN/OlcC5DdKonvmL8gtakKyIdH8eu+KyWS86KNCRnkjfxri36i1INh6Z n4HSz6EsmAzJJ/Mh7lOS4lNUGtOo+8bW8nC+5GV7dgwaxDheoeNj9hKk8QqOCLjLsGd7 vHf0wXwPM/waP4TGe1KUxAe5NF2xIr20F7XTAeRw8RcoE+e95IOI7l+DScgELlzuPk8T 2lj9/GDcy0DoVztqDxoIzZiiCU1Ro3nizHf6nBgNXMoYw4sRbcVOa/E5zTYEYC7KyZI1 183Ju+hblIHS17wyVsw9ID/FInVOtTItzPtC/MxYIp3+paytz0vGGZbax+kUKXc6LL0K cPjw== X-Gm-Message-State: AOJu0Ywti3ZX/R8Qjn7f+1jhPhSui3DptEBm5FlF5eANrCZs5BrEcHaf oE7a5cb6FOHcVtiurxWC0uFsWf92a5jdxBJDT/91FS5LsHeowMft X-Google-Smtp-Source: AGHT+IHJXXs2tDj+x+pR42vwNPfs+uC7o+MS/9zT7nWI6U9VnAlnqE5KFJo36iG95ll5LiboV0M/Dg== X-Received: by 2002:a17:903:25d3:b0:1d9:9c67:58f4 with SMTP id jc19-20020a17090325d300b001d99c6758f4mr5677734plb.52.1707356155821; Wed, 07 Feb 2024 17:35:55 -0800 (PST) Original-Received: from smtpclient.apple ([2600:1700:42c1:a5f0:9078:deba:b479:939]) by smtp.gmail.com with ESMTPSA id ko7-20020a17090307c700b001d96a0cddccsm2128021plb.296.2024.02.07.17.35.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2024 17:35:55 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279588 Archived-At: > On Feb 6, 2024, at 11:24 PM, Dominique Quatravaux = wrote: >=20 > Le mer. 7 f=C3=A9vr. 2024 =C3=A0 02:58, Yuan Fu a = =C3=A9crit : >=20 >=20 > Thanks! If you want to submit a patch I=E2=80=99m more than happy to = apply it for you >=20 > I attached a patch to my first email already. My bad, I wasn=E2=80=99t clear enough. I meant a patch generated by git = format-patch, which includes a commit message, etc. This way when I = apply it it=E2=80=99ll show your as the author. If you don=E2=80=99t = care about it, I can apply the diff myself and push it. Btw, there=E2=80=99s a specific format for commit messages, you can = check out the CONTRIBUTE file under repo root, in the =E2=80=9CCommit = messages=E2=80=9D section. Actually, here=E2=80=99s what I would write for your change, feel free = to modify it as you like. Fix treesit_traverse_get_predicate (bug#68954) Commit d005e685e1df7692085378633348db39a5190374 should have replaced assq_no_quit with assq_no_signal, but didn't, this commit fixes that. * src/treesit.c (treesit_traverse_get_predicate): Replace assq_no_quit with assq_no_signal. Yuan=