unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Francis Litterio <flitterio@gmail.com>
Cc: 21132@debbugs.gnu.org
Subject: bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode
Date: Sat, 25 Jul 2015 20:17:39 +0200	[thread overview]
Message-ID: <55B3D2C3.8060007@gmx.at> (raw)
In-Reply-To: <838ua419gg.fsf@gnu.org>

 >> Emacs built from the latest source on Windows crashes when invoked
 >> as follows:
 >>
 >>    emacs.exe -Q -batch --eval="(x-frame-geometry (selected-frame))"
 >
 > Thanks, fixed.

Do you have any simple guideline how to find similar instances of this
bug?  And what is the difference between !FRAME_INITIAL_P (f) and
FRAME_W32_WINDOW (f)?  I suppose that !FRAME_INITIAL_P (f) implies
FRAME_W32_WINDOW (f).  So there are probably cases when we use
FRAME_W32_WINDOW (f) and FRAME_INITIAL_P (f) holds.  Right?

And do we prefer (FRAME_W32_WINDOW (f) != 0) to (!FRAME_W32_WINDOW (f))?
Also I believe that I should replace FRAME_X_WINDOW by FRAME_W32_WINDOW.

 > I believe similar changes are needed in xfns.c and in nsfns.m, could
 > someone with access to the relevant OSes please check and apply?

I'll look into these.

Thanks for the quick fix, martin





  reply	other threads:[~2015-07-25 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25 16:03 bug#21132: 25.0.50; Emacs on Windows crashes evaluating x-frame-geometry in batch mode Francis Litterio
2015-07-25 16:35 ` Eli Zaretskii
2015-07-25 18:17   ` martin rudalics [this message]
2015-07-25 18:53     ` Eli Zaretskii
2015-07-26 11:27       ` martin rudalics
2015-07-26 14:53         ` Eli Zaretskii
2015-07-27 16:02           ` martin rudalics
2015-07-27 16:25             ` Eli Zaretskii
2015-07-27 16:34               ` martin rudalics
2015-07-27 16:59                 ` Eli Zaretskii
2015-08-24  8:17 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B3D2C3.8060007@gmx.at \
    --to=rudalics@gmx.at \
    --cc=21132@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=flitterio@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).