From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#63807: bug in compose-gstring-for-terminal? Date: Wed, 31 May 2023 15:49:23 +0200 Message-ID: <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> References: <83a5xkfyc8.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63807@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 31 15:50:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4MDi-0009Qs-Gz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 May 2023 15:50:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4MDE-0004Z7-Kb; Wed, 31 May 2023 09:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4MDC-0004TJ-SV for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 09:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4MDC-0001ZE-Gc for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4MDC-00013P-6q for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63807 X-GNU-PR-Package: emacs Original-Received: via spool by 63807-submit@debbugs.gnu.org id=B63807.16855409754015 (code B ref 63807); Wed, 31 May 2023 13:50:02 +0000 Original-Received: (at 63807) by debbugs.gnu.org; 31 May 2023 13:49:35 +0000 Original-Received: from localhost ([127.0.0.1]:35162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4MCl-00012h-FQ for submit@debbugs.gnu.org; Wed, 31 May 2023 09:49:35 -0400 Original-Received: from mail-lf1-f46.google.com ([209.85.167.46]:45561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4MCh-00012R-Cp for 63807@debbugs.gnu.org; Wed, 31 May 2023 09:49:33 -0400 Original-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f3b39cea1eso6628788e87.3 for <63807@debbugs.gnu.org>; Wed, 31 May 2023 06:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685540965; x=1688132965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pzCTj2UriqRyFKI7XV6ZP5Esy6Jvv9gzd1CfvdBveG8=; b=Fy29AiX13z3uwcY+NO/f39QRkqn2SZ7nGr9i8xSAEg/spJaSxHi2SPpYP/RfsWNfpq gyexiAfoZJuO66ACLb2s3rs6q3KuuHzRUMkA1vV6lclj1XfwmhC++RTButIIjtJNJvK3 k9MZzqvGkPw3L+MdvZQsqPg5fLVPvZmeFno0VMJXd3sLWQx3hk+x68lo4WNoqPkG0Q2o 2qY4gKz47s2kgP3Xcny0lRpCnFHYmkLJBEkGLZWs8/36P3cNtaY0OaN7iha1kjs61xza jArwuKYlo53MoHoXJhI3pGcc5PG72+rpdeaIkFmglvoFar9KBmOF6blj9wYSikf/yVM6 5gzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685540965; x=1688132965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pzCTj2UriqRyFKI7XV6ZP5Esy6Jvv9gzd1CfvdBveG8=; b=IS7YckyZ0hHPX7cazZeJWHUwM3406kmq9t9dD7OLCCNmxRClHXjqfh0wYkrPiJu4HN +W2vTHuCoiiE8B8eQ5+D575hrDm/N53leaZNKmJOUDR1syQzCb4EIbkt4GD0Wh6QZxZc QB2yVx8yHyfRAz3xhHgYso1YLfNj7HcZrBml9AQ/DlVoHlyuklZE5cnW7BgVqOTMTYgl 9dXQYItWpBD0YbfXlZwX5b0TkbioBokwuh6RXkOg2bnQyyFtw4R/1nbFtG3wteAx4mc5 gBdUb51svawscuVpMmWHHBAC5TZqXAX/Z32sGMTQlP7ONzhYttFd4CQv8844M5lF+KfR Vg8A== X-Gm-Message-State: AC+VfDx6b0gFwmmo/gyFyIi18uHFHoIOw4RMoQDOHVRk2Ku5Q1d5He+s eduXKQVjW9oOR0Rdn1vw/ck= X-Google-Smtp-Source: ACHHUZ5ReYm0IuAGrjsyUnsMEnDwnbfMCCyfSNNBsRBRcRzAhid89bSEt+juZr1X+D5fvvMYB/I4Vw== X-Received: by 2002:a05:6512:3763:b0:4e8:43e2:a8 with SMTP id z3-20020a056512376300b004e843e200a8mr3029413lft.8.1685540965037; Wed, 31 May 2023 06:49:25 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id m8-20020ac24ac8000000b004f11eb32f20sm734366lfp.13.2023.05.31.06.49.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 06:49:24 -0700 (PDT) In-Reply-To: <83a5xkfyc8.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262665 Archived-At: 31 maj 2023 kl. 15.02 skrev Eli Zaretskii : > Setting i to 2 is correct there Would you explain why to someone who doesn't know how this is supposed = to work? There may be external invariants rescuing the mistake from having = serious consequences so that the code is correct in a narrow sense but = relying that is generally poor style. It looks quite obvious that the intent is to increment i by 2; compare = with the other clause, (progn ;; Compose Cf (format) control characters by ;; replacing with a space. (lglyph-set-char glyph 32) (lglyph-set-width glyph 1) (setq i (1+ i))) where a character is replaced with a space and we step to the next. In = the (non-Cf) clause under scrutiny, we insert a space and, presumably, = step past both characters: ;; Compose by prepending a space. (setq gstring (lgstring-insert-glyph gstring i (lglyph-copy glyph)) nglyphs (lgstring-glyph-len gstring)) (setq glyph (lgstring-glyph gstring i)) (lglyph-set-char glyph 32) (lglyph-set-width glyph 1) (setq i (+ 2)) The main question is whether changing the last assignment to (setq i (+ = i 2)) would have unintended consequences. As far as I've been able to = determine, testing and inspection say no, it should be completely safe.