From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Illia Ostapyshyn Newsgroups: gmane.emacs.bugs Subject: bug#48406: 28.0.50; Emacs stuck in infinite loop in wait_reading_process_output when opening in fullscreen (NS) Date: Sat, 5 Jun 2021 18:21:59 +0200 Message-ID: <558D9EDE-D791-49DD-AAB1-56071D6FD56F@gmail.com> References: <5E1B46C6-1359-4CCF-B4EF-5527FB915F93@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_30E1C477-BF68-424E-8BCF-C8DDC29DF881" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17039"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48406@debbugs.gnu.org, Andrii Kolomoiets To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 05 18:23:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpZ4q-0004AN-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 18:23:12 +0200 Original-Received: from localhost ([::1]:52202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpZ4p-0003CP-KQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 12:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpZ4h-00039u-IY for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 12:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpZ4h-0005qI-C3 for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 12:23:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpZ4h-0008R6-7v for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 12:23:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Illia Ostapyshyn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 16:23:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48406 X-GNU-PR-Package: emacs Original-Received: via spool by 48406-submit@debbugs.gnu.org id=B48406.162291013032250 (code B ref 48406); Sat, 05 Jun 2021 16:23:03 +0000 Original-Received: (at 48406) by debbugs.gnu.org; 5 Jun 2021 16:22:10 +0000 Original-Received: from localhost ([127.0.0.1]:49952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpZ3q-0008O5-1z for submit@debbugs.gnu.org; Sat, 05 Jun 2021 12:22:10 -0400 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:38901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpZ3n-0008Nt-S8 for 48406@debbugs.gnu.org; Sat, 05 Jun 2021 12:22:08 -0400 Original-Received: by mail-ej1-f45.google.com with SMTP id og14so13944518ejc.5 for <48406@debbugs.gnu.org>; Sat, 05 Jun 2021 09:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=nnWqqT0x+LEK+9kAvtDt+qGu3q8k/wxS3EETav3P0sI=; b=OnQcAC0/A4/kn832lr07N3PnskOBpyCv2ObJOa3H185rlsxsrVbh3lUWD+ERAbNVtG zjcxa6DIsIhFfEvP5GL4GUJiLIdkgI62SCraVSRlB4ULuEZXghPwBO0NRtYZVOOA2tM+ WlJYeBDL7DTYFdvHZmu0NGtxvREPlad2VH4CHWj2aTXrETFg/ZEs//RXjXolhJqWJUi8 hA8cHsB4wIxDCg2WFEuVMvQmQFSXyJQf4PmglGcMhyZEbaBpD87Ttv8Ul8KULoQI1JQ+ fv2dqG/5OYNZPeMmjXxkg8R5iyLeiY+NHeYku9OdnNa4SjvD0KtFaZJ/GrOj5IyJTQCl Ek4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=nnWqqT0x+LEK+9kAvtDt+qGu3q8k/wxS3EETav3P0sI=; b=kwkhf6NBaHbNmeZniEybqFkJoN+uvOYX8az9f60WFtmoV0zvEbllZP5VANg/E2xWge abSJLaTgkHhSBDInNgn1mJm1BYo0igQdkQymzRU6lUyYyW+UzUBZj264k3H5KfybAEqF 6Ucp+XWsNo94L8Rq3J3zPNI5i1jzfytC+Xr06vmaCgQjG5ZExiUg2oJYiSDpBZs2KwkA lzifmrMynutg0Hw/pvQwagCcZ03LBUA21t23oA9cLed5f3oGtZc5g/Ex53cEfaNEYoYC 5PquB8Y7zoj1abbEj2T139E7gkJrNxJYGHgZamY/hl/gn4myeiyRQrU/XcuGf/Ecqnwk bk2w== X-Gm-Message-State: AOAM533tSZjhZf1aeEPMeQo2cCb8TOyU0gsYdSTngq6kU5gOpHiRSSer 9c9HVewclsmwZWOK8mFheb8= X-Google-Smtp-Source: ABdhPJyFy1hmtFDUGwsjoq2unI9FnzVZ3O/mHR9H0YQihowLQsqmi5CI4nz9kdHX0vwJDNRF4R/VLg== X-Received: by 2002:a17:906:5407:: with SMTP id q7mr10102117ejo.158.1622910122116; Sat, 05 Jun 2021 09:22:02 -0700 (PDT) Original-Received: from smtpclient.apple (ip185182.wh.uni-hannover.de. [130.75.185.182]) by smtp.gmail.com with ESMTPSA id r12sm4995156edv.82.2021.06.05.09.22.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jun 2021 09:22:01 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.100.0.2.22) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208065 Archived-At: --Apple-Mail=_30E1C477-BF68-424E-8BCF-C8DDC29DF881 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 5, 2021, at 15:45, Alan Third wrote: >=20 > Patch attached. >=20 > I think this is probably pretty safe, but I'll leave it a couple of > days in case someone finds a problem with it. > --=20 > Alan Third > <0001-Remove-pause-on-fullscreening-in-NS-bug-48406.patch> Hello Alan, thank you for working on this. I am going to apply this patch and report = any possible issues with it. I commented out that problematic pause for = fullscreen transition myself just after starting this thread and didn=E2=80=99t = encounter any issues so far. By the way, there seems to be a compilation issue as not all references = to in_fullscreen_transition were removed (see attachment). --Apple-Mail=_30E1C477-BF68-424E-8BCF-C8DDC29DF881 Content-Disposition: attachment; filename=0001-remove-in_fullscreen_transition-references.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-remove-in_fullscreen_transition-references.patch" Content-Transfer-Encoding: quoted-printable =46rom=202706fd2eeea6590e3860a62d44dd3dd107341319=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Illia=20Ostapyshyn=20= =0ADate:=20Sat,=205=20Jun=202021=2018:06:41=20= +0200=0ASubject:=20[PATCH]=20remove=20in_fullscreen_transition=20= references=0A=0A---=0A=20src/nsterm.m=20|=205=20-----=0A=201=20file=20= changed,=205=20deletions(-)=0A=0Adiff=20--git=20a/src/nsterm.m=20= b/src/nsterm.m=0Aindex=201503f5e2fb..838c14d5ab=20100644=0A---=20= a/src/nsterm.m=0A+++=20b/src/nsterm.m=0A@@=20-7483,7=20+7483,6=20@@=20-=20= (instancetype)=20initFrameFromEmacs:=20(struct=20frame=20*)f=0A=20#endif=0A= =20=20=20=20=20fs_is_native=20=3D=20ns_use_native_fullscreen;=0A=20= #endif=0A-=20=20in_fullscreen_transition=20=3D=20NO;=0A=20=0A=20=20=20= maximized_width=20=3D=20maximized_height=20=3D=20-1;=0A=20=20=20= nonfs_window=20=3D=20nil;=0A@@=20-7856,7=20+7855,6=20@@=20-=20= (NSApplicationPresentationOptions)window:(NSWindow=20*)window=0A=20-=20= (void)windowWillEnterFullScreen:(NSNotification=20*)notification=0A=20{=0A= =20=20=20NSTRACE=20("[EmacsView=20windowWillEnterFullScreen:]");=0A-=20=20= in_fullscreen_transition=20=3D=20YES;=0A=20=20=20[self=20= windowWillEnterFullScreen];=0A=20}=0A=20-=20= (void)windowWillEnterFullScreen=20/*=20provided=20for=20direct=20calls=20= */=0A@@=20-7869,7=20+7867,6=20@@=20-=20= (void)windowDidEnterFullScreen:(NSNotification=20*)notification=0A=20{=0A= =20=20=20NSTRACE=20("[EmacsView=20windowDidEnterFullScreen:]");=0A=20=20=20= [self=20windowDidEnterFullScreen];=0A-=20=20in_fullscreen_transition=20=3D= =20NO;=0A=20}=0A=20=0A=20-=20(void)windowDidEnterFullScreen=20/*=20= provided=20for=20direct=20calls=20*/=0A@@=20-7908,7=20+7905,6=20@@=20-=20= (void)windowDidEnterFullScreen=20/*=20provided=20for=20direct=20calls=20= */=0A=20-=20(void)windowWillExitFullScreen:(NSNotification=20= *)notification=0A=20{=0A=20=20=20NSTRACE=20("[EmacsView=20= windowWillExitFullScreen:]");=0A-=20=20in_fullscreen_transition=20=3D=20= YES;=0A=20=20=20[self=20windowWillExitFullScreen];=0A=20}=0A=20=0A@@=20= -7928,7=20+7924,6=20@@=20-=20= (void)windowDidExitFullScreen:(NSNotification=20*)notification=0A=20{=0A=20= =20=20NSTRACE=20("[EmacsView=20windowDidExitFullScreen:]");=0A=20=20=20= [self=20windowDidExitFullScreen];=0A-=20=20in_fullscreen_transition=20=3D=20= NO;=0A=20}=0A=20=0A=20-=20(void)windowDidExitFullScreen=20/*=20provided=20= for=20direct=20calls=20*/=0A--=20=0A2.31.1=0A=0A= --Apple-Mail=_30E1C477-BF68-424E-8BCF-C8DDC29DF881--