From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20847: [display engine] 25.0.50; company-mode popup makes point jump to an entirely different location Date: Tue, 23 Jun 2015 00:06:06 +0300 Message-ID: <558878BE.3000709@yandex.ru> References: <868ubgld8y.fsf@yandex.ru> <83mvzvjz3w.fsf@gnu.org> <83wpyyiond.fsf@gnu.org> <5586C2A8.1020904@yandex.ru> <83h9q1hv0t.fsf@gnu.org> <5586FD0F.8090300@yandex.ru> <83d20oj4wo.fsf@gnu.org> <5587185A.306@yandex.ru> <83616gihqd.fsf@gnu.org> <55881053.3080604@yandex.ru> <83oak7hfq6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1435007244 2382 80.91.229.3 (22 Jun 2015 21:07:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Jun 2015 21:07:24 +0000 (UTC) Cc: 20847@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 22 23:07:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z78vx-0000bM-10 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jun 2015 23:07:13 +0200 Original-Received: from localhost ([::1]:42007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z78vw-0007pP-8a for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jun 2015 17:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z78vr-0007pG-LK for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 17:07:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z78vm-0004uh-KT for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 17:07:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z78vm-0004uC-GT for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 17:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z78vm-0007CD-4F for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20847-submit@debbugs.gnu.org id=B20847.143500717727606 (code B ref 20847); Mon, 22 Jun 2015 21:07:02 +0000 Original-Received: (at 20847) by debbugs.gnu.org; 22 Jun 2015 21:06:17 +0000 Original-Received: from localhost ([127.0.0.1]:54727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z78v2-0007B9-2N for submit@debbugs.gnu.org; Mon, 22 Jun 2015 17:06:16 -0400 Original-Received: from mail-wi0-f177.google.com ([209.85.212.177]:36266) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z78uz-0007Au-SN for 20847@debbugs.gnu.org; Mon, 22 Jun 2015 17:06:14 -0400 Original-Received: by wicnd19 with SMTP id nd19so88260484wic.1 for <20847@debbugs.gnu.org>; Mon, 22 Jun 2015 14:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=y2SV+1xQ9GQxwcOrM8+gjHVZ6C7P/BUU8+UJpkHzURw=; b=Ijd22XegMBdxWYMfUuotxG32SVO4oY3HCE9a11PaO0QVV/0dFQK5CMe5GdqcVWziNI ruvNgzY1aKcez3GS4OybS5Vcym5o3+oQwUseZR6zsfaMan82q4WQjtG3/5fDLqz4Pt3z 8WTlIV5iwVeV+4Q+7NtYHWzD6PwT0eU/UjgwZBBnF0idQiFnJfZrHt26ild63eZWpA+3 nuzWw6ifh5GwyjyKLCwuEiGTens/k+qmyVJzwom5Guw92Kn5WGoMlJ/qksosCrpfuia/ wPnb4kqdkESrna98Y4aHSIwjqaS1C1fz5VPvknyUVE3ybq8W/Xm/qC6jv6WV/Uc58kY3 MS2A== X-Received: by 10.180.77.68 with SMTP id q4mr35157022wiw.22.1435007168327; Mon, 22 Jun 2015 14:06:08 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id q4sm32340005wja.24.2015.06.22.14.06.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 14:06:08 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 In-Reply-To: <83oak7hfq6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104237 Archived-At: On 06/22/2015 07:26 PM, Eli Zaretskii wrote: >> This doesn't seem to have any effect, though. Adding >> >> (when (eq ?\n (char-after (overlay-start ov))) >> (let ((inhibit-modification-hooks t)) >> (put-text-property (overlay-start ov) (1+ (overlay-start ov)) >> 'cursor t))) >> >> to the end of company-pseudo-tooltip-unhide creates no change in the >> behavior. > > That's because I have yet to write the code to support that ;-) I'm not sure I like that idea. If I have to write a workaround (this definitely feels like it), I'd rather write a workaround that will work in the current Emacs releases too. (If I manage to, of course). And supporting `cursor' on buffer text newline but not on overlay display string newline feels like adding a yet-another edge case. > Will do next; meanwhile, could you perhaps send the above as diffs > relatively to whatever version of company.el you want me to test this > with? TIA. Maybe after I exhaust the other approaches. Going back to your earlier message, I'm actually not sure I agree with this: > Any scenario where a screen line ends in a newline that comes from an > overlay string [performs better under the current behavior]. Try > several such scenarios, and then tell me whether > the place we display the cursor looks better than the alternative. The current example shows that it's better to display the cursor on the margin, rather than after the overlay. What are the examples where this is not true? Are those cases where the said newline is not at the beginning of the overlay? Even if cursor would look weird in some case, at least point is not forcibly moved to a different position.