From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#20802: Segfault when showing non-GTK+ tooltip Date: Thu, 18 Jun 2015 18:48:29 +0200 Message-ID: <5582F65D.2020204@gmx.at> References: <1434187118.10061.4.camel@gmx.de> <83381wq76d.fsf@gnu.org> <557C0526.5050607@gmx.at> <831thfri91.fsf@gnu.org> <557C2EF2.5030308@gmx.at> <83vberpv07.fsf@gnu.org> <557C3E1F.6030305@gmx.at> <83twubpt43.fsf@gnu.org> <557D5EE9.7070902@gmx.at> <83h9qapee0.fsf@gnu.org> <55813F99.8070801@gmx.at> <83bngemgqv.fsf@gnu.org> <5582C990.5020009@gmx.at> <83bngdko70.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1434646178 14106 80.91.229.3 (18 Jun 2015 16:49:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Jun 2015 16:49:38 +0000 (UTC) Cc: tobias.getzner@gmx.de, 20802@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 18 18:49:27 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5d08-0003Gv-3s for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jun 2015 18:49:16 +0200 Original-Received: from localhost ([::1]:53950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5d07-0007u0-FF for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jun 2015 12:49:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5d00-0007q2-FM for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 12:49:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5czu-00032d-Rd for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 12:49:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5czu-00032W-OD for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z5czu-0002ID-6I for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2015 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20802-submit@debbugs.gnu.org id=B20802.14346461288793 (code B ref 20802); Thu, 18 Jun 2015 16:49:02 +0000 Original-Received: (at 20802) by debbugs.gnu.org; 18 Jun 2015 16:48:48 +0000 Original-Received: from localhost ([127.0.0.1]:51252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5cze-0002Hk-OR for submit@debbugs.gnu.org; Thu, 18 Jun 2015 12:48:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:54013) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5czb-0002HV-M6 for 20802@debbugs.gnu.org; Thu, 18 Jun 2015 12:48:44 -0400 Original-Received: from [194.166.85.204] ([194.166.85.204]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LkPBT-1YYE3C1Fox-00cTNX; Thu, 18 Jun 2015 18:48:37 +0200 In-Reply-To: <83bngdko70.fsf@gnu.org> X-Provags-ID: V03:K0:c+mAmz0teZk0XwJU+KX4BslQ5PPJZaowqogL3kG5y7V2oehn29U mavK58LmGvqq41u7fzflNF0NGzLrp+aKDFXeH/fcvWXyUvo/dLsL5gxsgLuCO35f6RSuXzG IzCasAkA6eWqSZhh7jQX0B2xQtafuDJSfu5q7ZlQUiqcz7VpjKw4+L+6FjiEcbwOcUIEmGx r44f/CNWH5mV77QsKpiPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xBgJSU9NFk4=:gFJXnfmyIS5etidENk79Qu 4ylkHn40ODTPsiFBwxKH7F6OvuXZM0eeO4URMovEL6cntRyDmE5Pxqih9/8AKNXMZ+JcZFtjU Yq9Bf/T+aoh0Jys21VK6IOszoUvhPLr+pOYsR+RzVZVQkfVY3kVC5cAIZFaa0zL5gPsgBdVpt LT4Nbd9eh+aA1IM4DouowMAt5HItgsBp2PiQ1lNk0iXLI3kmXouVXRk4gV8rQ58KYwPZ4XsY0 0UvExcPMgGWi68+7YEKBS5etVkQKu0BWGxkseL22fpnVxgbCvNQLYr7oC6jSKsAysv2N4C+oB f2llwgjQM1jGF9BOK6En0FAbD8DmZBTRIIdLDO2Q9ELqOjLJym39kWXHOepNtzpjkEsYpdqAj WyK0qImVId1WhvQef0j9eQnELJ8Djj1mc29ABbuOZkta7qEpQyoO46hv8P7tAaeQZQanGPdW0 1AdMy9mATvKp8X4NlIfY2wrDKacCGXreSakMd0+NqJ9B9OfSc/WNa0OlRbGe565tVD4p7M7Xz uSO9WGyuALEbz9rmnLD04vLfwDmDJfvxOMeQefxcYTB0EG4lHcPhV7J9LcEXssNuTZrkc1f/T h0JpL9WsCqQIllZanech7c38epYpSyFY4D3DBJN35oAJJJmCtyHKCAf25Lfb5brXOMrKuwavb gcnlweX8FSZBlmje9neSWZtY3jxnf9E1lnmHGkM5poV4+1aKkgTn/DkKdC18CriNzn0w= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104101 Archived-At: > Do you agree that there's no need to decide whether we should free the > image cache while deleting a frame, and instead do that when we delete > a terminal? If you agree, we should move the code that frees the > image cache there. I do agree. > If, in addition, you are saying that we will sometimes delete a > terminal when it still has live frames, frame.c has this very cryptic /* FIXME: Deleting the terminal crashes emacs because of a GTK bug. http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00363.html */ I doubt it's a Gtk bug. It certainly is related to refcounts. > then we could simply count the > frames on a terminal instead of using a refcount. Something like this > (we already have similar code in delete_frame): > > count = 0; > FOR_EACH_FRAME (tail, frame1) > if (FRAME_TERMINAL (XFRAME (frame)) == FRAME_TERMINAL (XFRAME (frame1))) > count++; Something like that. In any case we should get rid of _all_ refcounts for frames and displays. If you came up with a patch for Windows I could do the remaining platforms (I'm not very eager doing this from scratch since I build without image support and there might be some wrinkle where testing with image support would be safer). martin