unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Michael Heerdegen <michael_heerdegen@web.de>,
	Juanma Barranquero <lekktu@gmail.com>
Cc: 14926@debbugs.gnu.org
Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"
Date: Fri, 16 Aug 2013 07:07:16 -0700 (PDT)	[thread overview]
Message-ID: <55709e09-4565-4ef0-8b53-89842e358c95@default> (raw)
In-Reply-To: <878v017uyy.fsf@web.de>

> > FWIW, looking at the change I've had the same reaction as Drew.
> 
> Well, it was the best short formulation that came to my mind.
...
> The "shortish" part is the problem.

Is this short enough and clear enough?

 "Consider using `make-local-variable' instead"

The context (line #) should make it clear what the "instead" refers to.

This way we're just drawing the user's attention to the possibility
that it might be more appropriate to use `make-local-variable' in that
context.  It's up to the user to check what that means, by checking the
doc.

If we could include a reference to the manual that would be even better.
The node is (elisp) `Creating Buffer-Local'.  If a link is not possible
then perhaps just add text.  Is this too long (dunno)?

 "Consider using `make-local-variable' instead [(elisp) Creating Buffer-Local]

(Yes, links or textual references from product to doc can mean more
maintenance, unless they can be updated automatically.  But they can
help users.)





  reply	other threads:[~2013-08-16 14:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 21:11 bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Drew Adams
2013-07-22  2:59 ` Stefan Monnier
2013-07-22  4:31   ` Drew Adams
2013-08-15 14:43   ` Michael Heerdegen
2013-08-15 16:33     ` Stefan Monnier
2013-08-15 18:19       ` Michael Heerdegen
2013-08-16  6:54       ` Glenn Morris
2013-08-16  7:34         ` Drew Adams
2013-08-16  7:45         ` Juanma Barranquero
2013-08-16 11:09           ` Michael Heerdegen
2013-08-16 14:07             ` Drew Adams [this message]
2013-08-16 21:23               ` Michael Heerdegen
2013-08-16 22:14                 ` Drew Adams
2013-08-16 16:25           ` Stefan Monnier
2013-08-16 16:31             ` Juanma Barranquero
2013-08-16 17:58             ` Drew Adams
2013-08-16 18:01             ` Glenn Morris
2013-08-16 21:26               ` Michael Heerdegen
2013-08-16 21:40                 ` Glenn Morris
2013-08-16 23:02                   ` Michael Heerdegen
2014-02-08  5:28           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55709e09-4565-4ef0-8b53-89842e358c95@default \
    --to=drew.adams@oracle.com \
    --cc=14926@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).