unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Angelo Graziosi <angelo.graziosi@alice.it>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>,
	Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 20677@debbugs.gnu.org
Subject: bug#20677: tooltips generate garbage
Date: Wed, 03 Jun 2015 15:51:49 +0200	[thread overview]
Message-ID: <556F0675.5070409@alice.it> (raw)
In-Reply-To: <wl3829ff7z.wl%mituharu@math.s.chiba-u.ac.jp>



Il 03/06/2015 09:01, YAMAMOTO Mitsuharu ha scritto:
>>>>>> On Tue, 02 Jun 2015 22:08:59 +0300, Eli Zaretskii <eliz@gnu.org> said:
>
>>>> Can you see whether Emacs gets an expose event when the tip pops down?
>>>
>>> Sorry, you've found my limit in understanding.  How can check that?
>
>> The function expose_frame (defined in xdisp.c) should be called when
>> such an event comes in.
>
> Could those who see this problem try the following patches, one at a
> time?

Here (GNU/Linux Mint 17.1 Mate 64bit) both patches seem to work fine!

  Ciao,
    Angelo.

>
> [FIRST]
> diff --git a/src/xterm.c b/src/xterm.c
> index 25c0d87..691ede5 100644
> --- a/src/xterm.c
> +++ b/src/xterm.c
> @@ -7668,7 +7668,7 @@ handle_one_xevent (struct x_display_info *dpyinfo,
>               }
>             else
>   	    {
> -#if defined (USE_GTK) && ! defined (HAVE_GTK3) && ! defined (USE_CAIRO)
> +#ifdef USE_GTK
>   	      /* This seems to be needed for GTK 2.6 and later, see
>   		 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15398.  */
>   	      x_clear_area (f,
>
>
> [SECOND]
> diff --git a/src/xterm.c b/src/xterm.c
> index 25c0d87..32d4d3a 100644
> --- a/src/xterm.c
> +++ b/src/xterm.c
> @@ -7668,12 +7668,14 @@ handle_one_xevent (struct x_display_info *dpyinfo,
>               }
>             else
>   	    {
> -#if defined (USE_GTK) && ! defined (HAVE_GTK3) && ! defined (USE_CAIRO)
> +#ifdef USE_GTK
>   	      /* This seems to be needed for GTK 2.6 and later, see
>   		 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15398.  */
> -	      x_clear_area (f,
> -			    event->xexpose.x, event->xexpose.y,
> -			    event->xexpose.width, event->xexpose.height);
> +	      x_clear_area1 (event->xexpose.display,
> +			     event->xexpose.window,
> +			     event->xexpose.x, event->xexpose.y,
> +			     event->xexpose.width, event->xexpose.height,
> +			     False);
>   #endif
>   	      expose_frame (f, event->xexpose.x, event->xexpose.y,
>   			    event->xexpose.width, event->xexpose.height);
>





  reply	other threads:[~2015-06-03 13:51 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 21:40 bug#20677: tooltips generate garbage Angelo Graziosi
2015-05-28  2:43 ` Eli Zaretskii
2015-06-01 11:46   ` Angelo Graziosi
2015-06-01 14:36     ` Eli Zaretskii
2015-06-01 15:58       ` Angelo Graziosi
2015-06-01 16:19         ` Eli Zaretskii
2015-06-01 21:55           ` Angelo Graziosi
2015-06-02  2:33             ` Eli Zaretskii
2015-06-02  9:23               ` Angelo Graziosi
2015-06-02  9:35                 ` Angelo Graziosi
2015-06-02 14:57                   ` Eli Zaretskii
2015-06-02 15:31                     ` Michael Heerdegen
2015-06-02 15:39                       ` Michael Heerdegen
2015-06-02 15:54                         ` Michael Heerdegen
2015-06-02 16:16                           ` Eli Zaretskii
2015-06-02 16:33                             ` Michael Heerdegen
2015-06-02 19:08                               ` Eli Zaretskii
2015-06-03  7:01                                 ` YAMAMOTO Mitsuharu
2015-06-03 13:51                                   ` Angelo Graziosi [this message]
2015-06-03 16:10                                 ` Michael Heerdegen
2015-06-03 16:43                                   ` Eli Zaretskii
2015-06-03 17:02                                     ` Michael Heerdegen
2015-06-03 19:14                                       ` Eli Zaretskii
2015-06-04  5:25                                         ` YAMAMOTO Mitsuharu
2015-06-04 15:37                                           ` Eli Zaretskii
2015-06-05  0:50                                             ` YAMAMOTO Mitsuharu
2015-06-05  7:04                                               ` Eli Zaretskii
2015-06-02 17:06                             ` Michael Heerdegen
2015-06-02 17:08                             ` Wolfgang Jenkner
2015-06-02 16:02                       ` Eli Zaretskii
2015-06-02 16:14                         ` Michael Heerdegen
2015-06-02 17:04                         ` Angelo Graziosi
2015-06-02 18:56                           ` Eli Zaretskii
2015-06-02  0:31         ` Wolfgang Jenkner
2015-06-02  9:21           ` Angelo Graziosi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556F0675.5070409@alice.it \
    --to=angelo.graziosi@alice.it \
    --cc=20677@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=mituharu@math.s.chiba-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).