From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20629: 25.0.50; Regression: TAGS broken, can't find anything in C++ files. Date: Tue, 26 May 2015 22:00:23 +0300 Message-ID: <5564C2C7.5050909@yandex.ru> References: <555EC552.5010600@swipnet.se> <55606A8F.1020109@swipnet.se> <55606CC7.3010401@yandex.ru> <55606F70.10605@swipnet.se> <83twv31jzg.fsf@gnu.org> <83pp5r1hdx.fsf@gnu.org> <83mw0v1e5n.fsf@gnu.org> <83lhgczo16.fsf@gnu.org> <55639175.9090005@yandex.ru> <83fv6kysjf.fsf@gnu.org> <556447EF.3050103@yandex.ru> <83bnh7z8c5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1432666882 4895 80.91.229.3 (26 May 2015 19:01:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2015 19:01:22 +0000 (UTC) Cc: 20629@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 26 21:01:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YxK6B-0006TF-Cl for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2015 21:01:11 +0200 Original-Received: from localhost ([::1]:49901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxK6A-0004oR-Ub for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2015 15:01:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxK67-0004oM-Gm for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 15:01:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxK64-00059T-92 for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 15:01:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxK64-00059G-5E for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 15:01:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YxK63-0000GX-Hc for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 15:01:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 May 2015 19:01:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20629 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20629-submit@debbugs.gnu.org id=B20629.1432666834924 (code B ref 20629); Tue, 26 May 2015 19:01:03 +0000 Original-Received: (at 20629) by debbugs.gnu.org; 26 May 2015 19:00:34 +0000 Original-Received: from localhost ([127.0.0.1]:57398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxK5Z-0000Ep-TU for submit@debbugs.gnu.org; Tue, 26 May 2015 15:00:34 -0400 Original-Received: from mail-wi0-f181.google.com ([209.85.212.181]:34184) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxK5X-0000EZ-Cf for 20629@debbugs.gnu.org; Tue, 26 May 2015 15:00:32 -0400 Original-Received: by wicmc15 with SMTP id mc15so73655358wic.1 for <20629@debbugs.gnu.org>; Tue, 26 May 2015 12:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Apko0Fp0R2Jqrk5c9zS9eUnzONwXU+AGxkm9A+RI+qo=; b=twIQMub69HqKyfHyznd/HTTFVG90k/r7atOGHXWA7powJtrf4rtAqXTxNFNgA6lmf7 8qpfnQK9IwT++sV/IUNBWdtOItkVr1rUgOGZAJVp6JO8utT+JQK9MHDnqkZlGC2CSHKX pQgftCTTVFUBnb81jDJVvUbeV7XlmIzFWgYEYA4Ii6dvXsAcKeR8iqndsECw+jROvHuO FxHnADNMMmCk4nVtcrFoueswUrsvxPU2ObMMzxTVJsRfPfUDNsRlBR/T/OiH7/QKf5if m9VOAenJZH870ZNhkSAuG8N8QnTH/SJhbAXGJWU35ujcv0dYzgDprivgPv0Nnz8A4AiD rY5A== X-Received: by 10.180.102.74 with SMTP id fm10mr35848660wib.25.1432666825299; Tue, 26 May 2015 12:00:25 -0700 (PDT) Original-Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id ew10sm18210233wic.22.2015.05.26.12.00.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 12:00:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 In-Reply-To: <83bnh7z8c5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103192 Archived-At: On 05/26/2015 06:06 PM, Eli Zaretskii wrote: > That'd mean either some very invasive change in the insane state > machine that runs C_entries, or, more likely, throwing it away and > re-writing it in a very different way. I don't volunteer. What if we only make that change in tag-implicit-name-match-p, then? But the concern about false positives still applies. > Yes, I thought about this as well. I think this is our best bet, and > shouldn't be too hard, as we already do similar things elsewhere. Example? > Patches from completion experts are welcome. Not an expert, but this should do it. I wonder if we'll get many junk completions this way, in certain situations: diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index 9ff164e..f026560 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -1276,13 +1276,16 @@ buffer-local values of tags table format variables." \\([-a-zA-Z0-9_+*$?:]+\\)[^-a-zA-Z0-9_+*$?:\177]*\\)\177\ \\(\\([^\n\001]+\\)\001\\)?\\([0-9]+\\)?,\\([0-9]+\\)?\n" nil t) - (intern (prog1 (if (match-beginning 5) - ;; There is an explicit tag name. - (buffer-substring (match-beginning 5) (match-end 5)) - ;; No explicit tag name. Best guess. - (buffer-substring (match-beginning 3) (match-end 3))) - (progress-reporter-update progress-reporter (point))) - table))) + ;; Implicit tag name. + (intern + (buffer-substring (match-beginning 3) (match-end 3)) + table) + (when (match-beginning 5) + (intern + ;; There is an explicit tag name. + (buffer-substring (match-beginning 5) (match-end 5)) + table)) + (progress-reporter-update progress-reporter (point)))) table)) (defun etags-snarf-tag (&optional use-explicit) ; Doc string?