unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors
@ 2015-05-12 14:04 Paul Pogonyshev
  2015-05-16 14:15 ` Dmitry Gutov
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Pogonyshev @ 2015-05-12 14:04 UTC (permalink / raw)
  To: 20556

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Trivial patch follows. Might be not generic enough, but certainly an
improvement in my case.

Paul

--- /tmp/olBiri_compile.el    2015-05-12 16:02:38.958969722 +0200
+++ lisp/progmodes/compile.el    2015-05-12 16:02:36.838967609 +0200
@@ -216,7 +216,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?
     ;; due to matching filenames via \\(.*?\\).  This might be faster.
     (maven
      ;; Maven is a popular free software build tool for Java.
-     "\\([^ \n]\\(?:[^\n :]\\| [^-/\n]\\|:[^
\n]\\)*?\\):\\[\\([0-9]+\\),\\([0-9]+\\)\\] " 1 2 3)
+     "\\(\\[WARNING\\] *\\)?\\([^ \n]\\(?:[^\n :]\\| [^-/\n]\\|:[^
\n]\\)*?\\):\\[\\([0-9]+\\),\\([0-9]+\\)\\] " 2 3 4 (1))

     (jikes-line
      "^ *\\([0-9]+\\)\\.[ \t]+.*\n +\\(<-*>\n\\*\\*\\*
\\(?:Error\\|Warnin\\(g\\)\\)\\)"

[-- Attachment #2: Type: text/html, Size: 970 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors
  2015-05-12 14:04 bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors Paul Pogonyshev
@ 2015-05-16 14:15 ` Dmitry Gutov
  2015-05-18  7:25   ` Paul Pogonyshev
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2015-05-16 14:15 UTC (permalink / raw)
  To: Paul Pogonyshev, 20556

Hi!

On 05/12/2015 05:04 PM, Paul Pogonyshev wrote:
> Trivial patch follows. Might be not generic enough, but certainly an
> improvement in my case.

Do you have an example of relevant Maven output?

A patch adding a case to test/automated/compile-tests.el would be ideal.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors
  2015-05-16 14:15 ` Dmitry Gutov
@ 2015-05-18  7:25   ` Paul Pogonyshev
  2015-05-18 21:04     ` Dmitry Gutov
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Pogonyshev @ 2015-05-18  7:25 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 20556

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

This is an excerpt of Maven 3.1 output on a project, where I artificially
added some errors to the source code:

[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ test ---
[INFO] Compiling 2 source files to /home/test/test/target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] /home/test/test/src/main/java/foo/bar/Test.java:[27,43] unchecked
conversion
  required: java.util.Collection<java.lang.Object>
  found:    java.util.ArrayList
[INFO] 1 warning
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/test/test/src/main/java/foo/bar/Test.java:[28,9] cannot find
symbol
  symbol:   method test()
  location: class foo.bar.Test

[-- Attachment #2: Type: text/html, Size: 1100 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors
  2015-05-18  7:25   ` Paul Pogonyshev
@ 2015-05-18 21:04     ` Dmitry Gutov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2015-05-18 21:04 UTC (permalink / raw)
  To: Paul Pogonyshev; +Cc: 20556-done

On 05/18/2015 10:25 AM, Paul Pogonyshev wrote:
> This is an excerpt of Maven 3.1 output on a project, where I
> artificially added some errors to the source code:

Thanks. I've pushed your patch.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-05-18 21:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-12 14:04 bug#20556: [PATCH] compilation mode highlights Maven compilation warnings as errors Paul Pogonyshev
2015-05-16 14:15 ` Dmitry Gutov
2015-05-18  7:25   ` Paul Pogonyshev
2015-05-18 21:04     ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).