From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#20472: 24.4; Cannot switch buffers in a dedicated window - report this error earlier Date: Thu, 30 Apr 2015 18:30:00 +0200 Message-ID: <55425888.6080106@gmx.at> References: <7E039918541B4C4183BFDB8F015C743032E18D99@WCL-EXCH02.wcl.local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1430411487 31319 80.91.229.3 (30 Apr 2015 16:31:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Apr 2015 16:31:27 +0000 (UTC) To: Ed Avis , 20472@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 30 18:31:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YnrMn-0007Mf-RN for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Apr 2015 18:31:13 +0200 Original-Received: from localhost ([::1]:44934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnrMn-00084F-8m for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Apr 2015 12:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnrMg-00081L-Tx for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2015 12:31:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnrMd-0000mM-Ns for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2015 12:31:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnrMd-0000mA-KV for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2015 12:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YnrMd-0004JL-5B for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2015 12:31:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Apr 2015 16:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20472-submit@debbugs.gnu.org id=B20472.143041142016505 (code B ref 20472); Thu, 30 Apr 2015 16:31:03 +0000 Original-Received: (at 20472) by debbugs.gnu.org; 30 Apr 2015 16:30:20 +0000 Original-Received: from localhost ([127.0.0.1]:57754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnrLu-0004Hb-95 for submit@debbugs.gnu.org; Thu, 30 Apr 2015 12:30:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:52799) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YnrLp-0004HD-Er for 20472@debbugs.gnu.org; Thu, 30 Apr 2015 12:30:15 -0400 Original-Received: from [62.46.213.218] ([62.46.213.218]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lee2I-1Zd9sW2Ql4-00qOra; Thu, 30 Apr 2015 18:30:06 +0200 In-Reply-To: <7E039918541B4C4183BFDB8F015C743032E18D99@WCL-EXCH02.wcl.local> X-Provags-ID: V03:K0:Fl+wdslimCr9MidxqqcsTEGJ67KrJ+qXg1dPRH0q9ADRMPSGEWJ 6bdmWyTNkj+sISb2DeFcVnJbexVQ/PulvAbv/gcFtJZRy1tudNJ4voGlk3uYzuTxpu9Rz7M LrFes0f8a23l541NKZfnS8rT6gCA2xuZQrTLZWbFq6wxq1XaeAPwAo8B27cJoLSPpU1Br+E vhZva4X9B2/imjvG3S7KA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102297 Archived-At: > Sometimes Emacs creates a small window such as *log-edit-files*. > If you go to that window and do C-x b, you enter the name of the buffer > to switch to as usual, but then see the error > > Cannot switch buffers in a dedicated window > > This error message should appear earlier, as soon as C-x b is given. > Emacs should not ask you to type in the new buffer name before it tells > you that switching buffers is not allowed. Indeed. Unless someone has a better idea I'll install something like the below. martin --- a/lisp/window.el +++ b/lisp/window.el @@ -6916,7 +6916,13 @@ window. Return the buffer switched to." (interactive - (list (read-buffer-to-switch "Switch to buffer: ") nil 'force-same-window)) + (cond + ((eq (window-dedicated-p) t) + (user-error "Cannot switch buffers in a dedicated window")) + ((window-minibuffer-p) + (user-error "Cannot switch buffers in minibuffer window")) + (t + (list (read-buffer-to-switch "Switch to buffer: ") nil 'force-same-window)))) (let ((buffer (window-normalize-buffer-to-switch-to buffer-or-name))) (cond ;; Don't call set-window-buffer if it's not needed since it