unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Artur Malabarba <bruce.connor.am@gmail.com>
Cc: 20445@debbugs.gnu.org
Subject: bug#20445: excessive redisplay / echo area resizing during	byte-compilation
Date: Wed, 29 Apr 2015 09:11:33 +0200	[thread overview]
Message-ID: <55408425.5020409@gmx.at> (raw)
In-Reply-To: <jwvr3r3mxpu.fsf-monnier+emacsbugs@gnu.org>

 > This is the problem: in order to "not emit a message" this code emits
 > the message and then immediately hides it by emitting "the empty
 > message" on top of it.
 >
 > Since `message' redisplays right away (rather than waiting for the next
 > "idle" moment to perform redisplay, as is the case for normal buffer
 > changes), this result in a lot of wasted work, and it won't truly do
 > what was intended:
 > - If your machine/display is slow enough, you will see it
 > - If your system "prints" messages by speaking them out loud (e.g. with
 >    emacspeak) you will hear them.
 >
 > Why not just do:
 >
 >       (when byte-compile--interactive
 >         (apply #'message format args))
 >
 > ?

But if there are no errors this would not display a message at all with
Glenn's scenario.  IMHO `byte-compile--interactive' puts the cart before
the horse.  Rather, displaying messages should be the default and the
caller should be able to suppress them via a `byte-compile--no-message'
variable or something the like.  So I'd instead use

   (unless byte-compile--no-message
     (apply #'message format args)))

martin





  reply	other threads:[~2015-04-29  7:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 21:31 bug#20445: excessive redisplay / echo area resizing during byte-compilation Glenn Morris
2015-04-27 21:44 ` Glenn Morris
2015-04-28  9:33 ` martin rudalics
2015-04-28 14:26   ` martin rudalics
2015-04-28 15:22     ` Eli Zaretskii
2015-04-28 17:43       ` martin rudalics
2015-04-28 18:00         ` Eli Zaretskii
2015-04-29  7:11           ` martin rudalics
2015-04-28 15:13 ` Eli Zaretskii
2015-04-29  3:21   ` Stefan Monnier
2015-04-29  7:11     ` martin rudalics [this message]
2015-04-29  8:56       ` Artur Malabarba
2015-04-29  8:58         ` Artur Malabarba
2015-04-29  7:37     ` Artur Malabarba
2015-04-29 15:53     ` Eli Zaretskii
2015-04-29 18:35       ` Artur Malabarba
2015-04-29 18:52         ` Artur Malabarba
2015-05-01 10:41           ` martin rudalics
2015-05-01 12:20             ` Artur Malabarba
2015-05-01 13:45               ` martin rudalics
2015-05-01 14:19                 ` Artur Malabarba
2015-05-01 16:28                   ` Artur Malabarba
2015-05-02  8:58                   ` martin rudalics
2015-05-01 10:41         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55408425.5020409@gmx.at \
    --to=rudalics@gmx.at \
    --cc=20445@debbugs.gnu.org \
    --cc=bruce.connor.am@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).